Make depends_on consistent with note in aws_api_gateway_deployment #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the top of the page the note says that the `aws_api_gateway_deployment` resource should include a `depends_on` for the `aws_api_gateway_integration.name` resource, yet the example depends on the `aws_api_gateway_method.MyDemoMethod` resource, which doesn't seem to fix the race condition.
catsby
added a commit
that referenced
this pull request
Dec 19, 2017
* master: (147 commits) Cleaned Data Sources Update CHANGELOG.md resource/cognito_user_pool: Update Cognito email message length to 20,000 (#2692) Update ecs_service.html.markdown (#2694) Documentation: r/ecs_task_definition note about quote escaping container_definition (#2162) Cleanup after v1.6.0 release v1.6.0 Make depends_on consistent with note (#2526) removing duplicate Update CHANGELOG.md r/aws_ssm_parameter: Fix arn attribute for full path names and improve testing Update CHANGELOG.md Update CHANGELOG.md s3: Add validation for SSE Algorithm and correct spelling #2217: fixed when encryption is AES256 #2217: documentation #2217: re-enable default encryption after disabling in via UI #2217: wrote additional acceptance test #2217: wrote typical acceptance test #2217: make fmt ...
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the top of the page the note says that the
aws_api_gateway_deploymentresource should include adepends_onfor theaws_api_gateway_integration.nameresource, yet the example depends on theaws_api_gateway_method.MyDemoMethodresource, which doesn't seem to fix the race condition.Updating the example to match what the note says, so the example works out of the box.