Bump Go version to 1.18.4 #25809
Merged
Bump Go version to 1.18.4 #25809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
provider
gdavison
force-pushed
the
go-1.18
branch
3 times, most recently
from
6487436 to
d6d704d
Compare
|
It looks like Go v1.18.4 is now available in |
ewbankkit
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
LGTM 🚀.
% make
==> Checking that code complies with gofmt requirements...
% make tools
cd tools/providerlint && go install .
cd tools && go install github.com/bflad/tfproviderdocs
cd tools && go install github.com/client9/misspell/cmd/misspell
cd tools && go install github.com/golangci/golangci-lint/cmd/golangci-lint
cd tools && go install github.com/katbyte/terrafmt
cd tools && go install github.com/terraform-linters/tflint
cd tools && go install github.com/pavius/impi/cmd/impi
cd tools && go install github.com/hashicorp/go-changelog/cmd/changelog-build
cd tools && go install github.com/rhysd/actionlint/cmd/actionlint
% make providerlint golangci-lint
==> Checking source code with providerlint...
==> Checking source code with golangci-lint...
WARN [linters context] nilerr is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.
WARN [linters context] structcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.
WARN [linters context] unparam is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.Remove providerlint from the root (it contains vendored dependencies) as it now lives below tools.
Need to update docs/contributing/development-environment.md (and/or the equivalent in #25304) as it mentions the Go version.
Needs a rebase.
I suggest not merging until after this week's release so that we get a full release cycle in nightly CI.
github-actions
bot
added
the
documentation
gdavison
added a commit
to breathingdust/terraform-provider-aws
that referenced
this pull request
Jul 19, 2022
|
This functionality has been released in v4.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
brittandeyoung
pushed a commit
to brittandeyoung/terraform-provider-aws
that referenced
this pull request
Aug 10, 2022
* started index html file * Update index.html * move index + config up so we aren't showing roadmaps * add layout * add roadmaps folder in root * remove layout header * fix formatting * changelog + doc guides * raising content * revising raised a PR * datasource * move faq up, more PR changes * change theme * region edits * resource name generation * update index * last couple large items from checklists file * cleared checklist page * enhance index descriptions * consistent lists * fix link * remove duplicate PR doc * up to prio guide * consolidate maintaining * up to date from main (manual merge) * add wip * point to fork * code annotate * pymdown * back to md from html landing page * fix some broken links * nav complete * brace cleanup * new region * spellcheck * minor tweaks * remove para tags * remove historical roadmaps * appease linters * add resource tagging link * retest top level heading * few more top level revisions * top level headings complete * index capitalization * index capitalization * docs lint appeased * normalize code fencing languages * remove old roadmap * remove old roadmap * clean up links on readme * fix some dead links * fix some dead links * last dead links * move to hashi org for PR * fix read handler link * Update various links in raising a PR, checklist -> list * Correct links and headers in index and add-a-datasource * Update link to Core Services in Prioritization Guide * Correct language, links in development environment * Change checkboxes to list, update links * Remove extra whitespace * Correct links in add-a-new-service * Remove whitespace, correct documentation path in add-a-new-datasource * Fix broken links in add-a-new-region * Update link in add-import-support * Fix broken link in resource-filtering * Change checklist to bulletted list, fix links in resource-filtering * acceptance-tests: fix broken links, checklist->list * data-handling: update links * Update links in error-handling * Update links in retries-and-waiters * Specify preference for ImportStatePassthrough as import state function * Update links in provider-design * Update links in naming * Add notice re: changelog requirement for bugs + enhancements * Update links in faq * Formatting fix * Remove index from data-handling docs * Remove index from provider design docs * Add link / reference to immutable infra as good provider design * Remove index from retries + waiters docs * add links to skaff readme * Apply suggestions from code review Co-authored-by: Graham Davison <g.m.davison@computer.org> Co-authored-by: Adrian Johnson <adrian.johnson@hashicorp.com> Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com> Co-authored-by: Graham Davison <g.m.davison@computer.org> * Apply suggestions from code review Co-authored-by: Graham Davison <g.m.davison@computer.org> Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Graham Davison <g.m.davison@computer.org> Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com> Co-authored-by: Graham Davison <g.m.davison@computer.org> Co-authored-by: Justin Retzolk <44710313+justinretzolk@users.noreply.github.com> * move design section to top * update link * remove question link * settle on draft for preview * Uses footnote style for repeated links * Updates PR instructions * Cleanup * Updates tag generation documentation * Cleanup * Updates resource tagging code documentation * Fixes function name * datasource -> data source * add note about locking closed issues * typo corrections * resource filter reorder * add go sdk page, revamped landing * test third * test third * new nav * remove top level nav from testing page * angie/mary * nav indenti9ng * move submit an issue * swap landing pages * aws go sdk versions * remove TOCs * remove redundant warning and move to welcome * sdk base attempt * base nav * typo * change description * remove prev/next links * master to main * add skaff section * name as link * Adds documentation `AwsSdkVersion` flag on tag generator * Linter fixes * Adds notes on uses of name generation * Updates AWS SDK version documentation * Updates the documentation for adding a new service * Updates development environment documentation, related to hashicorp#25809 * Update contributor documentation for 'acctest.ProtoV5ProviderFactories', 'acctest.ProtoV5FactoriesAlternate' and 'acctest.ProtoV5FactoriesMultipleRegions'. * Remove leading 'error ' from wrapped error messages. * Correct indentation. * Correct location of 'development-environment.md'. * Remove 'docs/index.old'. * yamllint * linkchecker * use branch as deploy targetmain * revert internal changes * remove contrib/maintain * allow workflow dispatch * remove device farm change * device pool from upstream Co-authored-by: Justin Retzolk <44710313+justinretzolk@users.noreply.github.com> Co-authored-by: Zoe Helding <zoe.helding@gmail.com> Co-authored-by: Graham Davison <g.m.davison@computer.org> Co-authored-by: Adrian Johnson <adrian.johnson@hashicorp.com> Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com> Co-authored-by: Graham Davison <gdavison@hashicorp.com> Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps Go version to 1.18.4
Output from acceptance testing: