Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for ASG early errors issue #25987

Merged
merged 24 commits into from
Aug 5, 2022
Merged

Fix for ASG early errors issue #25987

merged 24 commits into from
Aug 5, 2022

Commits on Jul 26, 2022

  1. Add additional tests for ASGs with expected errors

    @obourdon
    obourdon committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    0283547 View commit details
    Browse the repository at this point in the history

  2. Fix for issue hashicorp#25986

    @obourdon
    obourdon committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    2df9a0e View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Adapt old 3.75.x code to 4.2x standards

    @obourdon
    obourdon committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    e8d546e View commit details
    Browse the repository at this point in the history

  2. Fix semgrep CI tests errors

    @obourdon
    obourdon committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    36555b2 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. Add CHANGELOG entry.

    @ewbankkit
    ewbankkit committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    eb07352 View commit details
    Browse the repository at this point in the history

  2. Add 'findScalingActivities' and friends.

    @ewbankkit
    ewbankkit committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    873f495 View commit details
    Browse the repository at this point in the history

  3. r/aws_autoscaling_attachment: Alphabetize attributes.

    @ewbankkit
    ewbankkit committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    4e23e3c View commit details
    Browse the repository at this point in the history

  4. r/aws_autoscaling_attachment: Tidy up resource Create.

    @ewbankkit
    ewbankkit committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    c40f47c View commit details
    Browse the repository at this point in the history

  5. r/aws_autoscaling_attachment: Tidy up resource Delete.

    @ewbankkit
    ewbankkit committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    377b28c View commit details
    Browse the repository at this point in the history

  6. r/aws_autoscaling_attachment: Tidy up resource Read.

    @ewbankkit
    ewbankkit committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    164a39d View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. r/aws_autoscaling_attachment: Tidy up ELB attachment tests.

    @ewbankkit
    ewbankkit committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    fd20f16 View commit details
    Browse the repository at this point in the history

  2. r/aws_autoscaling_attachment: Tidy up target group attachment tests.

    @ewbankkit
    ewbankkit committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    86638b5 View commit details
    Browse the repository at this point in the history

  3. r/aws_autoscaling_attachment: Tidy up resource Read.

    @ewbankkit
    ewbankkit committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    febab4a View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. r/aws_autoscaling_group: Add 'waitGroupCapacitySatisfied' and friends.

    @ewbankkit
    ewbankkit committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    a4ae91a View commit details
    Browse the repository at this point in the history

  2. Remove 'waitForASGCapacity' etc.

    @ewbankkit
    ewbankkit committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    32ac2c7 View commit details
    Browse the repository at this point in the history

  3. r/aws_autoscaling_group: Tweak scaling activity error acceptance tests.

    @ewbankkit
    ewbankkit committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    be45d0f View commit details
    Browse the repository at this point in the history

  4. Remove 'TestAccAutoScalingGroup_withScalingActivityErrorMissingInstan… 

    …ceCapabilities'.
    @ewbankkit
    ewbankkit committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    0d562bd View commit details
    Browse the repository at this point in the history

  5. r/aws_autoscaling_schedule: Tidy up acceptance tests. 

    Acceptance test output:

% make testacc TESTARGS='-run=TestAccAutoScalingSchedule_' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingSchedule_ -timeout 180m
=== RUN   TestAccAutoScalingSchedule_basic
=== PAUSE TestAccAutoScalingSchedule_basic
=== RUN   TestAccAutoScalingSchedule_disappears
=== PAUSE TestAccAutoScalingSchedule_disappears
=== RUN   TestAccAutoScalingSchedule_recurrence
=== PAUSE TestAccAutoScalingSchedule_recurrence
=== RUN   TestAccAutoScalingSchedule_zeroValues
=== PAUSE TestAccAutoScalingSchedule_zeroValues
=== RUN   TestAccAutoScalingSchedule_negativeOne
=== PAUSE TestAccAutoScalingSchedule_negativeOne
=== CONT  TestAccAutoScalingSchedule_basic
=== CONT  TestAccAutoScalingSchedule_zeroValues
--- PASS: TestAccAutoScalingSchedule_basic (182.66s)
=== CONT  TestAccAutoScalingSchedule_negativeOne
--- PASS: TestAccAutoScalingSchedule_zeroValues (182.71s)
=== CONT  TestAccAutoScalingSchedule_recurrence
--- PASS: TestAccAutoScalingSchedule_recurrence (181.77s)
=== CONT  TestAccAutoScalingSchedule_disappears
--- PASS: TestAccAutoScalingSchedule_negativeOne (193.97s)
--- PASS: TestAccAutoScalingSchedule_disappears (196.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	572.196s
    @ewbankkit
    ewbankkit committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    166c211 View commit details
    Browse the repository at this point in the history

  6. r/aws_autoscaling_schedule: Tidy up resource Create. 

    Acceptance test output:

% make testacc TESTARGS='-run=TestAccAutoScalingSchedule_' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingSchedule_ -timeout 180m
=== RUN   TestAccAutoScalingSchedule_basic
=== PAUSE TestAccAutoScalingSchedule_basic
=== RUN   TestAccAutoScalingSchedule_disappears
=== PAUSE TestAccAutoScalingSchedule_disappears
=== RUN   TestAccAutoScalingSchedule_recurrence
=== PAUSE TestAccAutoScalingSchedule_recurrence
=== RUN   TestAccAutoScalingSchedule_zeroValues
=== PAUSE TestAccAutoScalingSchedule_zeroValues
=== RUN   TestAccAutoScalingSchedule_negativeOne
=== PAUSE TestAccAutoScalingSchedule_negativeOne
=== CONT  TestAccAutoScalingSchedule_basic
=== CONT  TestAccAutoScalingSchedule_negativeOne
--- PASS: TestAccAutoScalingSchedule_negativeOne (169.20s)
=== CONT  TestAccAutoScalingSchedule_recurrence
--- PASS: TestAccAutoScalingSchedule_basic (180.91s)
=== CONT  TestAccAutoScalingSchedule_zeroValues
--- PASS: TestAccAutoScalingSchedule_recurrence (177.14s)
=== CONT  TestAccAutoScalingSchedule_disappears
--- PASS: TestAccAutoScalingSchedule_zeroValues (167.20s)
--- PASS: TestAccAutoScalingSchedule_disappears (171.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	521.968s
    @ewbankkit
    ewbankkit committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    5e383f3 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into HEAD

    @ewbankkit
    ewbankkit committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    56eb039 View commit details
    Browse the repository at this point in the history

  8. Fix golangci-lint 'nilerr'.

    @ewbankkit
    ewbankkit committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    ab7d4c0 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. r/aws_autoscaling_group: Report capacity error via result State. 

    Acceptance test output:

% make testacc TESTARGS='-run=TestAccAutoScalingGroup_largeDesiredCapacity\|TestAccAutoScalingGroup_withNoScalingActivityErrorCorrectInstanceArchitecture' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingGroup_largeDesiredCapacity\|TestAccAutoScalingGroup_withNoScalingActivityErrorCorrectInstanceArchitecture -timeout 180m
=== RUN   TestAccAutoScalingGroup_withNoScalingActivityErrorCorrectInstanceArchitecture
=== PAUSE TestAccAutoScalingGroup_withNoScalingActivityErrorCorrectInstanceArchitecture
=== RUN   TestAccAutoScalingGroup_largeDesiredCapacity
=== PAUSE TestAccAutoScalingGroup_largeDesiredCapacity
=== CONT  TestAccAutoScalingGroup_withNoScalingActivityErrorCorrectInstanceArchitecture
=== CONT  TestAccAutoScalingGroup_largeDesiredCapacity
--- PASS: TestAccAutoScalingGroup_withNoScalingActivityErrorCorrectInstanceArchitecture (177.83s)
--- PASS: TestAccAutoScalingGroup_largeDesiredCapacity (270.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	274.091s
    @ewbankkit
    ewbankkit committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    5d9b565 View commit details
    Browse the repository at this point in the history

  2. Tweak error messages.

    @ewbankkit
    ewbankkit committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    960d6da View commit details
    Browse the repository at this point in the history

  3. Nudge GitHub.

    @ewbankkit
    ewbankkit committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    4c503ed View commit details
    Browse the repository at this point in the history