Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating partition_keys schema in glue.catalog_table according to AWS documentation #26702

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CarlinCyril
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26686
I updated the Schema of 'partition_keys' with the attribute 'parameters' as Optional.
I also updated testAccCatalogTableConfig_target which is about the issue here but was not complete enough to cover it. So I updated it so it includes partition_keys

Output from acceptance testing:

This is a "best effort" implementation of acceptance tests as it uses the Glue package which can be cost prohibitive. I would appreciate if someone could run the updated acceptance test for me. Thank you ! 😊

Adding 'parameters' attribute to partition_keys schema
Modifying acceptance test for target aws_glue_catalog_table (resource link) so it is more complete and covers the above modification
@github-actions github-actions bot added service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/glue Issues and PRs that pertain to the glue service. labels Sep 8, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @CarlinCyril 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/glue Issues and PRs that pertain to the glue service. labels Sep 8, 2022
@CarlinCyril CarlinCyril marked this pull request as ready for review September 8, 2022 12:40
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 8, 2022
@anuradhawick
Copy link

@CarlinCyril it seems this was never merged and I am facing the issue. Especially when doing terraform apply on subsequent deployments. Could this be looked at again? Thanks :)

Some others have this too #26686

@gelphilhowe
Copy link

gelphilhowe commented Aug 9, 2024

As noted in the issue linked above, this is still an issue in provider version 5.54.1 and is causing us quite a bit of trouble at the moment.

@justinretzolk would you have time to have another look at this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
5 participants