-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating partition_keys schema in glue.catalog_table according to AWS documentation #26702
base: main
Are you sure you want to change the base?
Updating partition_keys schema in glue.catalog_table according to AWS documentation #26702
Conversation
Adding 'parameters' attribute to partition_keys schema Modifying acceptance test for target aws_glue_catalog_table (resource link) so it is more complete and covers the above modification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @CarlinCyril 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
@CarlinCyril it seems this was never merged and I am facing the issue. Especially when doing terraform apply on subsequent deployments. Could this be looked at again? Thanks :) Some others have this too #26686 |
As noted in the issue linked above, this is still an issue in provider version @justinretzolk would you have time to have another look at this one? |
Community Note
Closes #26686
I updated the Schema of 'partition_keys' with the attribute 'parameters' as Optional.
I also updated testAccCatalogTableConfig_target which is about the issue here but was not complete enough to cover it. So I updated it so it includes partition_keys
Output from acceptance testing:
This is a "best effort" implementation of acceptance tests as it uses the Glue package which can be cost prohibitive. I would appreciate if someone could run the updated acceptance test for me. Thank you ! 😊