Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F enable application layer automatic response #27066

Closed
wants to merge 12 commits into from
Closed

F enable application layer automatic response #27066

wants to merge 12 commits into from

Conversation

Pixxle
Copy link

@Pixxle Pixxle commented Oct 3, 2022

Description

Creating new Terraform Resource aws_shield_advanced_automatic_layer_protection

Relations

Closes #26873

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccShieldProtection_automaticLayerResponse PKG=shield 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/shield/... -v -count 1 -parallel 20 -run='TestAccShieldProtection_automaticLayerResponse'  -timeout 180m
=== RUN   TestAccShieldProtection_automaticLayerResponse
=== PAUSE TestAccShieldProtection_automaticLayerResponse
=== CONT  TestAccShieldProtection_automaticLayerResponse
    testing_new.go:84: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Error deleting WAFv2 WebACL: WAFOptimisticLockException: AWS WAF couldn’t save your changes because someone changed the resource after you started to edit it. Reapply your changes.
        
--- FAIL: TestAccShieldProtection_automaticLayerResponse (279.05s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/shield     281.913s
FAIL
...

Tests are currently failing due to AWS modifying rulegroups in webacl after automatic layer resource has been deleted. Any idea on how to implement this and still respecting web_acl lock token? I don't want to modifying the state of another "unrelated" resource (web_acl) when removing terraform aws_shield_advanced_automatic_layer_protection resource.

Should i maybe add a optional flag in aws_wafv2_web_acl that makes it possible to ignore changes to lock_token?
Maybe this(#21136) reported bug needs to be solved before this resource is possible to implement?

Please provide some feedback on how to proceed with this.

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/shield Issues and PRs that pertain to the shield service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/shield Issues and PRs that pertain to the shield service. provider Pertains to the provider itself, rather than any interaction with AWS. needs-triage Waiting for first response or review from a maintainer. labels Oct 3, 2022
@ewbankkit ewbankkit added new-resource Introduces a new resource. service/shield Issues and PRs that pertain to the shield service. labels Oct 3, 2022
@Pixxle Pixxle closed this by deleting the head repository Feb 13, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/shield Issues and PRs that pertain to the shield service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws advanced shield - EnableApplicationLayerAutomaticResponse
2 participants