-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F enable application layer automatic response #27066
Closed
Pixxle
wants to merge
12
commits into
hashicorp:main
from
Pixxle:f-enable-application-layer-automatic-response
Closed
F enable application layer automatic response #27066
Pixxle
wants to merge
12
commits into
hashicorp:main
from
Pixxle:f-enable-application-layer-automatic-response
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all tests manually towards aws
… with wafv2 rule being modified after aws_shield_advanced_automatic_layer_protection association
…w failing during deletion step
…ctionDelete ( trying to circomvent WAFOptimisticLockException )
Community NoteVoting for Prioritization
For Submitters
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
new-resource
Introduces a new resource.
service/shield
Issues and PRs that pertain to the shield service.
size/XL
Managed by automation to categorize the size of a PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating new Terraform Resource
aws_shield_advanced_automatic_layer_protection
Relations
Closes #26873
References
Output from Acceptance Testing
Tests are currently failing due to AWS modifying rulegroups in webacl after automatic layer resource has been deleted. Any idea on how to implement this and still respecting web_acl lock token? I don't want to modifying the state of another "unrelated" resource (web_acl) when removing terraform aws_shield_advanced_automatic_layer_protection resource.
Should i maybe add a optional flag in aws_wafv2_web_acl that makes it possible to ignore changes to lock_token?
Maybe this(#21136) reported bug needs to be solved before this resource is possible to implement?
Please provide some feedback on how to proceed with this.