Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-adjust feature to aws_budget #27474

Merged
merged 24 commits into from
Oct 28, 2022
Merged

Add auto-adjust feature to aws_budget #27474

merged 24 commits into from
Oct 28, 2022

Commits on Aug 21, 2022

  1. Configuration menu
    Copy the full SHA
    8c58c9b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fe01bf1 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Configuration menu
    Copy the full SHA
    18c538d View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. added handlers

    breathingdust committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    be32841 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    33523c7 View commit details
    Browse the repository at this point in the history
  3. test passing

    breathingdust committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    4716377 View commit details
    Browse the repository at this point in the history
  4. historical

    breathingdust committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    1167c61 View commit details
    Browse the repository at this point in the history
  5. historical test

    breathingdust committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    5a0a698 View commit details
    Browse the repository at this point in the history
  6. remove comments

    breathingdust committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    4ad5419 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. terrafmt

    breathingdust committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    bf7314b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    db67745 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    676e954 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    05accec View commit details
    Browse the repository at this point in the history
  5. r/aws_budgets_budget_action: Switch to 'WithoutTimeout' CRUD handlers (

    …#15090).
    
    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccBudgetsBudgetAction_' PKG=budgets ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/budgets/... -v -count 1 -parallel 2  -run=TestAccBudgetsBudgetAction_ -timeout 180m
    === RUN   TestAccBudgetsBudgetAction_basic
    === PAUSE TestAccBudgetsBudgetAction_basic
    === RUN   TestAccBudgetsBudgetAction_disappears
    === PAUSE TestAccBudgetsBudgetAction_disappears
    === CONT  TestAccBudgetsBudgetAction_basic
    === CONT  TestAccBudgetsBudgetAction_disappears
    --- PASS: TestAccBudgetsBudgetAction_disappears (25.10s)
    --- PASS: TestAccBudgetsBudgetAction_basic (35.33s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/budgets	39.355s
    ewbankkit committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    162efb3 View commit details
    Browse the repository at this point in the history
  6. Budgets: Tidy up sweepers.

    ewbankkit committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    f33f9c6 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. add auto adjust docs

    breathingdust committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    254511c View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. r/aws_budgets_budget: Switch to 'WithoutTimeout' CRUD handlers (#15090).

    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccBudgetsBudget_' PKG=budgets ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/budgets/... -v -count 1 -parallel 2  -run=TestAccBudgetsBudget_ -timeout 180m
    === RUN   TestAccBudgetsBudget_basic
    === PAUSE TestAccBudgetsBudget_basic
    === RUN   TestAccBudgetsBudget_Name_generated
    === PAUSE TestAccBudgetsBudget_Name_generated
    === RUN   TestAccBudgetsBudget_namePrefix
    === PAUSE TestAccBudgetsBudget_namePrefix
    === RUN   TestAccBudgetsBudget_disappears
    === PAUSE TestAccBudgetsBudget_disappears
    === RUN   TestAccBudgetsBudget_autoAdjustDataForecast
    === PAUSE TestAccBudgetsBudget_autoAdjustDataForecast
    === RUN   TestAccBudgetsBudget_autoAdjustDataHistorical
    === PAUSE TestAccBudgetsBudget_autoAdjustDataHistorical
    === RUN   TestAccBudgetsBudget_costTypes
    === PAUSE TestAccBudgetsBudget_costTypes
    === RUN   TestAccBudgetsBudget_notifications
    === PAUSE TestAccBudgetsBudget_notifications
    === CONT  TestAccBudgetsBudget_basic
    === CONT  TestAccBudgetsBudget_autoAdjustDataForecast
    --- PASS: TestAccBudgetsBudget_autoAdjustDataForecast (19.37s)
    === CONT  TestAccBudgetsBudget_notifications
    --- PASS: TestAccBudgetsBudget_basic (19.50s)
    === CONT  TestAccBudgetsBudget_costTypes
    --- PASS: TestAccBudgetsBudget_costTypes (27.49s)
    === CONT  TestAccBudgetsBudget_autoAdjustDataHistorical
    --- PASS: TestAccBudgetsBudget_notifications (31.83s)
    === CONT  TestAccBudgetsBudget_namePrefix
    === CONT  TestAccBudgetsBudget_autoAdjustDataHistorical
        budget_test.go:203: Step 1/3 error: Check failed: Check 5/12 error: aws_budgets_budget.test: Attribute 'auto_adjust_data.0.historical_options.0.lookback_available_periods' expected "2", got "0"
    --- FAIL: TestAccBudgetsBudget_autoAdjustDataHistorical (8.55s)
    === CONT  TestAccBudgetsBudget_disappears
    --- PASS: TestAccBudgetsBudget_disappears (11.86s)
    === CONT  TestAccBudgetsBudget_Name_generated
    --- PASS: TestAccBudgetsBudget_namePrefix (16.41s)
    --- PASS: TestAccBudgetsBudget_Name_generated (18.48s)
    FAIL
    FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/budgets	90.021s
    FAIL
    make: *** [testacc] Error 1
    ewbankkit committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    fbbd907 View commit details
    Browse the repository at this point in the history
  2. r/aws_budgets_budget: Fix 'TestAccBudgetsBudget_autoAdjustDataHistori…

    …cal'.
    
    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccBudgetsBudget_autoAdjustDataHistorical' PKG=budgets ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/budgets/... -v -count 1 -parallel 2  -run=TestAccBudgetsBudget_autoAdjustDataHistorical -timeout 180m
    === RUN   TestAccBudgetsBudget_autoAdjustDataHistorical
    === PAUSE TestAccBudgetsBudget_autoAdjustDataHistorical
    === CONT  TestAccBudgetsBudget_autoAdjustDataHistorical
    --- PASS: TestAccBudgetsBudget_autoAdjustDataHistorical (27.47s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/budgets	31.473s
    ewbankkit committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    87e3280 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    66489b5 View commit details
    Browse the repository at this point in the history
  4. r/aws_budgets_budget: Add 'planned_limit' configuration block.

    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccBudgetsBudget_' PKG=budgets ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/budgets/... -v -count 1 -parallel 2  -run=TestAccBudgetsBudget_ -timeout 180m
    === RUN   TestAccBudgetsBudget_basic
    === PAUSE TestAccBudgetsBudget_basic
    === RUN   TestAccBudgetsBudget_Name_generated
    === PAUSE TestAccBudgetsBudget_Name_generated
    === RUN   TestAccBudgetsBudget_namePrefix
    === PAUSE TestAccBudgetsBudget_namePrefix
    === RUN   TestAccBudgetsBudget_disappears
    === PAUSE TestAccBudgetsBudget_disappears
    === RUN   TestAccBudgetsBudget_autoAdjustDataForecast
    === PAUSE TestAccBudgetsBudget_autoAdjustDataForecast
    === RUN   TestAccBudgetsBudget_autoAdjustDataHistorical
    === PAUSE TestAccBudgetsBudget_autoAdjustDataHistorical
    === RUN   TestAccBudgetsBudget_costTypes
    === PAUSE TestAccBudgetsBudget_costTypes
    === RUN   TestAccBudgetsBudget_notifications
    === PAUSE TestAccBudgetsBudget_notifications
    === CONT  TestAccBudgetsBudget_basic
    === CONT  TestAccBudgetsBudget_notifications
    --- PASS: TestAccBudgetsBudget_basic (23.25s)
    === CONT  TestAccBudgetsBudget_autoAdjustDataForecast
    --- PASS: TestAccBudgetsBudget_autoAdjustDataForecast (17.94s)
    === CONT  TestAccBudgetsBudget_costTypes
    --- PASS: TestAccBudgetsBudget_notifications (43.26s)
    === CONT  TestAccBudgetsBudget_autoAdjustDataHistorical
    --- PASS: TestAccBudgetsBudget_costTypes (27.08s)
    === CONT  TestAccBudgetsBudget_namePrefix
    --- PASS: TestAccBudgetsBudget_autoAdjustDataHistorical (27.34s)
    === CONT  TestAccBudgetsBudget_disappears
    --- PASS: TestAccBudgetsBudget_disappears (12.01s)
    === CONT  TestAccBudgetsBudget_Name_generated
    --- PASS: TestAccBudgetsBudget_namePrefix (16.22s)
    --- PASS: TestAccBudgetsBudget_Name_generated (17.16s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/budgets	103.805s
    ewbankkit committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    0b6caad View commit details
    Browse the repository at this point in the history
  5. r/aws_budgets_budget: Add 'TestAccBudgetsBudget_plannedLimits'.

    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccBudgetsBudget_plannedLimits' PKG=budgets ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/budgets/... -v -count 1 -parallel 2  -run=TestAccBudgetsBudget_plannedLimits -timeout 180m
    === RUN   TestAccBudgetsBudget_plannedLimits
    === PAUSE TestAccBudgetsBudget_plannedLimits
    === CONT  TestAccBudgetsBudget_plannedLimits
    --- PASS: TestAccBudgetsBudget_plannedLimits (27.92s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/budgets	31.996s
    ewbankkit committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    47c0c85 View commit details
    Browse the repository at this point in the history
  6. Add CHANGELOG entry.

    ewbankkit committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    d73b0ed View commit details
    Browse the repository at this point in the history
  7. Fix terrafmt errors.

    ewbankkit committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    232e030 View commit details
    Browse the repository at this point in the history
  8. Fix terrafmt errors.

    ewbankkit committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    83e6258 View commit details
    Browse the repository at this point in the history