aws_connect_routing_profile: increase the hardcoded queue limit to AWS default value of 50

[dttung2905]

Description

In the aws_connect_routing_profile, increase hardcoded limit queues per routing profile from 10 to 50, which is similar to AWS default quota

Relations

Closes #27014

References

Output from Acceptance Testing

Could any reviewer help me to run the Acc Test please ? Thank you very much in advance

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @dttung2905 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[dttung2905]

Hi @YakDriver , could you help me to review this PR of mine? Its a small change imo. Thank you v much

[dttung2905]

Hi @justinretzolk, could you help me review this PR, or help me find someone who can, if possible ? Thanks alot !

[GlennChia]

Thanks for making this PR @dttung2905 👍 Good catch for the default service quota. From the Amazon Connect service quotas documentation, it mentions that Queues per routing profile per instance is an Adjustable quota. Hence, the MaxItems check can be removed entirely. Made suggestions in-line in this PR for reference. Do let me know if you have any questions!

[dttung2905]

Hi @GlennChia,
Thanks very much for the review. I have made changes from your suggestion. Could you help to take a look at it again 🙏 ?

[GlennChia]

Hi @dttung2905, thanks for your changes, the changes look good! Upon checking the APIs again, the Create and Associate both have limits of 10 per API call:

• https://docs.aws.amazon.com/connect/latest/APIReference/API_CreateRoutingProfile.html#connect-CreateRoutingProfile-request-QueueConfigs.
• https://docs.aws.amazon.com/connect/latest/APIReference/API_AssociateRoutingProfileQueues.html#connect-AssociateRoutingProfileQueues-request-QueueConfigs

This means that the logic for the resource will have to be changed to do a batched association of queue configs. This depends on an existing PR to be merged first which does some logic refactoring #26151. Once that PR is merged, this PR can merge in those changes and implement the batched logic

[GlennChia]

Hi @dttung2905, looks like the dependent PR is merged. Would be great if you can rebase on main and modify the logic to do batched associations. Thanks!

[dttung2905]

Sure @GlennChia I will do that later this week 🙏

[TrentMacDougall]

Hi @dttung2905 , @GlennChia
Has this update been released yet?
Very interested in this batching, as I have a build with over 50 queues and implemented my own batching, but would very much like to use an official version.

[GlennChia]

Hi @TrentMacDougall, thanks for the follow up on this. @dttung2905 is working on this feature but I'll be happy to help review it when it's ready 👍

[GlennChia]

Hi @dttung2905, just checking in since we have quite a couple of requests coming in for this feature. Are you intending to work on the batched associations feature? I would love to take it up and help unblock users if you're ok with it? Thanks!

[dttung2905]

Hey, @GlennChia . So sorry I have been pretty busy with work and life recently. Please go ahead with your implementation and help me unblock our community users. Thanks alot 🙏

[GlennChia]

Thanks for the quick update @dttung2905, I've raised a PR to fix this issue and help unblock community users. Thanks for raising the original PR to highlight the issue 😃

@TrentMacDougall, please find the updated PR that implements the batched feature at #30895, would appreciate your help to add thumbs to PR to give it more visibility.

[github-actions]

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.