Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in arib_captions_pid and arib_captions_pid_control #29467

Merged
merged 3 commits into from
Feb 20, 2023
Merged

fix typo in arib_captions_pid and arib_captions_pid_control #29467

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e30546c
Change arib_caption_pid to arib_captions_pid
quartercastle Feb 16, 2023
169d0bb
fix issue with arib_captions_pid_control as well
quartercastle Feb 17, 2023
5ce2a91
Add changelog
quartercastle Feb 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/service/medialive/channel_encoder_settings_schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3962,10 +3962,10 @@ func expandM2tsSettings(tfList []interface{}) *types.M2tsSettings {
if v, ok := m["arib"].(string); ok && v != "" {
s.Arib = types.M2tsArib(v)
}
if v, ok := m["arib_caption_pid"].(string); ok && v != "" {
if v, ok := m["arib_captions_pid"].(string); ok && v != "" {
s.AribCaptionsPid = aws.String(v)
}
if v, ok := m["arib_caption_pid_control"].(string); ok && v != "" {
if v, ok := m["arib_captions_pid_control"].(string); ok && v != "" {
s.AribCaptionsPidControl = types.M2tsAribCaptionsPidControl(v)
}
if v, ok := m["audio_buffer_model"].(string); ok && v != "" {
Expand Down
24 changes: 14 additions & 10 deletions internal/service/medialive/channel_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,13 @@ func TestAccMediaLiveChannel_m2ts_settings(t *testing.T) {
"name": "test-video-name",
}),
resource.TestCheckTypeSetElemNestedAttrs(resourceName, "encoder_settings.0.output_groups.0.outputs.0.output_settings.0.archive_output_settings.0.container_settings.0.m2ts_settings.*", map[string]string{
"audio_buffer_model": "ATSC",
"buffer_model": "MULTIPLEX",
"rate_mode": "CBR",
"audio_pids": "200",
"dvb_sub_pids": "300",
"audio_buffer_model": "ATSC",
"buffer_model": "MULTIPLEX",
"rate_mode": "CBR",
"audio_pids": "200",
"dvb_sub_pids": "300",
"arib_captions_pid": "100",
"arib_captions_pid_control": "AUTO",
}),
),
},
Expand Down Expand Up @@ -782,11 +784,13 @@ resource "aws_medialive_channel" "test" {
extension = "m2ts"
container_settings {
m2ts_settings {
audio_buffer_model = "ATSC"
buffer_model = "MULTIPLEX"
rate_mode = "CBR"
audio_pids = "200"
dvb_sub_pids = "300"
audio_buffer_model = "ATSC"
buffer_model = "MULTIPLEX"
rate_mode = "CBR"
audio_pids = "200"
dvb_sub_pids = "300"
arib_captions_pid = "100"
arib_captions_pid_control = "AUTO"
}
}
}
Expand Down