feat: Lake Formation add external data filtering and session tags.

[phzietsman]

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request

Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Description

API now accepts more arguments for datalake settings (namely AllowExternalDataFiltering, ExternalDataFilteringAllowList and AuthorizedSessionTagValueList).

This PR aims to add the related arguments to the aws_lakeformation_data_lake_settings resource, and the corresponding attributes to the data source.

Relations

Closes #26932

Also closes stale PR #27042

References

put-data-lake-settings API doc

Output from Acceptance Testing

$ make testacc TESTS=TestAccLakeFormation_serial/DataLakeSettings PKG=lakeformation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20 -run='TestAccLakeFormation_serial/DataLakeSettings'  -timeout 180m
=== RUN   TestAccLakeFormation_serial
=== PAUSE TestAccLakeFormation_serial
=== CONT  TestAccLakeFormation_serial
=== RUN   TestAccLakeFormation_serial/DataLakeSettings
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/disappears
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/withoutCatalogId
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/basic
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/dataSource
--- PASS: TestAccLakeFormation_serial (135.77s)
    --- PASS: TestAccLakeFormation_serial/DataLakeSettings (135.77s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/disappears (34.85s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/withoutCatalogId (35.05s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/basic (31.18s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/dataSource (34.69s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation      137.631s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[phzietsman]

@ewbankkit / @gdavison a similar PR has been stale for while, I've added all the missing bits and I think this one is ready now. I've not done an enhancement before, so not sure what the title should be. 🙏

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLakeFormation_serial/DataLakeSettings' PKG=lakeformation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20  -run=TestAccLakeFormation_serial/DataLakeSettings -timeout 180m
=== RUN   TestAccLakeFormation_serial
=== PAUSE TestAccLakeFormation_serial
=== CONT  TestAccLakeFormation_serial
=== RUN   TestAccLakeFormation_serial/DataLakeSettings
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/dataSource
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/disappears
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/withoutCatalogId
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/basic
--- PASS: TestAccLakeFormation_serial (83.30s)
    --- PASS: TestAccLakeFormation_serial/DataLakeSettings (83.30s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/dataSource (24.33s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/disappears (20.36s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/withoutCatalogId (18.99s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/basic (19.63s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	94.229s

[ewbankkit]

@phzietsman Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.