Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golangci-lint nolintlint errors #30252

Closed
wants to merge 2 commits into from
Closed

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Mar 24, 2023

Description

Fixes golangci-lint errors like:

  Error: directive `//nolint: unused // used in a skipped test` is unused for linter "unused" (nolintlint)
  Error: directive `//nolint: unused // used in a skipped test` is unused for linter "unused" (nolintlint)

Relations

Relates #30140.
Relates #30219.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/cognitoidp Issues and PRs that pertain to the cognitoidp service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 24, 2023
@ewbankkit ewbankkit added the linter Pertains to changes to or issues with the various linters. label Mar 24, 2023
@jar-b
Copy link
Member

jar-b commented Mar 24, 2023

Sorry - didn't see this PR and grouped these fixes in with #30249

@github-actions github-actions bot removed the linter Pertains to changes to or issues with the various linters. label Mar 24, 2023
@ewbankkit ewbankkit closed this Mar 24, 2023
@ewbankkit ewbankkit deleted the td-fix-golangci-lint branch March 24, 2023 21:34
@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Mar 24, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/cognitoidp Issues and PRs that pertain to the cognitoidp service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants