New resource aws_quicksight_folder

[comtef]

Description

Implementation of aws_quicksight_folder.

I refactored common code for permissions and fixed an issue as all permissions needs to be included in grants, even already present actions. Otherwise, the API raises this kind of error:

Error: error updating QuickSight Folder (tf-acc-test-6965107116578139189) permissions: InvalidParameterValueException: ResourcePermission list contains unsupported permission sets [quicksight:CreateFolderMembership, quicksight:CreateFolder, quicksight:UpdateFolderPermissions, quicksight:UpdateFolder, quicksight:DeleteFolder, quicksight:DeleteFolderMembership, quicksight:DescribeFolderPermissions] for this resource. Valid sets : [quicksight:DescribeFolder] or [quicksight:CreateFolder, quicksight:DescribeFolder, quicksight:UpdateFolder, quicksight:DeleteFolder, quicksight:CreateFolderMembership, quicksight:DeleteFolderMembership, quicksight:DescribeFolderPermissions, quicksight:UpdateFolderPermissions]

Relations

Relates #10990
Closes #23083

References

https://docs.aws.amazon.com/quicksight/latest/APIReference/API_CreateFolder.html
https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DeleteFolder.html
https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DescribeFolder.html
https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DescribeFolderPermissions.html
https://docs.aws.amazon.com/quicksight/latest/APIReference/API_UpdateFolder.html
https://docs.aws.amazon.com/quicksight/latest/APIReference/API_UpdateFolderPermissions.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccQuickSightFolder PKG=quicksight
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightFolder'  -timeout 180m
=== RUN   TestAccQuickSightFolder_basic
=== PAUSE TestAccQuickSightFolder_basic
=== RUN   TestAccQuickSightFolder_disappears
=== PAUSE TestAccQuickSightFolder_disappears
=== RUN   TestAccQuickSightFolder_permissions
=== PAUSE TestAccQuickSightFolder_permissions
=== RUN   TestAccQuickSightFolder_tags
=== PAUSE TestAccQuickSightFolder_tags
=== RUN   TestAccQuickSightFolder_parentFolder
=== PAUSE TestAccQuickSightFolder_parentFolder
=== CONT  TestAccQuickSightFolder_basic
=== CONT  TestAccQuickSightFolder_permissions
=== CONT  TestAccQuickSightFolder_parentFolder
=== CONT  TestAccQuickSightFolder_tags
=== CONT  TestAccQuickSightFolder_disappears
--- PASS: TestAccQuickSightFolder_disappears (19.27s)
--- PASS: TestAccQuickSightFolder_basic (25.62s)
--- PASS: TestAccQuickSightFolder_tags (26.41s)
--- PASS: TestAccQuickSightFolder_parentFolder (27.20s)
--- PASS: TestAccQuickSightFolder_permissions (62.16s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 62.257s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🎉

$ make testacc PKG=quicksight TESTS=TestAccQuickSightFolder_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightFolder_'  -timeout 180m
=== RUN   TestAccQuickSightFolder_basic
=== PAUSE TestAccQuickSightFolder_basic
=== RUN   TestAccQuickSightFolder_disappears
=== PAUSE TestAccQuickSightFolder_disappears
=== RUN   TestAccQuickSightFolder_permissions
=== PAUSE TestAccQuickSightFolder_permissions
=== RUN   TestAccQuickSightFolder_tags
=== PAUSE TestAccQuickSightFolder_tags
=== RUN   TestAccQuickSightFolder_parentFolder
=== PAUSE TestAccQuickSightFolder_parentFolder
=== CONT  TestAccQuickSightFolder_basic
=== CONT  TestAccQuickSightFolder_tags
=== CONT  TestAccQuickSightFolder_permissions
=== CONT  TestAccQuickSightFolder_parentFolder
=== CONT  TestAccQuickSightFolder_disappears
--- PASS: TestAccQuickSightFolder_disappears (13.91s)
--- PASS: TestAccQuickSightFolder_basic (19.86s)
--- PASS: TestAccQuickSightFolder_parentFolder (42.51s)
--- PASS: TestAccQuickSightFolder_tags (51.28s)
--- PASS: TestAccQuickSightFolder_permissions (60.60s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 64.131s

[jar-b]

Thanks for your contribution, @comtef! 👏

[github-actions]

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.