-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: aws_pipes_pipe #30538
New Resource: aws_pipes_pipe #30538
Conversation
Community NoteVoting for Prioritization
For Submitters
|
163a0f9
to
805f8f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccPipesPipe_' PKG=pipes ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/pipes/... -v -count 1 -parallel 3 -run=TestAccPipesPipe_ -timeout 180m
=== RUN TestAccPipesPipe_basic
=== PAUSE TestAccPipesPipe_basic
=== RUN TestAccPipesPipe_disappears
=== PAUSE TestAccPipesPipe_disappears
=== RUN TestAccPipesPipe_description
=== PAUSE TestAccPipesPipe_description
=== RUN TestAccPipesPipe_desiredState
=== PAUSE TestAccPipesPipe_desiredState
=== RUN TestAccPipesPipe_enrichment
=== PAUSE TestAccPipesPipe_enrichment
=== RUN TestAccPipesPipe_sourceParameters_filterCriteria
=== PAUSE TestAccPipesPipe_sourceParameters_filterCriteria
=== RUN TestAccPipesPipe_nameGenerated
=== PAUSE TestAccPipesPipe_nameGenerated
=== RUN TestAccPipesPipe_namePrefix
=== PAUSE TestAccPipesPipe_namePrefix
=== RUN TestAccPipesPipe_roleARN
=== PAUSE TestAccPipesPipe_roleARN
=== RUN TestAccPipesPipe_tags
=== PAUSE TestAccPipesPipe_tags
=== RUN TestAccPipesPipe_target
=== PAUSE TestAccPipesPipe_target
=== RUN TestAccPipesPipe_targetParameters_inputTemplate
=== PAUSE TestAccPipesPipe_targetParameters_inputTemplate
=== CONT TestAccPipesPipe_basic
=== CONT TestAccPipesPipe_nameGenerated
=== CONT TestAccPipesPipe_tags
--- PASS: TestAccPipesPipe_basic (123.53s)
=== CONT TestAccPipesPipe_targetParameters_inputTemplate
--- PASS: TestAccPipesPipe_nameGenerated (133.61s)
=== CONT TestAccPipesPipe_target
--- PASS: TestAccPipesPipe_tags (163.25s)
=== CONT TestAccPipesPipe_roleARN
--- PASS: TestAccPipesPipe_target (179.40s)
=== CONT TestAccPipesPipe_desiredState
--- PASS: TestAccPipesPipe_targetParameters_inputTemplate (207.23s)
=== CONT TestAccPipesPipe_sourceParameters_filterCriteria
--- PASS: TestAccPipesPipe_roleARN (174.07s)
=== CONT TestAccPipesPipe_enrichment
--- PASS: TestAccPipesPipe_desiredState (215.36s)
=== CONT TestAccPipesPipe_namePrefix
--- PASS: TestAccPipesPipe_enrichment (208.81s)
=== CONT TestAccPipesPipe_description
--- PASS: TestAccPipesPipe_namePrefix (115.71s)
=== CONT TestAccPipesPipe_disappears
--- PASS: TestAccPipesPipe_sourceParameters_filterCriteria (315.04s)
--- PASS: TestAccPipesPipe_disappears (111.60s)
--- PASS: TestAccPipesPipe_description (263.79s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/pipes 818.235s
@roberth-k Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds the
aws_pipes_pipe
reosurce.Not all attributes have been implemented. Specifically, this PR only includes generic source and target parameters, but none specific to particular sources and targets. Additional parameter configuration blocks will be implemented in future PR-s. This is due to quirks in the Pipes API.
For the time being, the
source_parameters
andtarget_parameters
are set asRequired: true
to simplify certain edge cases. This may be relaxed in a future PR.Relations
Relates #28153
References
Output from Acceptance Testing