Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_pipes_pipe #30538

Merged
merged 22 commits into from
Apr 10, 2023
Merged

Conversation

roberth-k
Copy link
Contributor

Description

Adds the aws_pipes_pipe reosurce.

Not all attributes have been implemented. Specifically, this PR only includes generic source and target parameters, but none specific to particular sources and targets. Additional parameter configuration blocks will be implemented in future PR-s. This is due to quirks in the Pipes API.

For the time being, the source_parameters and target_parameters are set as Required: true to simplify certain edge cases. This may be relaxed in a future PR.

Relations

Relates #28153

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccPipesPipe_ PKG=pipes
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/pipes/... -v -count 1 -parallel 20 -run='TestAccPipesPipe_'  -timeout 180m
=== RUN   TestAccPipesPipe_basic
=== PAUSE TestAccPipesPipe_basic
=== RUN   TestAccPipesPipe_disappears
=== PAUSE TestAccPipesPipe_disappears
=== RUN   TestAccPipesPipe_description
=== PAUSE TestAccPipesPipe_description
=== RUN   TestAccPipesPipe_desiredState
=== PAUSE TestAccPipesPipe_desiredState
=== RUN   TestAccPipesPipe_enrichment
=== PAUSE TestAccPipesPipe_enrichment
=== RUN   TestAccPipesPipe_sourceParameters_filterCriteria
=== PAUSE TestAccPipesPipe_sourceParameters_filterCriteria
=== RUN   TestAccPipesPipe_nameGenerated
=== PAUSE TestAccPipesPipe_nameGenerated
=== RUN   TestAccPipesPipe_namePrefix
=== PAUSE TestAccPipesPipe_namePrefix
=== RUN   TestAccPipesPipe_roleARN
=== PAUSE TestAccPipesPipe_roleARN
=== RUN   TestAccPipesPipe_tags
=== PAUSE TestAccPipesPipe_tags
=== RUN   TestAccPipesPipe_target
=== PAUSE TestAccPipesPipe_target
=== RUN   TestAccPipesPipe_targetParameters_inputTemplate
=== PAUSE TestAccPipesPipe_targetParameters_inputTemplate
=== CONT  TestAccPipesPipe_basic
=== CONT  TestAccPipesPipe_nameGenerated
=== CONT  TestAccPipesPipe_desiredState
=== CONT  TestAccPipesPipe_tags
=== CONT  TestAccPipesPipe_sourceParameters_filterCriteria
=== CONT  TestAccPipesPipe_disappears
=== CONT  TestAccPipesPipe_enrichment
=== CONT  TestAccPipesPipe_roleARN
=== CONT  TestAccPipesPipe_description
=== CONT  TestAccPipesPipe_namePrefix
=== CONT  TestAccPipesPipe_targetParameters_inputTemplate
=== CONT  TestAccPipesPipe_target
--- PASS: TestAccPipesPipe_disappears (125.61s)
--- PASS: TestAccPipesPipe_namePrefix (131.54s)
--- PASS: TestAccPipesPipe_basic (131.78s)
--- PASS: TestAccPipesPipe_nameGenerated (132.98s)
--- PASS: TestAccPipesPipe_tags (163.26s)
--- PASS: TestAccPipesPipe_target (191.03s)
--- PASS: TestAccPipesPipe_roleARN (199.05s)
--- PASS: TestAccPipesPipe_targetParameters_inputTemplate (222.21s)
--- PASS: TestAccPipesPipe_desiredState (225.53s)
--- PASS: TestAccPipesPipe_enrichment (225.53s)
--- PASS: TestAccPipesPipe_description (277.33s)
--- PASS: TestAccPipesPipe_sourceParameters_filterCriteria (366.77s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/pipes      368.862s

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/pipes Issues and PRs that pertain to the pipes service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Apr 7, 2023
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 10, 2023
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Apr 10, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccPipesPipe_' PKG=pipes ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/pipes/... -v -count 1 -parallel 3  -run=TestAccPipesPipe_ -timeout 180m
=== RUN   TestAccPipesPipe_basic
=== PAUSE TestAccPipesPipe_basic
=== RUN   TestAccPipesPipe_disappears
=== PAUSE TestAccPipesPipe_disappears
=== RUN   TestAccPipesPipe_description
=== PAUSE TestAccPipesPipe_description
=== RUN   TestAccPipesPipe_desiredState
=== PAUSE TestAccPipesPipe_desiredState
=== RUN   TestAccPipesPipe_enrichment
=== PAUSE TestAccPipesPipe_enrichment
=== RUN   TestAccPipesPipe_sourceParameters_filterCriteria
=== PAUSE TestAccPipesPipe_sourceParameters_filterCriteria
=== RUN   TestAccPipesPipe_nameGenerated
=== PAUSE TestAccPipesPipe_nameGenerated
=== RUN   TestAccPipesPipe_namePrefix
=== PAUSE TestAccPipesPipe_namePrefix
=== RUN   TestAccPipesPipe_roleARN
=== PAUSE TestAccPipesPipe_roleARN
=== RUN   TestAccPipesPipe_tags
=== PAUSE TestAccPipesPipe_tags
=== RUN   TestAccPipesPipe_target
=== PAUSE TestAccPipesPipe_target
=== RUN   TestAccPipesPipe_targetParameters_inputTemplate
=== PAUSE TestAccPipesPipe_targetParameters_inputTemplate
=== CONT  TestAccPipesPipe_basic
=== CONT  TestAccPipesPipe_nameGenerated
=== CONT  TestAccPipesPipe_tags
--- PASS: TestAccPipesPipe_basic (123.53s)
=== CONT  TestAccPipesPipe_targetParameters_inputTemplate
--- PASS: TestAccPipesPipe_nameGenerated (133.61s)
=== CONT  TestAccPipesPipe_target
--- PASS: TestAccPipesPipe_tags (163.25s)
=== CONT  TestAccPipesPipe_roleARN
--- PASS: TestAccPipesPipe_target (179.40s)
=== CONT  TestAccPipesPipe_desiredState
--- PASS: TestAccPipesPipe_targetParameters_inputTemplate (207.23s)
=== CONT  TestAccPipesPipe_sourceParameters_filterCriteria
--- PASS: TestAccPipesPipe_roleARN (174.07s)
=== CONT  TestAccPipesPipe_enrichment
--- PASS: TestAccPipesPipe_desiredState (215.36s)
=== CONT  TestAccPipesPipe_namePrefix
--- PASS: TestAccPipesPipe_enrichment (208.81s)
=== CONT  TestAccPipesPipe_description
--- PASS: TestAccPipesPipe_namePrefix (115.71s)
=== CONT  TestAccPipesPipe_disappears
--- PASS: TestAccPipesPipe_sourceParameters_filterCriteria (315.04s)
--- PASS: TestAccPipesPipe_disappears (111.60s)
--- PASS: TestAccPipesPipe_description (263.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pipes	818.235s

@ewbankkit
Copy link
Contributor

@roberth-k Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0cc2d9c into hashicorp:main Apr 10, 2023
@github-actions github-actions bot added this to the v4.63.0 milestone Apr 10, 2023
@github-actions
Copy link

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/pipes Issues and PRs that pertain to the pipes service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants