aws_nat_gateway: add association_id attribute to resource and data source

[roberth-k]

Description

Adds the association_id attribute to the aws_nat_gateway resource and data source.

The association_id (and other attributes, such as allocation_id) are now chosen based on whether a given IP address is designated as the primary IP address of the NAT Gateway.

A subsequent PR will add secondary associations as an independent resource.

Relations

Relates #29471

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccVPCNATGateway_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCNATGateway_'  -timeout 180m
go: downloading github.com/aws/aws-sdk-go-v2/service/healthlake v1.15.7
=== RUN   TestAccVPCNATGateway_basic
=== PAUSE TestAccVPCNATGateway_basic
=== RUN   TestAccVPCNATGateway_disappears
=== PAUSE TestAccVPCNATGateway_disappears
=== RUN   TestAccVPCNATGateway_ConnectivityType_private
=== PAUSE TestAccVPCNATGateway_ConnectivityType_private
=== RUN   TestAccVPCNATGateway_privateIP
=== PAUSE TestAccVPCNATGateway_privateIP
=== RUN   TestAccVPCNATGateway_tags
=== PAUSE TestAccVPCNATGateway_tags
=== CONT  TestAccVPCNATGateway_basic
=== CONT  TestAccVPCNATGateway_privateIP
=== CONT  TestAccVPCNATGateway_ConnectivityType_private
=== CONT  TestAccVPCNATGateway_disappears
=== CONT  TestAccVPCNATGateway_tags
--- PASS: TestAccVPCNATGateway_ConnectivityType_private (188.09s)
--- PASS: TestAccVPCNATGateway_basic (195.61s)
--- PASS: TestAccVPCNATGateway_privateIP (200.23s)
--- PASS: TestAccVPCNATGateway_disappears (233.69s)
--- PASS: TestAccVPCNATGateway_tags (248.98s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        251.101s

$ make testacc TESTS=TestAccVPCNATGatewayDataSource_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCNATGatewayDataSource_'  -timeout 180m
=== RUN   TestAccVPCNATGatewayDataSource_basic
=== PAUSE TestAccVPCNATGatewayDataSource_basic
=== CONT  TestAccVPCNATGatewayDataSource_basic
--- PASS: TestAccVPCNATGatewayDataSource_basic (206.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        208.112s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCNATGateway' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCNATGateway -timeout 180m
=== RUN   TestAccVPCNATGatewayDataSource_basic
=== PAUSE TestAccVPCNATGatewayDataSource_basic
=== RUN   TestAccVPCNATGateway_basic
=== PAUSE TestAccVPCNATGateway_basic
=== RUN   TestAccVPCNATGateway_disappears
=== PAUSE TestAccVPCNATGateway_disappears
=== RUN   TestAccVPCNATGateway_ConnectivityType_private
=== PAUSE TestAccVPCNATGateway_ConnectivityType_private
=== RUN   TestAccVPCNATGateway_privateIP
=== PAUSE TestAccVPCNATGateway_privateIP
=== RUN   TestAccVPCNATGateway_tags
=== PAUSE TestAccVPCNATGateway_tags
=== RUN   TestAccVPCNATGatewaysDataSource_basic
=== PAUSE TestAccVPCNATGatewaysDataSource_basic
=== CONT  TestAccVPCNATGatewayDataSource_basic
=== CONT  TestAccVPCNATGateway_privateIP
=== CONT  TestAccVPCNATGateway_disappears
--- PASS: TestAccVPCNATGatewayDataSource_basic (147.75s)
=== CONT  TestAccVPCNATGateway_ConnectivityType_private
--- PASS: TestAccVPCNATGateway_privateIP (169.30s)
=== CONT  TestAccVPCNATGateway_basic
--- PASS: TestAccVPCNATGateway_disappears (195.81s)
=== CONT  TestAccVPCNATGatewaysDataSource_basic
--- PASS: TestAccVPCNATGateway_ConnectivityType_private (178.33s)
=== CONT  TestAccVPCNATGateway_tags
--- PASS: TestAccVPCNATGateway_basic (188.52s)
--- PASS: TestAccVPCNATGatewaysDataSource_basic (202.64s)
--- PASS: TestAccVPCNATGateway_tags (239.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	571.281s

[ewbankkit]

@roberth-k Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.