Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-transit-gateway-routes): prepare changelog #30772

Merged
merged 22 commits into from
Aug 4, 2023

Conversation

Maarc-D
Copy link
Contributor

@Maarc-D Maarc-D commented Apr 17, 2023

Description

implementation of #30771

Relations

Closes #30771

References

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_SearchTransitGatewayRoutes.html
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_TransitGatewayRoute.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Apr 17, 2023
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 17, 2023
@Maarc-D Maarc-D force-pushed the feat/data-transit-gateway-routes branch from 2f7eacd to 5d035bf Compare April 17, 2023 13:16
@Maarc-D Maarc-D marked this pull request as draft April 17, 2023 13:17
@Maarc-D Maarc-D changed the title Draft: feat(data-transit-gateway-routes): prepare changelog feat(data-transit-gateway-routes): prepare changelog Apr 17, 2023
@Maarc-D Maarc-D force-pushed the feat/data-transit-gateway-routes branch from 5d035bf to fa3c5a2 Compare April 24, 2023 06:35
@github-actions github-actions bot added service/transitgateway Issues and PRs that pertain to the transitgateway service. size/M Managed by automation to categorize the size of a PR. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. generators Relates to code generators. and removed size/XS Managed by automation to categorize the size of a PR. size/M Managed by automation to categorize the size of a PR. size/L Managed by automation to categorize the size of a PR. labels Apr 24, 2023
@Maarc-D
Copy link
Contributor Author

Maarc-D commented Apr 24, 2023

The routes list is empty for now :/ need to see why, maybe type or affectation issue as if I use a filter of non exiting type for exemple it raise correctly and issue of empty I made. si I get route but it's not return. I'm closer to achive this I can smell it :p

@Maarc-D
Copy link
Contributor Author

Maarc-D commented Apr 25, 2023

The routes list is empty for now :/ need to see why, maybe type or affectation issue as if I use a filter of non exiting type for exemple it raise correctly and issue of empty I made. si I get route but it's not return. I'm closer to achive this I can smell it :p

As thank was a mistake in "translation" to create the data, need to test on my real production project but on a poc worked as a charm :
image

@Maarc-D Maarc-D force-pushed the feat/data-transit-gateway-routes branch 8 times, most recently from 623ed82 to 84ed3ff Compare April 26, 2023 06:42
@Maarc-D
Copy link
Contributor Author

Maarc-D commented Apr 26, 2023

Worked as well in the complexe usecase we have on production with a mesh of transit gateways :

image
image

@Maarc-D Maarc-D force-pushed the feat/data-transit-gateway-routes branch 2 times, most recently from 5e970ad to 253570a Compare June 7, 2023 07:37
@Maarc-D Maarc-D force-pushed the feat/data-transit-gateway-routes branch from 253570a to 7576905 Compare June 7, 2023 08:48
@Maarc-D
Copy link
Contributor Author

Maarc-D commented Jun 7, 2023

To resolve the last CI issue I used a -v arg to the "golangci-lint" command : https://github.com/hashicorp/terraform-provider-aws/blob/main/.github/workflows/golangci-lint.yml#L62 that print file name and line.

I tried to propose a PR with that little update but seams that we are not allowed to propose a modification of this file

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransitGatewayDataSource_serial/^RouteTableRoutes$$' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGatewayDataSource_serial/^RouteTableRoutes$ -timeout 180m
=== RUN   TestAccTransitGatewayDataSource_serial
=== PAUSE TestAccTransitGatewayDataSource_serial
=== CONT  TestAccTransitGatewayDataSource_serial
=== RUN   TestAccTransitGatewayDataSource_serial/RouteTableRoutes
=== RUN   TestAccTransitGatewayDataSource_serial/RouteTableRoutes/basic
--- PASS: TestAccTransitGatewayDataSource_serial (307.79s)
    --- PASS: TestAccTransitGatewayDataSource_serial/RouteTableRoutes (307.79s)
        --- PASS: TestAccTransitGatewayDataSource_serial/RouteTableRoutes/basic (307.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	313.008s

@ewbankkit
Copy link
Contributor

@Maarc-D Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 1c429dc into hashicorp:main Aug 4, 2023
41 checks passed
@github-actions github-actions bot added this to the v5.12.0 milestone Aug 4, 2023
@github-actions
Copy link

This functionality has been released in v5.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/transitgateway Issues and PRs that pertain to the transitgateway service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Retrieve transit gateway routes
3 participants