-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data-transit-gateway-routes): prepare changelog #30772
feat(data-transit-gateway-routes): prepare changelog #30772
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that the Remove any changes to the |
2f7eacd
to
5d035bf
Compare
5d035bf
to
fa3c5a2
Compare
The |
623ed82
to
84ed3ff
Compare
…ackage_gen + test blind
5e970ad
to
253570a
Compare
253570a
to
7576905
Compare
To resolve the last CI issue I used a -v arg to the "golangci-lint" command : https://github.com/hashicorp/terraform-provider-aws/blob/main/.github/workflows/golangci-lint.yml#L62 that print file name and line. I tried to propose a PR with that little update but seams that we are not allowed to propose a modification of this file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccTransitGatewayDataSource_serial/^RouteTableRoutes$$' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccTransitGatewayDataSource_serial/^RouteTableRoutes$ -timeout 180m
=== RUN TestAccTransitGatewayDataSource_serial
=== PAUSE TestAccTransitGatewayDataSource_serial
=== CONT TestAccTransitGatewayDataSource_serial
=== RUN TestAccTransitGatewayDataSource_serial/RouteTableRoutes
=== RUN TestAccTransitGatewayDataSource_serial/RouteTableRoutes/basic
--- PASS: TestAccTransitGatewayDataSource_serial (307.79s)
--- PASS: TestAccTransitGatewayDataSource_serial/RouteTableRoutes (307.79s)
--- PASS: TestAccTransitGatewayDataSource_serial/RouteTableRoutes/basic (307.79s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 313.008s
@Maarc-D Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
implementation of #30771
Relations
Closes #30771
References
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_SearchTransitGatewayRoutes.html
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_TransitGatewayRoute.html
Output from Acceptance Testing