Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: V5 Upgrade guide additions #31294

Merged
merged 3 commits into from
May 10, 2023
Merged

[Docs]: V5 Upgrade guide additions #31294

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3628a14
docs: rds, docdb, neptune cluster snapshot_identifier upgrade topics
jar-b May 9, 2023
80d15c1
docs: aws_autoscaling_group tags deprecation
jar-b May 9, 2023
c8cc010
docs: aws_api_gateway_rest_api minimum_compression_size type change
jar-b May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions website/docs/guides/version-5-upgrade.html.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,19 @@ Upgrade topics:

- [Provider Version Configuration](#provider-version-configuration)
- [Provider Arguments](#provider-arguments)
- [Data Source: aws_api_gateway_rest_api](#data-source-aws_api_gateway_rest_api)
- [Data Source: aws_redshift_service_account](#data-source-aws_redshift_service_account)
- [Data Source: aws_subnet_ids](#data-source-aws_subnet_ids)
- [Resource: aws_acmpca_certificate_authority](#resource-aws_acmpca_certificate_authority)
- [Resource: aws_api_gateway_rest_api](#resource-aws_api_gateway_rest_api)
- [Resource: aws_autoscaling_group](#resource-aws_autoscaling_group)
- [Resource: aws_ce_anomaly_subscription](#resource-aws_ce_anomaly_subscription)
- [Resource: aws_cloudwatch_event_target](#resource-aws_cloudwatch_event_target)
- [Resource: aws_docdb_cluster](#resource-aws_docdb_cluster)
- [Resource: aws_ec2_client_vpn_endpoint](#resource-aws_ec2_client_vpn_endpoint)
- [Resource: aws_ec2_client_vpn_network_association](#resource-aws_ec2_client_vpn_network_association)
- [Resource: aws_neptune_cluster](#resource-aws_neptune_cluster)
- [Resource: aws_rds_cluster](#resource-aws_rds_cluster)

<!-- /TOC -->

Expand Down Expand Up @@ -91,6 +97,14 @@ Version 5.0.0 removes these `provider` arguments:

The `status` attribute is superfluous and sometimes incorrect. It has been removed.

## Resource: aws_api_gateway_rest_api

The `minimum_compression_size` attribute is now a String type, allowing it to be computed when set via the `body` attribute. Valid values remain the same.

## Resource: aws_autoscaling_group

The `tags` attribute has been removed. Use the `tag` attribute instead. For use cases requiring dynamic tags, see the [Dynamic Tagging example](../r/autoscaling_group.html.markdown#dynamic-tagging).

## Resource: aws_ce_anomaly_subscription

The `threshold` attribute has been removed.
Expand All @@ -99,6 +113,12 @@ The `threshold` attribute has been removed.

The `ecs_target.propagate_tags` attribute now has no default value. If no value is specified, the tags are not propagated.

## Resource: aws_docdb_cluster

Changes to the `snapshot_identifier` attribute will now correctly force re-creation of the resource. Previously, changing this attribute would result in a successful apply, but without the cluster being restored (only the resource state was changed). This change brings behavior of the cluster `snapshot_identifier` attribute into alignment with other RDS resources, such as `aws_db_instance`.

Automated snapshots **should not** be used for this attribute, unless from a different cluster. Automated snapshots are deleted as part of cluster destruction when the resource is replaced.

## Resource: aws_ec2_client_vpn_endpoint

The `status` attribute has been removed.
Expand All @@ -107,6 +127,22 @@ The `status` attribute has been removed.

The `status` attribute has been removed.

## Resource: aws_neptune_cluster

Changes to the `snapshot_identifier` attribute will now correctly force re-creation of the resource. Previously, changing this attribute would result in a successful apply, but without the cluster being restored (only the resource state was changed). This change brings behavior of the cluster `snapshot_identifier` attribute into alignment with other RDS resources, such as `aws_db_instance`.

Automated snapshots **should not** be used for this attribute, unless from a different cluster. Automated snapshots are deleted as part of cluster destruction when the resource is replaced.

## Resource: aws_rds_cluster

Changes to the `snapshot_identifier` attribute will now correctly force re-creation of the resource. Previously, changing this attribute would result in a successful apply, but without the cluster being restored (only the resource state was changed). This change brings behavior of the cluster `snapshot_identifier` attribute into alignment with other RDS resources, such as `aws_db_instance`.

Automated snapshots **should not** be used for this attribute, unless from a different cluster. Automated snapshots are deleted as part of cluster destruction when the resource is replaced.

## Data Source: aws_api_gateway_rest_api

The `minimum_compression_size` attribute is now a String type, allowing it to be computed when set via the `body` attribute.

## Data Source: aws_redshift_service_account

[AWS document](https://docs.aws.amazon.com/redshift/latest/mgmt/db-auditing.html#db-auditing-bucket-permissions) that [a service principal name](https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_elements_principal.html#principal-services) be used instead of AWS account ID in any relevant IAM policy.
Expand Down