Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing wafregional resources #3199

Closed
wants to merge 6 commits into from

Conversation

BSick7
Copy link
Contributor

@BSick7 BSick7 commented Jan 30, 2018

This PR amends the following PRs with updates to finalize:

I have left @DennyLoko commits intact with minor revisions amended.

@ghost ghost added the size/XXL Managed by automation to categorize the size of a PR. label Jan 30, 2018
@radeksimko
Copy link
Member

Hi @BSick7
I appreciate the effort but I think I'd prefer to review 1 PR per resource. Do you mind splitting it up?

Thanks.

@BSick7
Copy link
Contributor Author

BSick7 commented Jan 30, 2018

Doh!
Will do @radeksimko!

@radeksimko radeksimko added service/waf Issues and PRs that pertain to the waf service. new-resource Introduces a new resource. waiting-response Maintainers are waiting on response from community or contributor. labels Jan 31, 2018
@lamont
Copy link

lamont commented Feb 15, 2018

Is there anything I can do to help or review this request? I sure would enjoy regional_waf resources.

@pvanbuijtene
Copy link
Contributor

pvanbuijtene commented Mar 12, 2018

I appreciate the effort but I think I'd prefer to review 1 PR per resource. Do you mind splitting it up?

@radeksimko trying to help a bit with the PRs, I've split it up and rebased it.

Will also help with the review feedback.

@radeksimko
Copy link
Member

Closing in favour of #3754 and #3755

#3756 was just merged and will be part of the next release.

@radeksimko radeksimko closed this Mar 18, 2018
@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/waf Issues and PRs that pertain to the waf service. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants