Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_lakeformation_resource_lf_tags: Correctly reads table column tags with inheritance #32201

Merged
merged 8 commits into from
Jun 26, 2023

Conversation

gdavison
Copy link
Contributor

Description

When LF-Tags were defined on table columns as well as either database or table, the incorrect tags were returned for the table columns

Relations

Closes #31909

Output from Acceptance Testing

$ make testacc PKG=lakeformation TESTS=TestAccLakeFormation_serial/ResourceLFTags

--- PASS: TestAccLakeFormation_serial (202.59s)
    --- PASS: TestAccLakeFormation_serial/ResourceLFTags (202.58s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/table (33.85s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/tableWithColumns (37.04s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/basic (16.65s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/database (31.39s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/databaseMultipleTags (30.63s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/disappears (16.99s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/hierarchy (36.02s)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/lakeformation Issues and PRs that pertain to the lakeformation service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 23, 2023
@github-actions github-actions bot added the create Pertains to generating names, hashcodes, etc. label Jun 24, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc PKG=lakeformation TESTS=TestAccLakeFormation_serial/ResourceLFTags
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20 -run='TestAccLakeFormation_serial/ResourceLFTags'  -timeout 180m
=== RUN   TestAccLakeFormation_serial
=== PAUSE TestAccLakeFormation_serial
=== CONT  TestAccLakeFormation_serial
=== RUN   TestAccLakeFormation_serial/ResourceLFTags
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/database
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/databaseMultipleTags
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/disappears
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/hierarchy
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/table
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/tableWithColumns
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/basic
--- PASS: TestAccLakeFormation_serial (257.91s)
    --- PASS: TestAccLakeFormation_serial/ResourceLFTags (257.91s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/database (39.19s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/databaseMultipleTags (36.75s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/disappears (20.52s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/hierarchy (54.36s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/table (44.98s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/tableWithColumns (40.35s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/basic (21.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	263.625s

Needs a CHANGELOG entry.

@gdavison gdavison merged commit cec3221 into main Jun 26, 2023
@gdavison gdavison deleted the b-lakeformation-tags branch June 26, 2023 17:33
@github-actions github-actions bot added this to the v5.6.0 milestone Jun 26, 2023
github-actions bot pushed a commit that referenced this pull request Jun 26, 2023
@github-actions
Copy link

This functionality has been released in v5.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create Pertains to generating names, hashcodes, etc. service/lakeformation Issues and PRs that pertain to the lakeformation service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Resource tag state reads ignorant of inheritance
2 participants