Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Migrate internetmonitor resources to AWS SDK for Go v2 #32343

Merged
merged 13 commits into from
Jul 3, 2023
Merged

Tech debt: Migrate internetmonitor resources to AWS SDK for Go v2 #32343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ed0afe9
Use AWS SDK for Go v2 for internetmonitor service.
ewbankkit Jul 1, 2023
1e5854e
Add 'names.InternetMonitorEndpointID'.
ewbankkit Jul 1, 2023
ae0dd56
Run 'make gen'.
ewbankkit Jul 1, 2023
91b355c
internetmonitor: Generate AWS SDK for Go v2 tagging code.
ewbankkit Jul 1, 2023
8125bff
Run 'go get github.com/aws/aws-sdk-go-v2/service/internetmonitor@v1.3…
ewbankkit Jul 1, 2023
0d3c45f
Add '-SkipTypesImp' when generating tagging code.
ewbankkit Jul 1, 2023
39682e5
Add '-KVTValues' when generating tagging code.
ewbankkit Jul 1, 2023
e471a39
r/aws_internetmonitor_monitor: Migrate to AWS SDK for Go v2.
ewbankkit Jul 1, 2023
869e763
For some reason 'errs.IsA[*types.ResourceNotFoundException]' does not…
ewbankkit Jul 1, 2023
9a5a3ce
r/aws_internetmonitor_monitor: Add 'health_events_config' configurati…
ewbankkit Jul 1, 2023
613fee7
internetmonitor: Migrate sweepers to AWS SDK for Go v2.
ewbankkit Jul 1, 2023
e099c73
Merge branch 'main' into td-migrate-internetmonitor-to-aws-sdk-v2
ewbankkit Jul 3, 2023
942f5c6
Correct CHANGELOG entry file name.
ewbankkit Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/32343.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/aws_internetmonitor_monitor: Add `health_events_config` configuration block
```
1 change: 1 addition & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ require (
github.com/aws/aws-sdk-go-v2/service/healthlake v1.16.2
github.com/aws/aws-sdk-go-v2/service/identitystore v1.16.13
github.com/aws/aws-sdk-go-v2/service/inspector2 v1.15.0
github.com/aws/aws-sdk-go-v2/service/internetmonitor v1.3.0
github.com/aws/aws-sdk-go-v2/service/ivschat v1.4.7
github.com/aws/aws-sdk-go-v2/service/kendra v1.41.0
github.com/aws/aws-sdk-go-v2/service/keyspaces v1.3.2
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.9.28 h1:bkRyG4a92
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.9.28/go.mod h1:jj7znCIg05jXlaGBlFMGP8+7UN3VtCkRBG2spnmRQkU=
github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.14.3 h1:dBL3StFxHtpBzJJ/mNEsjXVgfO+7jR0dAIEwLqMapEA=
github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.14.3/go.mod h1:f1QyiAsvIv4B49DmCqrhlXqyaR+0IxMmyX+1P+AnzOM=
github.com/aws/aws-sdk-go-v2/service/internetmonitor v1.3.0 h1:qy8Ko+RdwqmhmHmFdTX9BBGArWEbQV7iuIvFroxfy/g=
github.com/aws/aws-sdk-go-v2/service/internetmonitor v1.3.0/go.mod h1:dopruDWBqM3sxYZWprHj065umhsYqKfzTgpv21od6us=
github.com/aws/aws-sdk-go-v2/service/ivschat v1.4.7 h1:pI950CQHVEFW2/+UklRO4TWzHdO83bedFO9s6vH1R3k=
github.com/aws/aws-sdk-go-v2/service/ivschat v1.4.7/go.mod h1:oOLFrfP14cyQdTsc3I8VohdYb8g86I7xduoMALyKLj0=
github.com/aws/aws-sdk-go-v2/service/kendra v1.41.0 h1:QZIaiIYfU8KCUuT4nCif9fifXryv+/pI/ounZMB4/0s=
Expand Down
6 changes: 3 additions & 3 deletions internal/conns/awsclient_gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions internal/service/internetmonitor/exports_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package internetmonitor

// Exports for use in tests only.
var (
ResourceMonitor = resourceMonitor

FindMonitorByName = findMonitorByName
)
31 changes: 0 additions & 31 deletions internal/service/internetmonitor/find.go
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion internal/service/internetmonitor/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:generate go run ../../generate/tags/main.go -ListTags -ListTagsInIDElem=ResourceArn -ServiceTagsMap -TagInIDElem=ResourceArn -UpdateTags
//go:generate go run ../../generate/tags/main.go -AWSSDKVersion=2 -ListTags -ListTagsInIDElem=ResourceArn -ServiceTagsMap -KVTValues -TagInIDElem=ResourceArn -UpdateTags -SkipTypesImp
//go:generate go run ../../generate/servicepackage/main.go
// ONLY generate directives and package declaration! Do not add anything else to this file.

Expand Down
Loading