r/aws_vpc and r/aws_default_vpc use AWS SDKv2 #32368

mattburgess · 2023-07-04T23:13:53Z

Description

Migrate aws_vpc and aws_default_vpc over to use v2 of the AWS SDK. In order to avoid having to migrate all callers of the various Find, Wait, and Status functions, this PR introduces V2 equivalents with the intention that they'll be renamed back again wholesale once the last of the callers of the original functions have been removed.

This is a 'tentative' PR - I don't mind doing the work to convert other resources over to the v2 SDK as and when time allows, but appreciate it's a lot of code churn and a large number of PRs will be required, so can well imagine you might not want to entertain them.

Relations

Relates #31345 (inasmuch as if we can remove all callers of the v1 SDK it may shrink the binary size down a bit, but I fully appreciate that's a mammoth undertaking).

References

Output from Acceptance Testing

$ ACCTEST_PARALLELISM=1 make testacc TESTS='TestAccVPC_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 1 -run='TestAccVPC_'  -timeout 180m
=== RUN   TestAccVPC_basic
=== PAUSE TestAccVPC_basic
=== RUN   TestAccVPC_disappears
=== PAUSE TestAccVPC_disappears
=== RUN   TestAccVPC_tags
=== PAUSE TestAccVPC_tags
=== RUN   TestAccVPC_tags_computed
=== PAUSE TestAccVPC_tags_computed
=== RUN   TestAccVPC_tags_null
=== PAUSE TestAccVPC_tags_null
=== RUN   TestAccVPC_DefaultTags_zeroValue
=== PAUSE TestAccVPC_DefaultTags_zeroValue
=== RUN   TestAccVPC_DefaultTags_providerOnlyTestAccVPC_DefaultTags_providerOnly
=== PAUSE TestAccVPC_DefaultTags_providerOnlyTestAccVPC_DefaultTags_providerOnly
=== RUN   TestAccVPC_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPC_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPC_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPC_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_moveDuplicateTags
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_moveDuplicateTags
=== RUN   TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== RUN   TestAccVPC_DynamicResourceTags_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTags_ignoreChanges
=== RUN   TestAccVPC_defaultAndIgnoreTags
=== PAUSE TestAccVPC_defaultAndIgnoreTags
=== RUN   TestAccVPC_ignoreTags
=== PAUSE TestAccVPC_ignoreTags
=== RUN   TestAccVPC_tenancy
=== PAUSE TestAccVPC_tenancy
=== RUN   TestAccVPC_updateDNSHostnames
=== PAUSE TestAccVPC_updateDNSHostnames
=== RUN   TestAccVPC_bothDNSOptionsSet
=== PAUSE TestAccVPC_bothDNSOptionsSet
=== RUN   TestAccVPC_disabledDNSSupport
=== PAUSE TestAccVPC_disabledDNSSupport
=== RUN   TestAccVPC_enableNetworkAddressUsageMetrics
=== PAUSE TestAccVPC_enableNetworkAddressUsageMetrics
=== RUN   TestAccVPC_assignGeneratedIPv6CIDRBlock
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlock
=== RUN   TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
=== RUN   TestAccVPC_IPAMIPv4BasicNetmask
=== PAUSE TestAccVPC_IPAMIPv4BasicNetmask
=== RUN   TestAccVPC_IPAMIPv4BasicExplicitCIDR
=== PAUSE TestAccVPC_IPAMIPv4BasicExplicitCIDR
=== RUN   TestAccVPC_IPAMIPv6
=== PAUSE TestAccVPC_IPAMIPv6
=== CONT  TestAccVPC_basic
--- PASS: TestAccVPC_basic (38.51s)
=== CONT  TestAccVPC_DynamicResourceTags_ignoreChanges
--- PASS: TestAccVPC_DynamicResourceTags_ignoreChanges (62.02s)
=== CONT  TestAccVPC_IPAMIPv6
--- PASS: TestAccVPC_IPAMIPv6 (1198.69s)
=== CONT  TestAccVPC_IPAMIPv4BasicExplicitCIDR
--- PASS: TestAccVPC_IPAMIPv4BasicExplicitCIDR (1208.56s)
=== CONT  TestAccVPC_IPAMIPv4BasicNetmask
--- PASS: TestAccVPC_IPAMIPv4BasicNetmask (1169.63s)
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
    ec2_availability_zone_data_source_test.go:222: skipping since no Local Zones are available
--- SKIP: TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup (0.97s)
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlock
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlock (123.20s)
=== CONT  TestAccVPC_enableNetworkAddressUsageMetrics
--- PASS: TestAccVPC_enableNetworkAddressUsageMetrics (50.67s)
=== CONT  TestAccVPC_disabledDNSSupport
--- PASS: TestAccVPC_disabledDNSSupport (49.27s)
=== CONT  TestAccVPC_bothDNSOptionsSet
--- PASS: TestAccVPC_bothDNSOptionsSet (47.41s)
=== CONT  TestAccVPC_updateDNSHostnames
--- PASS: TestAccVPC_updateDNSHostnames (68.81s)
=== CONT  TestAccVPC_tenancy
--- PASS: TestAccVPC_tenancy (92.93s)
=== CONT  TestAccVPC_ignoreTags
--- PASS: TestAccVPC_ignoreTags (66.61s)
=== CONT  TestAccVPC_defaultAndIgnoreTags
--- PASS: TestAccVPC_defaultAndIgnoreTags (66.35s)
=== CONT  TestAccVPC_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPC_DefaultTags_updateToProviderOnly (54.70s)
=== CONT  TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
--- PASS: TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges (61.83s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag (71.07s)
=== CONT  TestAccVPC_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPC_DefaultTags_updateToResourceOnly (54.11s)
=== CONT  TestAccVPC_tags_null
--- PASS: TestAccVPC_tags_null (32.52s)
=== CONT  TestAccVPC_DefaultTags_providerOnlyTestAccVPC_DefaultTags_providerOnly
--- PASS: TestAccVPC_DefaultTags_providerOnlyTestAccVPC_DefaultTags_providerOnly (72.20s)
=== CONT  TestAccVPC_DefaultTags_zeroValue
--- PASS: TestAccVPC_DefaultTags_zeroValue (67.90s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_moveDuplicateTags
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_moveDuplicateTags (75.16s)
=== CONT  TestAccVPC_tags
--- PASS: TestAccVPC_tags (94.28s)
=== CONT  TestAccVPC_tags_computed
--- PASS: TestAccVPC_tags_computed (35.24s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_overlappingTag (70.64s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_duplicateTag (23.94s)
=== CONT  TestAccVPC_disappears
--- PASS: TestAccVPC_disappears (26.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	4983.337s

github-actions · 2023-07-04T23:14:08Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPC_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPC_ -timeout 180m
=== RUN   TestAccVPC_basic
=== PAUSE TestAccVPC_basic
=== RUN   TestAccVPC_disappears
=== PAUSE TestAccVPC_disappears
=== RUN   TestAccVPC_tags
=== PAUSE TestAccVPC_tags
=== RUN   TestAccVPC_tags_computed
=== PAUSE TestAccVPC_tags_computed
=== RUN   TestAccVPC_tags_null
=== PAUSE TestAccVPC_tags_null
=== RUN   TestAccVPC_DefaultTags_zeroValue
=== PAUSE TestAccVPC_DefaultTags_zeroValue
=== RUN   TestAccVPC_DefaultTags_providerOnlyTestAccVPC_DefaultTags_providerOnly
=== PAUSE TestAccVPC_DefaultTags_providerOnlyTestAccVPC_DefaultTags_providerOnly
=== RUN   TestAccVPC_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPC_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPC_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPC_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_moveDuplicateTags
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_moveDuplicateTags
=== RUN   TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== RUN   TestAccVPC_DynamicResourceTags_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTags_ignoreChanges
=== RUN   TestAccVPC_defaultAndIgnoreTags
=== PAUSE TestAccVPC_defaultAndIgnoreTags
=== RUN   TestAccVPC_ignoreTags
=== PAUSE TestAccVPC_ignoreTags
=== RUN   TestAccVPC_tenancy
=== PAUSE TestAccVPC_tenancy
=== RUN   TestAccVPC_updateDNSHostnames
=== PAUSE TestAccVPC_updateDNSHostnames
=== RUN   TestAccVPC_bothDNSOptionsSet
=== PAUSE TestAccVPC_bothDNSOptionsSet
=== RUN   TestAccVPC_disabledDNSSupport
=== PAUSE TestAccVPC_disabledDNSSupport
=== RUN   TestAccVPC_enableNetworkAddressUsageMetrics
=== PAUSE TestAccVPC_enableNetworkAddressUsageMetrics
=== RUN   TestAccVPC_assignGeneratedIPv6CIDRBlock
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlock
=== RUN   TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
=== RUN   TestAccVPC_IPAMIPv4BasicNetmask
=== PAUSE TestAccVPC_IPAMIPv4BasicNetmask
=== RUN   TestAccVPC_IPAMIPv4BasicExplicitCIDR
=== PAUSE TestAccVPC_IPAMIPv4BasicExplicitCIDR
=== RUN   TestAccVPC_IPAMIPv6
=== PAUSE TestAccVPC_IPAMIPv6
=== CONT  TestAccVPC_basic
=== CONT  TestAccVPC_DynamicResourceTags_ignoreChanges
--- PASS: TestAccVPC_basic (30.52s)
=== CONT  TestAccVPC_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPC_DynamicResourceTags_ignoreChanges (48.81s)
=== CONT  TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
--- PASS: TestAccVPC_DefaultTags_updateToProviderOnly (46.83s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_moveDuplicateTags
--- PASS: TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges (49.96s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_duplicateTag (21.88s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_moveDuplicateTags (61.41s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_overlappingTag (64.57s)
=== CONT  TestAccVPC_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag (64.70s)
=== CONT  TestAccVPC_tags_null
--- PASS: TestAccVPC_tags_null (25.10s)
=== CONT  TestAccVPC_DefaultTags_providerOnlyTestAccVPC_DefaultTags_providerOnly
--- PASS: TestAccVPC_DefaultTags_updateToResourceOnly (45.90s)
=== CONT  TestAccVPC_DefaultTags_zeroValue
--- PASS: TestAccVPC_DefaultTags_zeroValue (67.90s)
=== CONT  TestAccVPC_enableNetworkAddressUsageMetrics
--- PASS: TestAccVPC_DefaultTags_providerOnlyTestAccVPC_DefaultTags_providerOnly (72.94s)
=== CONT  TestAccVPC_IPAMIPv6
--- PASS: TestAccVPC_enableNetworkAddressUsageMetrics (38.31s)
=== CONT  TestAccVPC_IPAMIPv4BasicExplicitCIDR
--- PASS: TestAccVPC_IPAMIPv4BasicExplicitCIDR (1204.13s)
=== CONT  TestAccVPC_IPAMIPv4BasicNetmask
--- PASS: TestAccVPC_IPAMIPv6 (1154.60s)
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup (82.01s)
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlock
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlock (93.62s)
=== CONT  TestAccVPC_updateDNSHostnames
--- PASS: TestAccVPC_updateDNSHostnames (50.32s)
=== CONT  TestAccVPC_disabledDNSSupport
--- PASS: TestAccVPC_disabledDNSSupport (37.08s)
=== CONT  TestAccVPC_bothDNSOptionsSet
--- PASS: TestAccVPC_bothDNSOptionsSet (37.47s)
=== CONT  TestAccVPC_ignoreTags
--- PASS: TestAccVPC_ignoreTags (47.77s)
=== CONT  TestAccVPC_tenancy
--- PASS: TestAccVPC_tenancy (67.12s)
=== CONT  TestAccVPC_tags
--- PASS: TestAccVPC_IPAMIPv4BasicNetmask (1174.80s)
=== CONT  TestAccVPC_tags_computed
--- PASS: TestAccVPC_tags_computed (26.42s)
=== CONT  TestAccVPC_disappears
--- PASS: TestAccVPC_tags (68.29s)
=== CONT  TestAccVPC_defaultAndIgnoreTags
--- PASS: TestAccVPC_disappears (21.05s)
--- PASS: TestAccVPC_defaultAndIgnoreTags (48.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	2801.447s

% AWS_DEFAULT_REGION=us-east-2 make testacc TESTARGS='-run=TestAccVPCDefaultVPCAndSubnet_serial/VPC' PKG=ec2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCDefaultVPCAndSubnet_serial/VPC -timeout 180m
=== RUN   TestAccVPCDefaultVPCAndSubnet_serial
=== PAUSE TestAccVPCDefaultVPCAndSubnet_serial
=== CONT  TestAccVPCDefaultVPCAndSubnet_serial
=== RUN   TestAccVPCDefaultVPCAndSubnet_serial/VPC
=== RUN   TestAccVPCDefaultVPCAndSubnet_serial/VPC/existing.basic
=== RUN   TestAccVPCDefaultVPCAndSubnet_serial/VPC/existing.assignGeneratedIPv6CIDRBlock
=== RUN   TestAccVPCDefaultVPCAndSubnet_serial/VPC/existing.forceDestroy
=== RUN   TestAccVPCDefaultVPCAndSubnet_serial/VPC/notFound.basic
    vpc_default_vpc_test.go:58: Deleting existing default VPC: vpc-062a5972cceef55b3
=== RUN   TestAccVPCDefaultVPCAndSubnet_serial/VPC/notFound.assignGeneratedIPv6CIDRBlock
    vpc_default_vpc_test.go:58: Deleting existing default VPC: vpc-0c1dc5f4e59ce6de4
=== RUN   TestAccVPCDefaultVPCAndSubnet_serial/VPC/notFound.forceDestroy
    vpc_default_vpc_test.go:58: Deleting existing default VPC: vpc-024d67583507981cc
=== RUN   TestAccVPCDefaultVPCAndSubnet_serial/VPC/notFound.assignGeneratedIPv6CIDRBlockAdoption
    vpc_default_vpc_test.go:58: Deleting existing default VPC: vpc-098382b86532c579c
--- PASS: TestAccVPCDefaultVPCAndSubnet_serial (240.58s)
    --- PASS: TestAccVPCDefaultVPCAndSubnet_serial/VPC (240.58s)
        --- PASS: TestAccVPCDefaultVPCAndSubnet_serial/VPC/existing.basic (18.42s)
        --- PASS: TestAccVPCDefaultVPCAndSubnet_serial/VPC/existing.assignGeneratedIPv6CIDRBlock (29.03s)
        --- PASS: TestAccVPCDefaultVPCAndSubnet_serial/VPC/existing.forceDestroy (42.00s)
        --- PASS: TestAccVPCDefaultVPCAndSubnet_serial/VPC/notFound.basic (20.63s)
        --- PASS: TestAccVPCDefaultVPCAndSubnet_serial/VPC/notFound.assignGeneratedIPv6CIDRBlock (30.78s)
        --- PASS: TestAccVPCDefaultVPCAndSubnet_serial/VPC/notFound.forceDestroy (22.99s)
        --- PASS: TestAccVPCDefaultVPCAndSubnet_serial/VPC/notFound.assignGeneratedIPv6CIDRBlockAdoption (76.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	245.732s

ewbankkit · 2023-07-24T17:41:51Z

@mattburgess Thanks for the contribution 🎉 👏.

github-actions · 2023-07-27T23:00:55Z

This functionality has been released in v5.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-08-27T02:03:16Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jul 6, 2023

mattburgess force-pushed the vpc-sdkv2-migration branch from 9db534b to cbb07d8 Compare July 8, 2023 14:39

mattburgess added 4 commits July 8, 2023 15:56

r/aws_vpc and r/aws_default_vpc use AWS SDKv2

e7b6596

Migrate and fix tests

03ba01f

Add copyright headers

cb95bdf

Fix linting

56d2fd9

mattburgess force-pushed the vpc-sdkv2-migration branch from cbb07d8 to 56d2fd9 Compare July 8, 2023 14:57

mattburgess added 2 commits July 11, 2023 20:58

Fix linting and tag handling

bc42ae1

Fix IPAM allocation retry

fc2ff66

mattburgess marked this pull request as ready for review July 12, 2023 19:41

ewbankkit self-assigned this Jul 24, 2023

ewbankkit added 3 commits July 24, 2023 09:54

Merge branch 'main' into HEAD

e95029f

Some simplifications in EC2 AWS SDK for Go v2 finders.

689094b

Prefer new functions to be package private.

c0c13c1

ewbankkit added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Jul 24, 2023

ewbankkit added 4 commits July 24, 2023 12:19

Add 'service/ec2/exports.go'.

211190f

Fix golangci-lint 'unparam'.

593237d

Fix golangci-lint 'stylecheck'.

22443d0

r/aws_default_vpc: Use 'keyValueTagsV2' and 'getTagsInV2'.

b7ef359

ewbankkit approved these changes Jul 24, 2023

View reviewed changes

ewbankkit merged commit a932c7b into hashicorp:main Jul 24, 2023
39 checks passed

github-actions bot added this to the v5.10.0 milestone Jul 24, 2023

github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023

justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024

justinretzolk added the external-maintainer Contribution from a trusted external contributor. label Jul 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_vpc and r/aws_default_vpc use AWS SDKv2 #32368

r/aws_vpc and r/aws_default_vpc use AWS SDKv2 #32368

mattburgess commented Jul 4, 2023 •

edited

Loading

github-actions bot commented Jul 4, 2023

ewbankkit left a comment

ewbankkit commented Jul 24, 2023

github-actions bot commented Jul 27, 2023

github-actions bot commented Aug 27, 2023

r/aws_vpc and r/aws_default_vpc use AWS SDKv2 #32368

r/aws_vpc and r/aws_default_vpc use AWS SDKv2 #32368

Conversation

mattburgess commented Jul 4, 2023 • edited Loading

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Jul 4, 2023

Community Note

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Jul 24, 2023

github-actions bot commented Jul 27, 2023

github-actions bot commented Aug 27, 2023

mattburgess commented Jul 4, 2023 •

edited

Loading