Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: allow AWS Federated users to be granted permissions #33298

Merged

Conversation

frco9
Copy link
Contributor

@frco9 frco9 commented Sep 4, 2023

Description

In this issue @colonmelvin raise the fact that lake formation permissions did not allowed to use Federated Users ARN.
It seems, @chrisbulgaria forgot to adapt his PR before it got merged to support this.

Thus this small fix will allow to create LF permissions for federated users that logged in using GetFederationToken

Relations

Relates #16848

Output from Acceptance Testing

% make testacc TESTS=TestValidPrincipal PKG=lakeformation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20 -run='TestValidPrincipal'  -timeout 180m
=== RUN   TestValidPrincipal
=== PAUSE TestValidPrincipal
=== CONT  TestValidPrincipal
--- PASS: TestValidPrincipal (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	2.630s

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lakeformation Issues and PRs that pertain to the lakeformation service. labels Sep 4, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 4, 2023
@AdamTylerLynch
Copy link
Collaborator

LGTM 🚀

@AdamTylerLynch AdamTylerLynch removed the needs-triage Waiting for first response or review from a maintainer. label Sep 5, 2023
@theophilechevalier
Copy link
Contributor

theophilechevalier commented Dec 12, 2023

Any chance this gets merged?

@frco9 can you rebase?

@gdavison gdavison force-pushed the b-aws_lakeformation-allow-federated-user branch from d702136 to 0e298af Compare October 11, 2024 20:27
@gdavison gdavison requested a review from a team as a code owner October 11, 2024 20:27
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @frco9 🚀

@gdavison gdavison merged commit 1233990 into hashicorp:main Oct 11, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.72.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/lakeformation Issues and PRs that pertain to the lakeformation service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants