Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teamcity: Performance job #33434

Closed
wants to merge 36 commits into from
Closed

teamcity: Performance job #33434

wants to merge 36 commits into from

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Sep 12, 2023

Description

This PR allowed creation and debugging of the job without constant merging to main. I created a separate TeamCity job pointing to this branch and then could quickly push and update without merging. In the end, I took the results of this PR and created a new PR #33530 intended for merging to main.

Relations

Relates #32289

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/M Managed by automation to categorize the size of a PR. label Sep 12, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 12, 2023
@jar-b
Copy link
Member

jar-b commented Sep 20, 2023

@YakDriver - was this superseded by #33530?

@YakDriver
Copy link
Member Author

@YakDriver - was this superseded by #33530?

Yes!

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. and removed size/M Managed by automation to categorize the size of a PR. labels Sep 20, 2023
@YakDriver YakDriver closed this Sep 20, 2023
@YakDriver YakDriver deleted the f-teamcity-memcpu-prof branch September 20, 2023 18:23
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants