-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_secretsmanager_secret_rotation: support managed secrets #34180
Conversation
Community NoteVoting for Prioritization
For Submitters
|
4c2ea4b
to
ec7bbc1
Compare
This change makes the rotation_lambda_arn argument optional, allowing for use cases where secrets are managed by AWS and do not require a custom lambda function ARN to be specified.
ec7bbc1
to
0a76c42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSecretsManagerSecretRotation_' PKG=secretsmanager ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/secretsmanager/... -v -count 1 -parallel 2 -run=TestAccSecretsManagerSecretRotation_ -timeout 360m
=== RUN TestAccSecretsManagerSecretRotation_basic
=== PAUSE TestAccSecretsManagerSecretRotation_basic
=== RUN TestAccSecretsManagerSecretRotation_scheduleExpression
=== PAUSE TestAccSecretsManagerSecretRotation_scheduleExpression
=== RUN TestAccSecretsManagerSecretRotation_scheduleExpressionHours
=== PAUSE TestAccSecretsManagerSecretRotation_scheduleExpressionHours
=== RUN TestAccSecretsManagerSecretRotation_duration
=== PAUSE TestAccSecretsManagerSecretRotation_duration
=== CONT TestAccSecretsManagerSecretRotation_basic
=== CONT TestAccSecretsManagerSecretRotation_duration
--- PASS: TestAccSecretsManagerSecretRotation_duration (62.68s)
=== CONT TestAccSecretsManagerSecretRotation_scheduleExpressionHours
--- PASS: TestAccSecretsManagerSecretRotation_basic (71.07s)
=== CONT TestAccSecretsManagerSecretRotation_scheduleExpression
--- PASS: TestAccSecretsManagerSecretRotation_scheduleExpressionHours (87.40s)
--- PASS: TestAccSecretsManagerSecretRotation_scheduleExpression (87.63s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager 166.113s
This functionality has been released in v5.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This change makes the
rotation_lambda_arn
argument optional, allowing for use cases where secrets are managed by AWS and do not require a custom lambda function ARN to be specified.Relations
Closes #34108
References
Output from Acceptance Testing