-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds tests for shared config file parsing #34429
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% go test ./internal/provider/... -run=TestSharedConfigFileParsing -v
? github.com/hashicorp/terraform-provider-aws/internal/provider/fwprovider [no test files]
=== RUN TestSharedConfigFileParsing
=== RUN TestSharedConfigFileParsing/named_profile
=== RUN TestSharedConfigFileParsing/trailing_hash
=== RUN TestSharedConfigFileParsing/leading_newline
=== RUN TestSharedConfigFileParsing/leading_whitespace
=== RUN TestSharedConfigFileParsing/leading_newline_and_whitespace
=== RUN TestSharedConfigFileParsing/named_profile_after_leading_newline_and_whitespace
--- PASS: TestSharedConfigFileParsing (0.44s)
--- PASS: TestSharedConfigFileParsing/named_profile (0.08s)
--- PASS: TestSharedConfigFileParsing/trailing_hash (0.07s)
--- PASS: TestSharedConfigFileParsing/leading_newline (0.07s)
--- PASS: TestSharedConfigFileParsing/leading_whitespace (0.07s)
--- PASS: TestSharedConfigFileParsing/leading_newline_and_whitespace (0.07s)
--- PASS: TestSharedConfigFileParsing/named_profile_after_leading_newline_and_whitespace (0.07s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/provider 3.734s
This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Adds tests to validate shared config file parsing
Relations
Relates aws/aws-sdk-go-v2#2369
Output from Acceptance Testing