Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloudwatch Logs log classes argument #34679

Merged
merged 6 commits into from
Dec 1, 2023

Conversation

kylewintaur
Copy link
Contributor

@kylewintaur kylewintaur commented Dec 1, 2023

Description

This PR adds the recently announced Cloudwatch Log Group log classes (STANDARD or INFREQUENT_ACCESS).

Closes: #34570

References

https://aws.amazon.com/blogs/aws/new-amazon-cloudwatch-log-class-for-infrequent-access-logs-at-a-reduced-price
https://github.com/aws/aws-sdk-go/releases/tag/v1.48.4
https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/CloudWatch_Logs_Log_Classes.html

Output from Acceptance Testing

❯ make testacc TESTS=TestAccLogsGroup_logClass PKG=logs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/logs/... -v -count 1 -parallel 20 -run='TestAccLogsGroup_logClass'  -timeout 360m
=== RUN   TestAccLogsGroup_logClass
=== PAUSE TestAccLogsGroup_logClass
=== CONT  TestAccLogsGroup_logClass
--- PASS: TestAccLogsGroup_logClass (20.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	23.631s

Copy link

github-actions bot commented Dec 1, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/logs Issues and PRs that pertain to the logs service. labels Dec 1, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 1, 2023
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 1, 2023
@ewbankkit ewbankkit self-assigned this Dec 1, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLogsGroup_' PKG=logs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/logs/... -v -count 1 -parallel 2  -run=TestAccLogsGroup_ -timeout 360m
=== RUN   TestAccLogsGroup_basic
=== PAUSE TestAccLogsGroup_basic
=== RUN   TestAccLogsGroup_nameGenerate
=== PAUSE TestAccLogsGroup_nameGenerate
=== RUN   TestAccLogsGroup_namePrefix
=== PAUSE TestAccLogsGroup_namePrefix
=== RUN   TestAccLogsGroup_disappears
=== PAUSE TestAccLogsGroup_disappears
=== RUN   TestAccLogsGroup_tags
=== PAUSE TestAccLogsGroup_tags
=== RUN   TestAccLogsGroup_kmsKey
=== PAUSE TestAccLogsGroup_kmsKey
=== RUN   TestAccLogsGroup_logGroupClass
=== PAUSE TestAccLogsGroup_logGroupClass
=== RUN   TestAccLogsGroup_retentionPolicy
=== PAUSE TestAccLogsGroup_retentionPolicy
=== RUN   TestAccLogsGroup_multiple
=== PAUSE TestAccLogsGroup_multiple
=== RUN   TestAccLogsGroup_skipDestroy
=== PAUSE TestAccLogsGroup_skipDestroy
=== CONT  TestAccLogsGroup_basic
=== CONT  TestAccLogsGroup_kmsKey
--- PASS: TestAccLogsGroup_basic (24.90s)
=== CONT  TestAccLogsGroup_multiple
--- PASS: TestAccLogsGroup_multiple (20.81s)
=== CONT  TestAccLogsGroup_skipDestroy
--- PASS: TestAccLogsGroup_skipDestroy (20.23s)
=== CONT  TestAccLogsGroup_disappears
--- PASS: TestAccLogsGroup_kmsKey (66.02s)
=== CONT  TestAccLogsGroup_tags
--- PASS: TestAccLogsGroup_disappears (18.17s)
=== CONT  TestAccLogsGroup_retentionPolicy
--- PASS: TestAccLogsGroup_tags (57.62s)
=== CONT  TestAccLogsGroup_logGroupClass
--- PASS: TestAccLogsGroup_retentionPolicy (57.22s)
=== CONT  TestAccLogsGroup_namePrefix
--- PASS: TestAccLogsGroup_logGroupClass (20.25s)
=== CONT  TestAccLogsGroup_nameGenerate
--- PASS: TestAccLogsGroup_namePrefix (24.28s)
--- PASS: TestAccLogsGroup_nameGenerate (23.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	172.689s

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 1, 2023
@ewbankkit
Copy link
Contributor

@kylewintaur Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 8c993e5 into hashicorp:main Dec 1, 2023
53 checks passed
@github-actions github-actions bot added this to the v5.30.0 milestone Dec 1, 2023
Copy link

github-actions bot commented Dec 7, 2023

This functionality has been released in v5.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jan 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/logs Issues and PRs that pertain to the logs service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New]: Add Log Group Class To Cloudwatch Log Group Module
2 participants