-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_ami: Fixes eventual consistency errors #34691
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9c141cb
Removes unneeded checks from `TestAccEC2AMI_deprecateAt` and `TestAcc…
gdavison fae69a2
Waits for deprecation time to be modified on Create and Update
gdavison 2a6c042
Handles eventual consistency when setting `deprecation_time` and allo…
gdavison 7a914f3
Handles eventual consistency when updating `description`
gdavison 9e0b80e
Adds CHANGELOG entry
gdavison File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
```release-note:bug | ||
resource/aws_ami: Correctly sets `description` on update due to eventual consistency | ||
ewbankkit marked this conversation as resolved.
Show resolved
Hide resolved
|
||
``` | ||
|
||
```release-note:bug | ||
resource/aws_ami: Correctly sets `deprecation_time` on creation and update due to eventual consistency | ||
``` | ||
|
||
```release-note:bug | ||
resource/aws_ami: Now allows removing `deprecation_time` | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to additionally mention
aws_ami_from_instance
andaws_ami_copy
?