Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_imagebuilder_distribution_configuration: Add s3_export_configuration #34917

Closed
wants to merge 4 commits into from
Closed

aws_imagebuilder_distribution_configuration: Add s3_export_configuration #34917

wants to merge 4 commits into from

Conversation

Szasza
Copy link
Contributor

@Szasza Szasza commented Dec 13, 2023

Description

Add s3_export_configuration to both the aws_imagebuilder_distribution_configuration data source and resource.

Relations

Closes #34870

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccImageBuilderDistributionConfigurationDataSource_\|TestAccImageBuilderDistributionConfiguration_DistributionS3Export_' PKG=imagebuilder ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 3  -run=TestAccImageBuilderDistributionConfigurationDataSource_\|TestAccImageBuilderDistributionConfiguration_DistributionS3Export_ -timeout 360m
=== RUN   TestAccImageBuilderDistributionConfigurationDataSource_arn
=== PAUSE TestAccImageBuilderDistributionConfigurationDataSource_arn
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionS3Export_diskImageFormatRaw
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionS3Export_diskImageFormatRaw
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionS3Export_diskImageFormatVhd
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionS3Export_diskImageFormatVhd
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionS3Export_diskImageFormatVmdk
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionS3Export_diskImageFormatVmdk
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionS3Export_roleName
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionS3Export_roleName
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionS3Export_s3Bucket
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionS3Export_s3Bucket
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionS3Export_s3Prefix
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionS3Export_s3Prefix
=== CONT  TestAccImageBuilderDistributionConfigurationDataSource_arn
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionS3Export_roleName
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionS3Export_s3Prefix
--- PASS: TestAccImageBuilderDistributionConfigurationDataSource_arn (37.61s)
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionS3Export_s3Bucket
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionS3Export_roleName (66.27s)
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionS3Export_diskImageFormatVhd
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionS3Export_s3Prefix (68.32s)
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionS3Export_diskImageFormatVmdk
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionS3Export_s3Bucket (70.54s)
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionS3Export_diskImageFormatRaw
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionS3Export_diskImageFormatVhd (60.83s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionS3Export_diskImageFormatVmdk (59.67s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionS3Export_diskImageFormatRaw (63.24s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder       171.481s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. labels Dec 13, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 13, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 18, 2023
@Szasza Szasza closed this Jan 26, 2024
@Szasza Szasza deleted the f-aws_imagebuilder_distribution_configuration.s3_export_configuration branch January 26, 2024 00:06
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add S3 Export Configuration to Image Builder distribution configuration
2 participants