r/aws_quicksight_dashboard: Fix error reading state with Table visuals

[sean-nixon]

Description

This fixes a bug where the aws_quicksight_dashboard resource would fail on refreshing/reading the state with certain configurations of Table visuals due to a typo.

Error: setting definition: Invalid address to set: []string{"definition", "0", "sheets", "5", "visuals", "2", "table_visual", "0", "chart_configuration", "0", "field_options", "0", "selected_field_options", "2", "visbility"}

Relations

Closes #33463

References

Output from Acceptance Testing

% make testacc TESTS=TestAccQuickSightDashboard PKG=quicksight
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightDashboard'  -timeout 360m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]
=== RUN   TestAccQuickSightDashboard_basic
=== PAUSE TestAccQuickSightDashboard_basic
=== RUN   TestAccQuickSightDashboard_disappears
=== PAUSE TestAccQuickSightDashboard_disappears
=== RUN   TestAccQuickSightDashboard_sourceEntity
=== PAUSE TestAccQuickSightDashboard_sourceEntity
=== RUN   TestAccQuickSightDashboard_updateVersionNumber
=== PAUSE TestAccQuickSightDashboard_updateVersionNumber
=== RUN   TestAccQuickSightDashboard_dashboardSpecificConfig
=== PAUSE TestAccQuickSightDashboard_dashboardSpecificConfig
=== CONT  TestAccQuickSightDashboard_basic
=== CONT  TestAccQuickSightDashboard_updateVersionNumber
=== CONT  TestAccQuickSightDashboard_sourceEntity
=== CONT  TestAccQuickSightDashboard_disappears
=== CONT  TestAccQuickSightDashboard_dashboardSpecificConfig
--- PASS: TestAccQuickSightDashboard_disappears (52.92s)
--- PASS: TestAccQuickSightDashboard_dashboardSpecificConfig (57.75s)
--- PASS: TestAccQuickSightDashboard_basic (58.20s)
--- PASS: TestAccQuickSightDashboard_sourceEntity (59.45s)
--- PASS: TestAccQuickSightDashboard_updateVersionNumber (101.51s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 104.880s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @sean-nixon 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[marc-outins]

This bug is also affecting me as well and the fix seems simple and obvious. Is there a reason the PR has been open for so long without being merged?

[ClaudiuDmtr]

I'm receiving the same error when trying to generate a configuration file for a dashboard using terraform plan generate-config-out functionality.

[johnsonaj]

@sean-nixon thank you for the contribution! 🎉

It looks like this fix was released in v5.43.0, with PR #34227, along with some other changes. I will close this as a duplicate.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.