Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for additional owner value #35286

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Adding support for additional owner value #35286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b403dc
Adding support for additional owner value
Jan 12, 2024
d548776
Merge branch 'main' into HEAD
ewbankkit Jan 25, 2024
1d6d6d1
Add CHANGELOG entry.
ewbankkit Jan 25, 2024
96bfd1c
Use 'imagebuilder.Ownership_Values()' instead of hard-coded strings.
ewbankkit Jan 25, 2024
cb61e08
d/aws_imagebuilder_container_recipes: Document new value for 'owner'.
ewbankkit Jan 25, 2024
bfafe7f
d/aws_imagebuilder_image_recipes: Add support for `ThirdParty` `owner…
ewbankkit Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changelog/35286.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
```release-note:enhancement
data-source/aws_imagebuilder_components: Add support for `ThirdParty` `owner` value
```

```release-note:enhancement
data-source/aws_imagebuilder_container_recipes: Add support for `ThirdParty` `owner` value
```

```release-note:enhancement
data-source/aws_imagebuilder_image_recipes: Add support for `ThirdParty` `owner` value
```
4 changes: 2 additions & 2 deletions internal/service/imagebuilder/components_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
"github.com/hashicorp/terraform-provider-aws/internal/generate/namevaluesfilters"
)

// @SDKDataSource("aws_imagebuilder_components")
// @SDKDataSource("aws_imagebuilder_components", name="Components")
func DataSourceComponents() *schema.Resource {
return &schema.Resource{
ReadWithoutTimeout: dataSourceComponentsRead,
Expand All @@ -35,7 +35,7 @@ func DataSourceComponents() *schema.Resource {
"owner": {
Type: schema.TypeString,
Optional: true,
ValidateFunc: validation.StringInSlice([]string{"Self", "Shared", "Amazon"}, false),
ValidateFunc: validation.StringInSlice(imagebuilder.Ownership_Values(), false),
},
},
}
Expand Down
4 changes: 2 additions & 2 deletions internal/service/imagebuilder/container_recipes_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
"github.com/hashicorp/terraform-provider-aws/internal/generate/namevaluesfilters"
)

// @SDKDataSource("aws_imagebuilder_container_recipes")
// @SDKDataSource("aws_imagebuilder_container_recipes", name="Container Recipes")
func DataSourceContainerRecipes() *schema.Resource {
return &schema.Resource{
ReadWithoutTimeout: dataSourceContainerRecipesRead,
Expand All @@ -35,7 +35,7 @@ func DataSourceContainerRecipes() *schema.Resource {
"owner": {
Type: schema.TypeString,
Optional: true,
ValidateFunc: validation.StringInSlice([]string{"Self", "Shared", "Amazon"}, false),
ValidateFunc: validation.StringInSlice(imagebuilder.Ownership_Values(), false),
},
},
}
Expand Down
4 changes: 2 additions & 2 deletions internal/service/imagebuilder/image_recipes_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
"github.com/hashicorp/terraform-provider-aws/internal/generate/namevaluesfilters"
)

// @SDKDataSource("aws_imagebuilder_image_recipes")
// @SDKDataSource("aws_imagebuilder_image_recipes", name="Image Recipes")
func DataSourceImageRecipes() *schema.Resource {
return &schema.Resource{
ReadWithoutTimeout: dataSourceImageRecipesRead,
Expand All @@ -35,7 +35,7 @@ func DataSourceImageRecipes() *schema.Resource {
"owner": {
Type: schema.TypeString,
Optional: true,
ValidateFunc: validation.StringInSlice([]string{"Self", "Shared", "Amazon"}, false),
ValidateFunc: validation.StringInSlice(imagebuilder.Ownership_Values(), false),
},
},
}
Expand Down
3 changes: 3 additions & 0 deletions internal/service/imagebuilder/service_package_gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion website/docs/cdktf/python/d/imagebuilder_components.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class MyConvertedCode(TerraformStack):

## Argument Reference

* `owner` - (Optional) Owner of the image recipes. Valid values are `Self`, `Shared` and `Amazon`. Defaults to `Self`.
* `owner` - (Optional) Owner of the image recipes. Valid values are `Self`, `Shared`, `Amazon` and `ThirdParty`. Defaults to `Self`.
* `filter` - (Optional) Configuration block(s) for filtering. Detailed below.

### filter Configuration Block
Expand Down
2 changes: 1 addition & 1 deletion website/docs/cdktf/python/d/imagebuilder_image_recipes.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class MyConvertedCode(TerraformStack):

## Argument Reference

* `owner` - (Optional) Owner of the image recipes. Valid values are `Self`, `Shared` and `Amazon`. Defaults to `Self`.
* `owner` - (Optional) Owner of the image recipes. Valid values are `Self`, `Shared`, `Amazon` and `ThirdParty`. Defaults to `Self`.
* `filter` - (Optional) Configuration block(s) for filtering. Detailed below.

### filter Configuration Block
Expand Down
2 changes: 1 addition & 1 deletion website/docs/cdktf/typescript/d/imagebuilder_components.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class MyConvertedCode extends TerraformStack {

## Argument Reference

* `owner` - (Optional) Owner of the image recipes. Valid values are `Self`, `Shared` and `Amazon`. Defaults to `Self`.
* `owner` - (Optional) Owner of the image recipes. Valid values are `Self`, `Shared`, `Amazon` and `ThirdParty`. Defaults to `Self`.
* `filter` - (Optional) Configuration block(s) for filtering. Detailed below.

### filter Configuration Block
Expand Down
2 changes: 1 addition & 1 deletion website/docs/cdktf/typescript/d/imagebuilder_image_recipes.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class MyConvertedCode extends TerraformStack {

## Argument Reference

* `owner` - (Optional) Owner of the image recipes. Valid values are `Self`, `Shared` and `Amazon`. Defaults to `Self`.
* `owner` - (Optional) Owner of the image recipes. Valid values are `Self`, `Shared`, `Amazon` and `ThirdParty`. Defaults to `Self`.
* `filter` - (Optional) Configuration block(s) for filtering. Detailed below.

### filter Configuration Block
Expand Down
2 changes: 1 addition & 1 deletion website/docs/d/imagebuilder_components.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ data "aws_imagebuilder_components" "example" {

## Argument Reference

* `owner` - (Optional) Owner of the image recipes. Valid values are `Self`, `Shared` and `Amazon`. Defaults to `Self`.
* `owner` - (Optional) Owner of the image recipes. Valid values are `Self`, `Shared`, `Amazon` and `ThirdParty`. Defaults to `Self`.
* `filter` - (Optional) Configuration block(s) for filtering. Detailed below.

### filter Configuration Block
Expand Down
2 changes: 1 addition & 1 deletion website/docs/d/imagebuilder_container_recipes.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ data "aws_imagebuilder_container_recipes" "example" {

## Argument Reference

* `owner` - (Optional) Owner of the container recipes. Valid values are `Self`, `Shared` and `Amazon`. Defaults to `Self`.
* `owner` - (Optional) Owner of the container recipes. Valid values are `Self`, `Shared`, `Amazon` and `ThirdParty`. Defaults to `Self`.
* `filter` - (Optional) Configuration block(s) for filtering. Detailed below.

### filter Configuration Block
Expand Down
2 changes: 1 addition & 1 deletion website/docs/d/imagebuilder_image_recipes.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ data "aws_imagebuilder_image_recipes" "example" {

## Argument Reference

* `owner` - (Optional) Owner of the image recipes. Valid values are `Self`, `Shared` and `Amazon`. Defaults to `Self`.
* `owner` - (Optional) Owner of the image recipes. Valid values are `Self`, `Shared`, `Amazon` and `ThirdParty`. Defaults to `Self`.
* `filter` - (Optional) Configuration block(s) for filtering. Detailed below.

### filter Configuration Block
Expand Down
Loading