Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginated ListTags APIs #35723

Merged
merged 6 commits into from
Feb 8, 2024
Merged

Paginated ListTags APIs #35723

merged 6 commits into from
Feb 8, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Feb 8, 2024

Description

Generate calls to paginated ListTags APIs where appropriate.

Relations

Closes #33154.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccACMPCACertificateAuthority_tags' PKG=acmpca
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/acmpca/... -v -count 1 -parallel 20  -run=TestAccACMPCACertificateAuthority_tags -timeout 360m
=== RUN   TestAccACMPCACertificateAuthority_tags
=== PAUSE TestAccACMPCACertificateAuthority_tags
=== CONT  TestAccACMPCACertificateAuthority_tags
--- PASS: TestAccACMPCACertificateAuthority_tags (43.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acmpca	54.378s
% make testacc TESTARGS='-run=TestAccAutoScalingGroup_tags' PKG=autoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 20  -run=TestAccAutoScalingGroup_tags -timeout 360m
=== RUN   TestAccAutoScalingGroup_tags
=== PAUSE TestAccAutoScalingGroup_tags
=== CONT  TestAccAutoScalingGroup_tags
--- PASS: TestAccAutoScalingGroup_tags (122.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	140.077s
% make testacc TESTARGS='-run=TestAccBackupPlan_withTags' PKG=backup
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/backup/... -v -count 1 -parallel 20  -run=TestAccBackupPlan_withTags -timeout 360m
=== RUN   TestAccBackupPlan_withTags
=== PAUSE TestAccBackupPlan_withTags
=== CONT  TestAccBackupPlan_withTags
--- PASS: TestAccBackupPlan_withTags (46.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	58.753s
% make testacc TESTARGS='-run=TestAccCloudHSMV2_serial/Cluster/tags' PKG=cloudhsmv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudhsmv2/... -v -count 1 -parallel 20  -run=TestAccCloudHSMV2_serial/Cluster/tags -timeout 360m
=== RUN   TestAccCloudHSMV2_serial
=== PAUSE TestAccCloudHSMV2_serial
=== CONT  TestAccCloudHSMV2_serial
=== RUN   TestAccCloudHSMV2_serial/Cluster
=== RUN   TestAccCloudHSMV2_serial/Cluster/tags
--- PASS: TestAccCloudHSMV2_serial (230.34s)
    --- PASS: TestAccCloudHSMV2_serial/Cluster (230.34s)
        --- PASS: TestAccCloudHSMV2_serial/Cluster/tags (230.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudhsmv2	243.418s
% make testacc TESTARGS='-run=TestAccCloudTrail_serial/Trail/tags' PKG=cloudtrail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudtrail/... -v -count 1 -parallel 20  -run=TestAccCloudTrail_serial/Trail/tags -timeout 360m
=== RUN   TestAccCloudTrail_serial
=== PAUSE TestAccCloudTrail_serial
=== CONT  TestAccCloudTrail_serial
=== RUN   TestAccCloudTrail_serial/Trail
=== RUN   TestAccCloudTrail_serial/Trail/tags
--- PASS: TestAccCloudTrail_serial (63.63s)
    --- PASS: TestAccCloudTrail_serial/Trail (63.63s)
        --- PASS: TestAccCloudTrail_serial/Trail/tags (63.63s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail	75.758s
% make testacc TESTARGS='-run=TestAccVPC_tags$$\|TestAccVPCSubnet_tags$$' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPC_tags$\|TestAccVPCSubnet_tags$ -timeout 360m
=== RUN   TestAccVPCSubnet_tags
=== PAUSE TestAccVPCSubnet_tags
=== RUN   TestAccVPC_tags
=== PAUSE TestAccVPC_tags
=== CONT  TestAccVPCSubnet_tags
=== CONT  TestAccVPC_tags
--- PASS: TestAccVPC_tags (57.66s)
--- PASS: TestAccVPCSubnet_tags (69.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	82.049s
% make testacc TESTARGS='-run=TestAccEFSFileSystem_tags' PKG=efs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 20  -run=TestAccEFSFileSystem_tags -timeout 360m
=== RUN   TestAccEFSFileSystem_tags
=== PAUSE TestAccEFSFileSystem_tags
=== CONT  TestAccEFSFileSystem_tags
--- PASS: TestAccEFSFileSystem_tags (76.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/efs	88.727s
% make testacc TESTARGS='-run=TestAccSageMakerModel_tags' PKG=sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20  -run=TestAccSageMakerModel_tags -timeout 360m
=== RUN   TestAccSageMakerModel_tags
=== PAUSE TestAccSageMakerModel_tags
=== CONT  TestAccSageMakerModel_tags
--- PASS: TestAccSageMakerModel_tags (59.50s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	71.554s

Copy link

github-actions bot commented Feb 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/redshift Issues and PRs that pertain to the redshift service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/sagemaker Issues and PRs that pertain to the sagemaker service. service/efs Issues and PRs that pertain to the efs service. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. service/acmpca Issues and PRs that pertain to the acmpca service. service/backup Issues and PRs that pertain to the backup service. tags Pertains to resource tagging. generators Relates to code generators. labels Feb 8, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 8, 2024
@ewbankkit ewbankkit changed the title [WIP] Paginated ListTags APIs Paginated ListTags APIs Feb 8, 2024
@github-actions github-actions bot removed the service/redshift Issues and PRs that pertain to the redshift service. label Feb 8, 2024
@ewbankkit ewbankkit added service/redshift Issues and PRs that pertain to the redshift service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Feb 8, 2024
@ewbankkit ewbankkit merged commit 68c62f4 into main Feb 8, 2024
55 checks passed
@ewbankkit ewbankkit deleted the td-paginated-listtags branch February 8, 2024 21:41
@github-actions github-actions bot removed the service/redshift Issues and PRs that pertain to the redshift service. label Feb 8, 2024
@github-actions github-actions bot added this to the v5.36.0 milestone Feb 8, 2024
github-actions bot pushed a commit that referenced this pull request Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

This functionality has been released in v5.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/acmpca Issues and PRs that pertain to the acmpca service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/backup Issues and PRs that pertain to the backup service. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/efs Issues and PRs that pertain to the efs service. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/L Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate calls to paginated ListTags APIs
1 participant