[WIP] Fix 3511 support all elbv2 attributes #3578
Conversation
- add enable_cross_zone_load_balancing - add enable_http2 - refactor updateFunc to group lbType specific attributes
radeksimko
added
enhancement
|
FYI cross-zone load balancing is being implemented in #3537 |
|
Dang, well it was a good exercise, I'll change it to just add support for http2 (which is on by default and I don't know that is is any advantage to turning it off.. but at least it will close off covering all the attributes). |
|
I will wait for the mentioned PR to be merged and rebase from there, there is a small piece of refactoring I still think is a good idea |
|
@appilon I have a commit ready with your refactor and adding http2 with tests. Once my PR is merged I will rebase the commit. Thinking about the refactor, it might be a good idea now but if AWS adds more LB types and rules apply to certain combinations it might get unruly, but it can just be refactored again when it gets to that. |
- refactored to use a switch statement a la hashicorp#3578 - added enable_http2 as a flag with tests - made the boolean flag tests have 3 steps: on, off, on. to test creation, removal and enabling of a running LB - increased timeout and delay for aws_internet_gateway detachment refresh - increased wait time to wait for network interfaces to be destroyed after deleting an NLB (this, combined with the above, caused the EIP hanging resource I saw yesterday) - made all test fixtures use lb_test as the name for the aws_lb (to prevent the typo issue I had)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
First PR, implement missing load balancer attributes for elbv2, small refactor to better group lbtype specific attributes.