-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_devopsguru_service_integration: new resource #36694
Conversation
Community NoteVoting for Prioritization
For Submitters
|
This resource will allow practitioners to manage AWS DevOps Guru service integration settings with Terraform. ```console % make testacc PKG=devopsguru TESTS=TestAccDevOpsGuru_serial/ServiceIntegration/ ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/devopsguru/... -v -count 1 -parallel 20 -run='TestAccDevOpsGuru_serial/ServiceIntegration/' -timeout 360m --- PASS: TestAccDevOpsGuru_serial (39.21s) --- PASS: TestAccDevOpsGuru_serial/ServiceIntegration (39.21s) --- PASS: TestAccDevOpsGuru_serial/ServiceIntegration/basic (19.21s) --- PASS: TestAccDevOpsGuru_serial/ServiceIntegration/kms (20.00s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/devopsguru 44.690s ```
0cae692
to
ce16c13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker, but the acceptance tests for the whole service should ensure that the partition supports the service. GovCloud tests, for example, fail with
dial tcp: lookup devops-guru.us-gov-west-1.amazonaws.com: no such host
In Commercial partition
--- PASS: TestAccDevOpsGuru_serial (31.50s)
--- PASS: TestAccDevOpsGuru_serial/ServiceIntegration (31.50s)
--- PASS: TestAccDevOpsGuru_serial/ServiceIntegration/kms (16.54s)
--- PASS: TestAccDevOpsGuru_serial/ServiceIntegration/basic (14.96s)
This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This resource will allow practitioners to manage AWS DevOps Guru service integration settings with Terraform.
This resource is the last planned item for the DevOps Guru service implementation, and therefore will close the parent meta issue as well.
Relations
Closes #17919
Closes #36335
References
Output from Acceptance Testing