Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource: aws_eip_domain_name #36963

Merged
merged 25 commits into from
Apr 18, 2024
Merged

New resource: aws_eip_domain_name #36963

merged 25 commits into from
Apr 18, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Apr 17, 2024 •
edited
Loading

Description

Adds the aws_eip_domain_name resource to assign a static reverse DNS record to an Elastic IP addresses. See Using reverse DNS for email applications.

Relations

Closes #20876.

Output from Acceptance Testing

% ACM_CERTIFICATE_ROOT_DOMAIN=terraform-provider-aws-acctest-acm.com make testacc TESTARGS='-run=TestAccEC2EIPDomainName_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccEC2EIPDomainName_ -timeout 360m
=== RUN   TestAccEC2EIPDomainName_basic
=== PAUSE TestAccEC2EIPDomainName_basic
=== RUN   TestAccEC2EIPDomainName_disappears
=== PAUSE TestAccEC2EIPDomainName_disappears
=== RUN   TestAccEC2EIPDomainName_update
=== PAUSE TestAccEC2EIPDomainName_update
=== CONT  TestAccEC2EIPDomainName_basic
=== CONT  TestAccEC2EIPDomainName_update        
--- PASS: TestAccEC2EIPDomainName_basic (382.95s)
=== CONT  TestAccEC2EIPDomainName_disappears
--- PASS: TestAccEC2EIPDomainName_update (468.81s)
--- PASS: TestAccEC2EIPDomainName_disappears (321.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	657.225s
% make testacc TESTARGS='-run=TestAccVPCDefaultVPCDHCPOptions_serial\|TestAccEC2EIPAssociation_\|TestAccEC2EIPDataSource_\|TestAccEC2EIP_\|TestAccEC2EIPsDataSource_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCDefaultVPCDHCPOptions_serial\|TestAccEC2EIPAssociation_\|TestAccEC2EIPDataSource_\|TestAccEC2EIP_\|TestAccEC2EIPsDataSource_ -timeout 360m
=== RUN   TestAccEC2EIPAssociation_basic
=== PAUSE TestAccEC2EIPAssociation_basic
=== RUN   TestAccEC2EIPAssociation_disappears
=== PAUSE TestAccEC2EIPAssociation_disappears
=== RUN   TestAccEC2EIPAssociation_instance
=== PAUSE TestAccEC2EIPAssociation_instance
=== RUN   TestAccEC2EIPAssociation_networkInterface
=== PAUSE TestAccEC2EIPAssociation_networkInterface
=== RUN   TestAccEC2EIPAssociation_spotInstance
=== PAUSE TestAccEC2EIPAssociation_spotInstance
=== RUN   TestAccEC2EIPDataSource_filter
=== PAUSE TestAccEC2EIPDataSource_filter
=== RUN   TestAccEC2EIPDataSource_id
=== PAUSE TestAccEC2EIPDataSource_id
=== RUN   TestAccEC2EIPDataSource_publicIP
=== PAUSE TestAccEC2EIPDataSource_publicIP
=== RUN   TestAccEC2EIPDataSource_tags
=== PAUSE TestAccEC2EIPDataSource_tags
=== RUN   TestAccEC2EIPDataSource_networkInterface
=== PAUSE TestAccEC2EIPDataSource_networkInterface
=== RUN   TestAccEC2EIPDataSource_instance
=== PAUSE TestAccEC2EIPDataSource_instance
=== RUN   TestAccEC2EIPDataSource_carrierIP
=== PAUSE TestAccEC2EIPDataSource_carrierIP
=== RUN   TestAccEC2EIPDataSource_customerOwnedIPv4Pool
=== PAUSE TestAccEC2EIPDataSource_customerOwnedIPv4Pool
=== RUN   TestAccEC2EIP_basic
=== PAUSE TestAccEC2EIP_basic
=== RUN   TestAccEC2EIP_disappears
=== PAUSE TestAccEC2EIP_disappears
=== RUN   TestAccEC2EIP_migrateVPCToDomain
=== PAUSE TestAccEC2EIP_migrateVPCToDomain
=== RUN   TestAccEC2EIP_noVPC
=== PAUSE TestAccEC2EIP_noVPC
=== RUN   TestAccEC2EIP_tags
=== PAUSE TestAccEC2EIP_tags
=== RUN   TestAccEC2EIP_instance
=== PAUSE TestAccEC2EIP_instance
=== RUN   TestAccEC2EIP_Instance_reassociate
=== PAUSE TestAccEC2EIP_Instance_reassociate
=== RUN   TestAccEC2EIP_Instance_associatedUserPrivateIP
=== PAUSE TestAccEC2EIP_Instance_associatedUserPrivateIP
=== RUN   TestAccEC2EIP_Instance_notAssociated
=== PAUSE TestAccEC2EIP_Instance_notAssociated
=== RUN   TestAccEC2EIP_networkInterface
=== PAUSE TestAccEC2EIP_networkInterface
=== RUN   TestAccEC2EIP_NetworkInterface_twoEIPsOneInterface
=== PAUSE TestAccEC2EIP_NetworkInterface_twoEIPsOneInterface
=== RUN   TestAccEC2EIP_association
=== PAUSE TestAccEC2EIP_association
=== RUN   TestAccEC2EIP_PublicIPv4Pool_default
=== PAUSE TestAccEC2EIP_PublicIPv4Pool_default
=== RUN   TestAccEC2EIP_PublicIPv4Pool_custom
    ec2_eip_test.go:475: Environment variable AWS_EC2_EIP_PUBLIC_IPV4_POOL is not set
--- SKIP: TestAccEC2EIP_PublicIPv4Pool_custom (0.00s)
=== RUN   TestAccEC2EIP_customerOwnedIPv4Pool
=== PAUSE TestAccEC2EIP_customerOwnedIPv4Pool
=== RUN   TestAccEC2EIP_networkBorderGroup
=== PAUSE TestAccEC2EIP_networkBorderGroup
=== RUN   TestAccEC2EIP_carrierIP
=== PAUSE TestAccEC2EIP_carrierIP
=== RUN   TestAccEC2EIP_BYOIPAddress_default
=== PAUSE TestAccEC2EIP_BYOIPAddress_default
=== RUN   TestAccEC2EIP_BYOIPAddress_custom
    ec2_eip_test.go:622: Environment variable AWS_EC2_EIP_BYOIP_ADDRESS is not set
--- SKIP: TestAccEC2EIP_BYOIPAddress_custom (0.00s)
=== RUN   TestAccEC2EIP_BYOIPAddress_customWithPublicIPv4Pool
    ec2_eip_test.go:651: Environment variable AWS_EC2_EIP_BYOIP_ADDRESS is not set
--- SKIP: TestAccEC2EIP_BYOIPAddress_customWithPublicIPv4Pool (0.00s)
=== RUN   TestAccEC2EIPsDataSource_basic
=== PAUSE TestAccEC2EIPsDataSource_basic
=== RUN   TestAccVPCDefaultVPCDHCPOptions_serial
=== PAUSE TestAccVPCDefaultVPCDHCPOptions_serial
=== CONT  TestAccEC2EIPAssociation_basic
=== CONT  TestAccEC2EIP_noVPC
=== CONT  TestAccEC2EIP_association
--- PASS: TestAccEC2EIP_noVPC (24.01s)
=== CONT  TestAccEC2EIPDataSource_tags
--- PASS: TestAccEC2EIPDataSource_tags (18.23s)
=== CONT  TestAccEC2EIP_migrateVPCToDomain
--- PASS: TestAccEC2EIP_migrateVPCToDomain (60.32s)
=== CONT  TestAccEC2EIP_disappears
--- PASS: TestAccEC2EIP_disappears (18.57s)
=== CONT  TestAccEC2EIP_basic
--- PASS: TestAccEC2EIPAssociation_basic (137.48s)
=== CONT  TestAccEC2EIPDataSource_customerOwnedIPv4Pool
    ec2_eip_data_source_test.go:186: skipping since no Outposts found
--- SKIP: TestAccEC2EIPDataSource_customerOwnedIPv4Pool (0.38s)
=== CONT  TestAccEC2EIPDataSource_carrierIP
--- PASS: TestAccEC2EIP_basic (22.47s)
=== CONT  TestAccEC2EIPDataSource_instance
--- PASS: TestAccEC2EIPDataSource_carrierIP (20.63s)
=== CONT  TestAccEC2EIPDataSource_networkInterface
--- PASS: TestAccEC2EIP_association (180.44s)
=== CONT  TestAccEC2EIPAssociation_spotInstance
--- PASS: TestAccEC2EIPDataSource_networkInterface (29.70s)
=== CONT  TestAccEC2EIPDataSource_publicIP
--- PASS: TestAccEC2EIPDataSource_publicIP (18.43s)
=== CONT  TestAccEC2EIPDataSource_id
--- PASS: TestAccEC2EIPDataSource_id (18.25s)
=== CONT  TestAccEC2EIPDataSource_filter
--- PASS: TestAccEC2EIPDataSource_instance (81.52s)
=== CONT  TestAccEC2EIP_carrierIP
--- PASS: TestAccEC2EIPDataSource_filter (20.07s)
=== CONT  TestAccVPCDefaultVPCDHCPOptions_serial
=== RUN   TestAccVPCDefaultVPCDHCPOptions_serial/v4.20.0_regression
--- PASS: TestAccEC2EIP_carrierIP (25.11s)
=== CONT  TestAccEC2EIPsDataSource_basic
--- PASS: TestAccEC2EIPsDataSource_basic (19.30s)
=== CONT  TestAccEC2EIP_BYOIPAddress_default
--- PASS: TestAccEC2EIP_BYOIPAddress_default (18.53s)
=== CONT  TestAccEC2EIP_Instance_associatedUserPrivateIP
--- PASS: TestAccEC2EIPAssociation_spotInstance (113.28s)
=== CONT  TestAccEC2EIP_NetworkInterface_twoEIPsOneInterface
=== RUN   TestAccVPCDefaultVPCDHCPOptions_serial/basic
=== RUN   TestAccVPCDefaultVPCDHCPOptions_serial/owner
--- PASS: TestAccEC2EIP_NetworkInterface_twoEIPsOneInterface (30.84s)
=== CONT  TestAccEC2EIP_networkInterface
--- PASS: TestAccVPCDefaultVPCDHCPOptions_serial (83.27s)
    --- PASS: TestAccVPCDefaultVPCDHCPOptions_serial/v4.20.0_regression (49.92s)
    --- PASS: TestAccVPCDefaultVPCDHCPOptions_serial/basic (16.60s)
    --- PASS: TestAccVPCDefaultVPCDHCPOptions_serial/owner (16.76s)
=== CONT  TestAccEC2EIP_Instance_notAssociated
--- PASS: TestAccEC2EIP_networkInterface (32.79s)
=== CONT  TestAccEC2EIP_instance
--- PASS: TestAccEC2EIP_instance (135.98s)
=== CONT  TestAccEC2EIP_Instance_reassociate
--- PASS: TestAccEC2EIP_Instance_associatedUserPrivateIP (214.69s)
=== CONT  TestAccEC2EIP_tags
--- PASS: TestAccEC2EIP_Instance_notAssociated (185.00s)
=== CONT  TestAccEC2EIP_customerOwnedIPv4Pool
    ec2_eip_test.go:512: skipping since no Outposts found
--- SKIP: TestAccEC2EIP_customerOwnedIPv4Pool (0.36s)
=== CONT  TestAccEC2EIP_networkBorderGroup
--- PASS: TestAccEC2EIP_networkBorderGroup (23.70s)
=== CONT  TestAccEC2EIPAssociation_networkInterface
--- PASS: TestAccEC2EIP_tags (53.11s)
=== CONT  TestAccEC2EIP_PublicIPv4Pool_default
--- PASS: TestAccEC2EIPAssociation_networkInterface (42.91s)
=== CONT  TestAccEC2EIPAssociation_instance
--- PASS: TestAccEC2EIP_PublicIPv4Pool_default (38.78s)
=== CONT  TestAccEC2EIPAssociation_disappears
--- PASS: TestAccEC2EIP_Instance_reassociate (128.89s)
--- PASS: TestAccEC2EIPAssociation_instance (143.30s)
--- PASS: TestAccEC2EIPAssociation_disappears (139.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	746.502s

@ewbankkit
r/aws_eip_association: Reduce visibility.
a7fad01
@ewbankkit
r/aws_eip: Reduce visibility.
4c4d126
@ewbankkit
d/aws_eips: Reduce visibility.
a327668
@ewbankkit
d/aws_eip: Reduce visibility.
e735c8b
@ewbankkit
d/aws_eips: Migrate to AWS SDK for Go v2.
c4e674a
@ewbankkit
d/aws_eip: Migrate to AWS SDK for Go v2.
fe563a1
@ewbankkit
r/aws_eip_association: Migrate to AWS SDK for Go v2.
c923a93
@ewbankkit
r/aws_eip: Migrate to AWS SDK for Go v2.
f344e94
@ewbankkit
Move 'RegionalPublicDNSSuffix'.
46679e3
@ewbankkit
Add 'EC2PrivateDNSNameForIP' and 'EC2PublicDNSNameForIP' to 'AWSClient'.
c888012
@ewbankkit
Use 'AWSClient.EC2RegionalPrivateDNSSuffix'.
92946df
@ewbankkit
Use 'AWSClient.EC2PrivateDNSNameForIP' and 'AWSClient.EC2PublicDNSNam…
d72663b 
…eForIP'.
@ewbankkit
Acceptance test output:
39dec48 
% make testacc TESTARGS='-run=TestAccVPCDefaultVPCDHCPOptions_serial\|TestAccEC2EIPAssociation_\|TestAccEC2EIPDataSource_\|TestAccEC2EIP_\|TestAccEC2EIPsDataSource_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCDefaultVPCDHCPOptions_serial\|TestAccEC2EIPAssociation_\|TestAccEC2EIPDataSource_\|TestAccEC2EIP_\|TestAccEC2EIPsDataSource_ -timeout 360m
=== RUN   TestAccEC2EIPAssociation_basic
=== PAUSE TestAccEC2EIPAssociation_basic
=== RUN   TestAccEC2EIPAssociation_disappears
=== PAUSE TestAccEC2EIPAssociation_disappears
=== RUN   TestAccEC2EIPAssociation_instance
=== PAUSE TestAccEC2EIPAssociation_instance
=== RUN   TestAccEC2EIPAssociation_networkInterface
=== PAUSE TestAccEC2EIPAssociation_networkInterface
=== RUN   TestAccEC2EIPAssociation_spotInstance
=== PAUSE TestAccEC2EIPAssociation_spotInstance
=== RUN   TestAccEC2EIPDataSource_filter
=== PAUSE TestAccEC2EIPDataSource_filter
=== RUN   TestAccEC2EIPDataSource_id
=== PAUSE TestAccEC2EIPDataSource_id
=== RUN   TestAccEC2EIPDataSource_publicIP
=== PAUSE TestAccEC2EIPDataSource_publicIP
=== RUN   TestAccEC2EIPDataSource_tags
=== PAUSE TestAccEC2EIPDataSource_tags
=== RUN   TestAccEC2EIPDataSource_networkInterface
=== PAUSE TestAccEC2EIPDataSource_networkInterface
=== RUN   TestAccEC2EIPDataSource_instance
=== PAUSE TestAccEC2EIPDataSource_instance
=== RUN   TestAccEC2EIPDataSource_carrierIP
=== PAUSE TestAccEC2EIPDataSource_carrierIP
=== RUN   TestAccEC2EIPDataSource_customerOwnedIPv4Pool
=== PAUSE TestAccEC2EIPDataSource_customerOwnedIPv4Pool
=== RUN   TestAccEC2EIP_basic
=== PAUSE TestAccEC2EIP_basic
=== RUN   TestAccEC2EIP_disappears
=== PAUSE TestAccEC2EIP_disappears
=== RUN   TestAccEC2EIP_migrateVPCToDomain
=== PAUSE TestAccEC2EIP_migrateVPCToDomain
=== RUN   TestAccEC2EIP_noVPC
=== PAUSE TestAccEC2EIP_noVPC
=== RUN   TestAccEC2EIP_tags
=== PAUSE TestAccEC2EIP_tags
=== RUN   TestAccEC2EIP_instance
=== PAUSE TestAccEC2EIP_instance
=== RUN   TestAccEC2EIP_Instance_reassociate
=== PAUSE TestAccEC2EIP_Instance_reassociate
=== RUN   TestAccEC2EIP_Instance_associatedUserPrivateIP
=== PAUSE TestAccEC2EIP_Instance_associatedUserPrivateIP
=== RUN   TestAccEC2EIP_Instance_notAssociated
=== PAUSE TestAccEC2EIP_Instance_notAssociated
=== RUN   TestAccEC2EIP_networkInterface
=== PAUSE TestAccEC2EIP_networkInterface
=== RUN   TestAccEC2EIP_NetworkInterface_twoEIPsOneInterface
=== PAUSE TestAccEC2EIP_NetworkInterface_twoEIPsOneInterface
=== RUN   TestAccEC2EIP_association
=== PAUSE TestAccEC2EIP_association
=== RUN   TestAccEC2EIP_PublicIPv4Pool_default
=== PAUSE TestAccEC2EIP_PublicIPv4Pool_default
=== RUN   TestAccEC2EIP_PublicIPv4Pool_custom
    ec2_eip_test.go:474: Environment variable AWS_EC2_EIP_PUBLIC_IPV4_POOL is not set
--- SKIP: TestAccEC2EIP_PublicIPv4Pool_custom (0.00s)
=== RUN   TestAccEC2EIP_customerOwnedIPv4Pool
=== PAUSE TestAccEC2EIP_customerOwnedIPv4Pool
=== RUN   TestAccEC2EIP_networkBorderGroup
=== PAUSE TestAccEC2EIP_networkBorderGroup
=== RUN   TestAccEC2EIP_carrierIP
=== PAUSE TestAccEC2EIP_carrierIP
=== RUN   TestAccEC2EIP_BYOIPAddress_default
=== PAUSE TestAccEC2EIP_BYOIPAddress_default
=== RUN   TestAccEC2EIP_BYOIPAddress_custom
    ec2_eip_test.go:621: Environment variable AWS_EC2_EIP_BYOIP_ADDRESS is not set
--- SKIP: TestAccEC2EIP_BYOIPAddress_custom (0.00s)
=== RUN   TestAccEC2EIP_BYOIPAddress_customWithPublicIPv4Pool
    ec2_eip_test.go:650: Environment variable AWS_EC2_EIP_BYOIP_ADDRESS is not set
--- SKIP: TestAccEC2EIP_BYOIPAddress_customWithPublicIPv4Pool (0.00s)
=== RUN   TestAccEC2EIPsDataSource_basic
=== PAUSE TestAccEC2EIPsDataSource_basic
=== RUN   TestAccVPCDefaultVPCDHCPOptions_serial
=== PAUSE TestAccVPCDefaultVPCDHCPOptions_serial
=== CONT  TestAccEC2EIPAssociation_basic
=== CONT  TestAccEC2EIP_noVPC
=== CONT  TestAccVPCDefaultVPCDHCPOptions_serial
=== RUN   TestAccVPCDefaultVPCDHCPOptions_serial/v4.20.0_regression
--- PASS: TestAccEC2EIP_noVPC (21.88s)
=== CONT  TestAccEC2EIPsDataSource_basic
--- PASS: TestAccEC2EIPsDataSource_basic (17.62s)
=== CONT  TestAccEC2EIP_BYOIPAddress_default
=== RUN   TestAccVPCDefaultVPCDHCPOptions_serial/basic
--- PASS: TestAccEC2EIP_BYOIPAddress_default (17.53s)
=== CONT  TestAccEC2EIP_carrierIP
=== RUN   TestAccVPCDefaultVPCDHCPOptions_serial/owner
--- PASS: TestAccEC2EIP_carrierIP (24.36s)
=== CONT  TestAccEC2EIP_networkBorderGroup
--- PASS: TestAccVPCDefaultVPCDHCPOptions_serial (84.35s)
    --- PASS: TestAccVPCDefaultVPCDHCPOptions_serial/v4.20.0_regression (51.16s)
    --- PASS: TestAccVPCDefaultVPCDHCPOptions_serial/basic (17.21s)
    --- PASS: TestAccVPCDefaultVPCDHCPOptions_serial/owner (15.98s)
=== CONT  TestAccEC2EIP_customerOwnedIPv4Pool
    ec2_eip_test.go:511: skipping since no Outposts found
--- SKIP: TestAccEC2EIP_customerOwnedIPv4Pool (0.44s)
=== CONT  TestAccEC2EIP_PublicIPv4Pool_default
--- PASS: TestAccEC2EIP_networkBorderGroup (21.83s)
=== CONT  TestAccEC2EIP_association
--- PASS: TestAccEC2EIP_PublicIPv4Pool_default (21.58s)
=== CONT  TestAccEC2EIP_NetworkInterface_twoEIPsOneInterface
--- PASS: TestAccEC2EIP_NetworkInterface_twoEIPsOneInterface (27.81s)
=== CONT  TestAccEC2EIP_networkInterface
--- PASS: TestAccEC2EIPAssociation_basic (148.26s)
=== CONT  TestAccEC2EIP_Instance_notAssociated
--- PASS: TestAccEC2EIP_networkInterface (31.03s)
=== CONT  TestAccEC2EIP_Instance_associatedUserPrivateIP
--- PASS: TestAccEC2EIP_association (175.77s)
=== CONT  TestAccEC2EIP_Instance_reassociate
--- PASS: TestAccEC2EIP_Instance_notAssociated (177.38s)
=== CONT  TestAccEC2EIP_instance
--- PASS: TestAccEC2EIP_Instance_associatedUserPrivateIP (190.10s)
=== CONT  TestAccEC2EIP_tags
--- PASS: TestAccEC2EIP_tags (45.63s)
=== CONT  TestAccEC2EIPDataSource_tags
--- PASS: TestAccEC2EIP_Instance_reassociate (136.43s)
=== CONT  TestAccEC2EIP_migrateVPCToDomain
--- PASS: TestAccEC2EIPDataSource_tags (17.50s)
=== CONT  TestAccEC2EIP_disappears
--- PASS: TestAccEC2EIP_disappears (18.54s)
=== CONT  TestAccEC2EIP_basic
--- PASS: TestAccEC2EIP_instance (131.28s)
=== CONT  TestAccEC2EIPDataSource_customerOwnedIPv4Pool
    ec2_eip_data_source_test.go:186: skipping since no Outposts found
--- SKIP: TestAccEC2EIPDataSource_customerOwnedIPv4Pool (0.37s)
=== CONT  TestAccEC2EIPDataSource_carrierIP
--- PASS: TestAccEC2EIP_basic (21.71s)
=== CONT  TestAccEC2EIPDataSource_instance
--- PASS: TestAccEC2EIPDataSource_carrierIP (20.76s)
=== CONT  TestAccEC2EIPDataSource_networkInterface
--- PASS: TestAccEC2EIP_migrateVPCToDomain (63.88s)
=== CONT  TestAccEC2EIPAssociation_spotInstance
--- PASS: TestAccEC2EIPDataSource_networkInterface (27.59s)
=== CONT  TestAccEC2EIPDataSource_publicIP
--- PASS: TestAccEC2EIPDataSource_publicIP (19.00s)
=== CONT  TestAccEC2EIPDataSource_id
--- PASS: TestAccEC2EIPDataSource_id (17.72s)
=== CONT  TestAccEC2EIPDataSource_filter
--- PASS: TestAccEC2EIPDataSource_filter (16.74s)
=== CONT  TestAccEC2EIPAssociation_instance
--- PASS: TestAccEC2EIPDataSource_instance (117.54s)
=== CONT  TestAccEC2EIPAssociation_networkInterface
--- PASS: TestAccEC2EIPAssociation_networkInterface (30.17s)
=== CONT  TestAccEC2EIPAssociation_disappears
--- PASS: TestAccEC2EIPAssociation_spotInstance (134.16s)
--- PASS: TestAccEC2EIPAssociation_instance (116.03s)
--- PASS: TestAccEC2EIPAssociation_disappears (83.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	701.826s
@ewbankkit
aws_eip: Add 'domain_name' attribute.
9ca4c77
@ewbankkit
d/aws_eip: 'domain_name' -> 'ptr_record'.
7ebe305
@ewbankkit
r/aws_eip_domain_name: New resource.
7f7bc55
@ewbankkit
r/aws_eip_domain_name: Add documentation.
7a68411
@ewbankkit
Correct CHANGELOG entry.
886637d
@ewbankkit
r/aws_eip: Add 'ptr_record' attribute.
0b66cb3
@ewbankkit
r/aws_eip_domain_name: Add first acceptance test.
719fafa
@ewbankkit
r/aws_eip_domain_name: Additional acceptance tests.
74d489d
@ewbankkit
r/aws_eip_domain_name: Add sweeper.
bb19ebe
@ewbankkit
Fix 'TestAccEC2EIPDomainName_update'.
e8a9bd2
@ewbankkit
r/aws_eip_domain_name: Fix error handling on Delete.
77a0b85
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. and removed size/XL Managed by automation to categorize the size of a PR. labels Apr 17, 2024
@github-actions github-actions bot added service/fsx Issues and PRs that pertain to the fsx service. sweeper Pertains to changes to or issues with the sweeper. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) service/vpc Issues and PRs that pertain to the vpc service. labels Apr 17, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 17, 2024
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Apr 17, 2024
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Apr 17, 2024
@ewbankkit ewbankkit changed the title [WIP] New resource: aws_eip_domain_name New resource: aws_eip_domain_name Apr 17, 2024
jar-b
jar-b approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jar-b
Copy link
Member

jar-b commented Apr 18, 2024

Nice start on migrating EC2 to AWS SDK V2! 👍

@ewbankkit ewbankkit merged commit a187beb into main Apr 18, 2024
81 checks passed
@ewbankkit ewbankkit deleted the f-aws_eip.ptr_record branch April 18, 2024 14:41
@github-actions github-actions bot added this to the v5.46.0 milestone Apr 18, 2024
github-actions bot pushed a commit that referenced this pull request Apr 18, 2024
Update CHANGELOG.md for #36963
9ca1c99
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 19, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/ec2 Issues and PRs that pertain to the ec2 service. service/fsx Issues and PRs that pertain to the fsx service. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Projects
None yet
Milestone
v5.46.0
Development

Successfully merging this pull request may close these issues.

Support for EIP reverse DNS configuration (EIP attributes)
2 participants
@ewbankkit @jar-b