-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoflex: json interface #37085
autoflex: json interface #37085
Conversation
Community NoteVoting for Prioritization
For Submitters
|
% go test -count=1 ./internal/framework/flex/... -run=TestFlatten -v
--- PASS: TestFlattenFrameworkStringListLegacy (0.00s)
--- PASS: TestFlattenFrameworkStringListLegacy/two_elements (0.00s)
--- PASS: TestFlattenFrameworkStringListLegacy/zero_elements (0.00s)
--- PASS: TestFlattenFrameworkStringListLegacy/nil_array (0.00s)
--- PASS: TestFlattenFrameworkStringValueMapLegacy (0.00s)
--- PASS: TestFlattenFrameworkStringValueMapLegacy/two_elements (0.00s)
--- PASS: TestFlattenFrameworkStringValueMapLegacy/zero_elements (0.00s)
--- PASS: TestFlattenFrameworkStringValueMapLegacy/nil_map (0.00s)
--- PASS: TestFlattenFrameworkStringList (0.00s)
--- PASS: TestFlattenFrameworkStringList/nil_array (0.00s)
--- PASS: TestFlattenFrameworkStringList/zero_elements (0.00s)
--- PASS: TestFlattenFrameworkStringList/two_elements (0.00s)
--- PASS: TestFlattenFrameworkStringValueList (0.00s)
--- PASS: TestFlattenFrameworkStringValueList/nil_array (0.00s)
--- PASS: TestFlattenFrameworkStringValueList/zero_elements (0.00s)
--- PASS: TestFlattenFrameworkStringValueList/two_elements (0.00s)
--- PASS: TestFlattenFrameworkStringValueMap (0.00s)
--- PASS: TestFlattenFrameworkStringValueMap/nil_map (0.00s)
--- PASS: TestFlattenFrameworkStringValueMap/zero_elements (0.00s)
--- PASS: TestFlattenFrameworkStringValueMap/two_elements (0.00s)
--- PASS: TestFlattenSimpleNestedBlockWithStringEnum (0.00s)
--- PASS: TestFlattenSimpleNestedBlockWithStringEnum/single_nested_empty_value (0.00s)
--- PASS: TestFlattenSimpleNestedBlockWithStringEnum/single_nested_valid_value (0.00s)
--- PASS: TestFlattenFrameworkStringValueListLegacy (0.00s)
--- PASS: TestFlattenFrameworkStringValueListLegacy/two_elements (0.00s)
--- PASS: TestFlattenFrameworkStringValueListLegacy/nil_array (0.00s)
--- PASS: TestFlattenFrameworkStringValueListLegacy/zero_elements (0.00s)
--- PASS: TestFlattenFrameworkStringValueSetLegacy (0.00s)
--- PASS: TestFlattenFrameworkStringValueSetLegacy/nil_array (0.00s)
--- PASS: TestFlattenFrameworkStringValueSetLegacy/two_elements (0.00s)
--- PASS: TestFlattenFrameworkStringValueSetLegacy/zero_elements (0.00s)
--- PASS: TestFlattenFrameworkStringValueSet (0.00s)
--- PASS: TestFlattenFrameworkStringValueSet/zero_elements (0.00s)
--- PASS: TestFlattenFrameworkStringValueSet/two_elements (0.00s)
--- PASS: TestFlattenFrameworkStringValueSet/nil_array (0.00s)
--- PASS: TestFlattenComplexSingleNestedBlock (0.00s)
--- PASS: TestFlattenComplexSingleNestedBlock/single_nested_block_pointer (0.00s)
--- PASS: TestFlattenFrameworkStringMap (0.00s)
--- PASS: TestFlattenFrameworkStringMap/nil_map (0.00s)
--- PASS: TestFlattenFrameworkStringMap/zero_elements (0.00s)
--- PASS: TestFlattenFrameworkStringMap/two_elements (0.00s)
--- PASS: TestFlattenComplexNestedBlockWithStringEnum (0.00s)
--- PASS: TestFlattenComplexNestedBlockWithStringEnum/single_nested_valid_value (0.00s)
--- PASS: TestFlattenComplexNestedBlockWithStringEnum/single_nested_zero_value (0.00s)
--- PASS: TestFlattenComplexNestedBlockWithStringEnum/single_nested_empty_value (0.00s)
--- PASS: TestFlattenSimpleSingleNestedBlock (0.00s)
--- PASS: TestFlattenSimpleSingleNestedBlock/single_nested_block_value (0.00s)
--- PASS: TestFlattenSimpleSingleNestedBlock/single_nested_block_pointer (0.00s)
--- PASS: TestFlattenSimpleSingleNestedBlock/single_nested_block_nil (0.00s)
--- PASS: TestFlattenGeneric (0.00s)
--- PASS: TestFlattenGeneric/map_block_key_ptr_source (0.00s)
--- PASS: TestFlattenGeneric/map_block_key_ptr_both (0.00s)
--- PASS: TestFlattenGeneric/map_string (0.00s)
--- PASS: TestFlattenGeneric/map_block_enum_key (0.00s)
--- PASS: TestFlattenGeneric/nested_string_map (0.00s)
--- PASS: TestFlattenGeneric/non-empty_[]*struct_and_non-empty_set_Target (0.00s)
--- PASS: TestFlattenGeneric/non-empty_[]*struct_and_non-empty_list_Target (0.00s)
--- PASS: TestFlattenGeneric/empty_[]*struct_and_empty_set_Target (0.00s)
--- PASS: TestFlattenGeneric/nil_[]*struct_and_null_set_Target (0.00s)
--- PASS: TestFlattenGeneric/map_block_key_set (0.00s)
--- PASS: TestFlattenGeneric/nil_[]*struct_and_null_list_Target (0.00s)
--- PASS: TestFlattenGeneric/empty_[]*struct_and_empty_list_Target (0.00s)
--- PASS: TestFlattenGeneric/nil_*struct_Source_and_single_list_Target (0.00s)
--- PASS: TestFlattenGeneric/nil_[]struct_and_null_set_Target (0.00s)
--- PASS: TestFlattenGeneric/empty_[]struct_and_empty_struct_Target (0.00s)
--- PASS: TestFlattenGeneric/empty_[]struct_and_empty_list_Target (0.00s)
--- PASS: TestFlattenGeneric/nil_[]struct_and_null_list_Target (0.00s)
--- PASS: TestFlattenGeneric/non-empty_[]struct_and_non-empty_list_Target (0.00s)
--- PASS: TestFlattenGeneric/*struct_Source_and_single_set_Target (0.00s)
--- PASS: TestFlattenGeneric/*struct_Source_and_single_list_Target (0.00s)
--- PASS: TestFlattenGeneric/non-empty_[]struct_and_non-empty_set_Target (0.00s)
--- PASS: TestFlattenGeneric/complex_Source_and_complex_Target (0.00s)
--- PASS: TestFlattenGeneric/map_block_key_list (0.00s)
--- PASS: TestFlatten (0.00s)
--- PASS: TestFlatten/nil_Source_and_Target (0.00s)
--- PASS: TestFlatten/non-struct_Target (0.00s)
--- PASS: TestFlatten/non-pointer_Target (0.00s)
--- PASS: TestFlatten/non-struct_Source (0.00s)
--- PASS: TestFlatten/single_*string_Source_and_single_string_Target (0.00s)
--- PASS: TestFlatten/empty_struct_pointer_Source_and_Target (0.00s)
--- PASS: TestFlatten/single_empty_string_Source_and_single_string_Target (0.00s)
--- PASS: TestFlatten/empty_struct_Source_and_Target (0.00s)
--- PASS: TestFlatten/slice/map_of_primtive_types_Source_and_List/Set/Map_of_primtive_types_Target (0.00s)
--- PASS: TestFlatten/zero_value_slice/map_of_primtive_types_Source_and_List/Set/Map_of_primtive_types_Target (0.00s)
--- PASS: TestFlatten/capitalization_field_names (0.00s)
--- PASS: TestFlatten/single_string_Source_and_single_int64_Target (0.00s)
--- PASS: TestFlatten/does_not_implement_attr.Value_Target (0.00s)
--- PASS: TestFlatten/resource_name_prefix (0.00s)
--- PASS: TestFlatten/strange_plurality (0.00s)
--- PASS: TestFlatten/json_interface_Source_string_Target (0.00s)
--- PASS: TestFlatten/zero_value_slice/map_of_string_type_Source_and_List/Set/Map_of_string_types_Target (0.00s)
--- PASS: TestFlatten/single_nil_*string_Source_and_single_string_Target (0.00s)
--- PASS: TestFlatten/single_nil_*string_Source_and_single_ARN_Target (0.00s)
--- PASS: TestFlatten/zero_value_primtive_types_Source_and_primtive_types_Target (0.00s)
--- PASS: TestFlatten/primtive_types_Source_and_primtive_types_Target (0.00s)
--- PASS: TestFlatten/single_*string_Source_and_single_ARN_Target (0.00s)
--- PASS: TestFlatten/timestamp (0.00s)
--- PASS: TestFlatten/timestamp_pointer (0.00s)
--- PASS: TestFlatten/single_string_Source_and_single_string_Target (0.00s)
--- PASS: TestFlatten/single_string_Source_and_single_ARN_Target (0.00s)
--- PASS: TestFlatten/plural_ordinary_field_names (0.00s)
--- PASS: TestFlatten/single_string_struct_pointer_Source_and_empty_Target (0.00s)
--- PASS: TestFlatten/timestamp_empty (0.00s)
--- PASS: TestFlatten/slice/map_of_string_types_Source_and_List/Set/Map_of_string_types_Target (0.00s)
--- PASS: TestFlatten/timestamp_nil (0.00s)
--- PASS: TestFlatten/plural_field_names (0.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/framework/flex 0.451s |
There also some Smithy document stuff in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
@ewbankkit thanks. I was looking for a good location to place the interface type. Could possibly move it there. Also need to think about how |
Co-authored-by: Jared Baker <jar-b@users.noreply.github.com>
remove comment Co-authored-by: Jared Baker <jar-b@users.noreply.github.com>
This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Auto flex understands AWS interface types that convert JSON
document.Interface
contains the following:Relations
Relates #36508
References
Output from Acceptance Testing