Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty retry_strategy of Batch JobDefinition causing panics #37500

Merged
merged 9 commits into from
Aug 7, 2024
Merged

Fix empty retry_strategy of Batch JobDefinition causing panics #37500

merged 9 commits into from
Aug 7, 2024

Commits on May 14, 2024

  1. Fix empty retry_strategy of Batch JobDefinition causing panics 

    Computing whether a Batch JobDefinition has a diff panics if the `retry_strategy` is empty.
This is a valid configuration because all properties of `retry_strategy` are optional.

This patch fixes that by adding the missing nil checks for the retry strategy.

Fixes hashicorp#37349
    @flostadler
    flostadler committed May 14, 2024
    Configuration menu
    Copy the full SHA
    0fd2c8e View commit details
    Browse the repository at this point in the history

  2. formatting

    @flostadler
    flostadler committed May 14, 2024
    Configuration menu
    Copy the full SHA
    895cf82 View commit details
    Browse the repository at this point in the history

  3. Update changelog

    @flostadler
    flostadler committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b525fdd View commit details
    Browse the repository at this point in the history

  4. Add acceptance test

    @flostadler
    flostadler committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b0d5847 View commit details
    Browse the repository at this point in the history

  5. Remove changes to changelog

    @flostadler
    flostadler committed May 14, 2024
    Configuration menu
    Copy the full SHA
    e64d4a3 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Merge branch 'main' into batch-empty-retry_strategy-panic

    @jar-b
    jar-b committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    4a0ffdd View commit details
    Browse the repository at this point in the history

  2. chore: changelog

    @jar-b
    jar-b committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ebf8801 View commit details
    Browse the repository at this point in the history

  3. chore: make testacc-lint-fix

    @jar-b
    jar-b committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    83984d5 View commit details
    Browse the repository at this point in the history

  4. chore: apply changelog updates to appropriate PR number

    @jar-b
    jar-b committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    07623e9 View commit details
    Browse the repository at this point in the history