Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs: Migrate to AWS SDK v2 #38016

Merged
merged 63 commits into from
Jul 18, 2024
Merged

Commits on Jun 17, 2024

  1. Configuration menu
    Copy the full SHA
    334286c View commit details
    Browse the repository at this point in the history
  2. Run make gen

    mattburgess committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    a91da09 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1d7af07 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c5bbf42 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e53d516 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1b3457b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0d4a4a2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    67804c9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5f12a37 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ec8eb53 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    cb7a2ff View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    e3233fe View commit details
    Browse the repository at this point in the history
  13. Fix lint

    mattburgess committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    f152335 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge branch 'main' into HEAD

    # Conflicts:
    #	internal/conns/awsclient_gen.go
    #	internal/service/ecs/cluster.go
    #	internal/service/ecs/find.go
    #	internal/service/ecs/service_data_source.go
    #	internal/service/ecs/service_package_gen.go
    #	names/names.go
    ewbankkit committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    00a919d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fa7cf55 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Configuration menu
    Copy the full SHA
    b9a8294 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4bbfea2 View commit details
    Browse the repository at this point in the history
  3. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccECSAccountSettingDefault_serial' PKG=ecs
    make: Verifying source code with gofmt...
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.22.5 test ./internal/service/ecs/... -v -count 1 -parallel 20  -run=TestAccECSAccountSettingDefault_serial -timeout 360m
    === RUN   TestAccECSAccountSettingDefault_serial
    === PAUSE TestAccECSAccountSettingDefault_serial
    === CONT  TestAccECSAccountSettingDefault_serial
    === RUN   TestAccECSAccountSettingDefault_serial/taskLongARNFormat
    === RUN   TestAccECSAccountSettingDefault_serial/vpcTrunking
    === RUN   TestAccECSAccountSettingDefault_serial/containerInsights
    === RUN   TestAccECSAccountSettingDefault_serial/fargateTaskRetirementWaitPeriod
    === RUN   TestAccECSAccountSettingDefault_serial/containerInstanceLongARNFormat
    === RUN   TestAccECSAccountSettingDefault_serial/serviceLongARNFormat
    --- PASS: TestAccECSAccountSettingDefault_serial (66.39s)
        --- PASS: TestAccECSAccountSettingDefault_serial/taskLongARNFormat (11.69s)
        --- PASS: TestAccECSAccountSettingDefault_serial/vpcTrunking (11.02s)
        --- PASS: TestAccECSAccountSettingDefault_serial/containerInsights (11.09s)
        --- PASS: TestAccECSAccountSettingDefault_serial/fargateTaskRetirementWaitPeriod (10.78s)
        --- PASS: TestAccECSAccountSettingDefault_serial/containerInstanceLongARNFormat (10.86s)
        --- PASS: TestAccECSAccountSettingDefault_serial/serviceLongARNFormat (10.96s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	71.221s
    ewbankkit committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e09bd20 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    252baa7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6f47839 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    00a7ca6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    77c976c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    35a3734 View commit details
    Browse the repository at this point in the history
  9. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccDynamoDBTableItem_' PKG=dynamodb ACCTEST_PARALLELISM=3
    make: Verifying source code with gofmt...
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.22.5 test ./internal/service/dynamodb/... -v -count 1 -parallel 3  -run=TestAccDynamoDBTableItem_ -timeout 360m
    === RUN   TestAccDynamoDBTableItem_basic
    === PAUSE TestAccDynamoDBTableItem_basic
    === RUN   TestAccDynamoDBTableItem_rangeKey
    === PAUSE TestAccDynamoDBTableItem_rangeKey
    === RUN   TestAccDynamoDBTableItem_withMultipleItems
    === PAUSE TestAccDynamoDBTableItem_withMultipleItems
    === RUN   TestAccDynamoDBTableItem_withDuplicateItemsSameRangeKey
    === PAUSE TestAccDynamoDBTableItem_withDuplicateItemsSameRangeKey
    === RUN   TestAccDynamoDBTableItem_withDuplicateItemsDifferentRangeKey
    === PAUSE TestAccDynamoDBTableItem_withDuplicateItemsDifferentRangeKey
    === RUN   TestAccDynamoDBTableItem_wonkyItems
    === PAUSE TestAccDynamoDBTableItem_wonkyItems
    === RUN   TestAccDynamoDBTableItem_update
    === PAUSE TestAccDynamoDBTableItem_update
    === RUN   TestAccDynamoDBTableItem_updateWithRangeKey
    === PAUSE TestAccDynamoDBTableItem_updateWithRangeKey
    === RUN   TestAccDynamoDBTableItem_disappears
    === PAUSE TestAccDynamoDBTableItem_disappears
    === RUN   TestAccDynamoDBTableItem_mapOutOfBandUpdate
    === PAUSE TestAccDynamoDBTableItem_mapOutOfBandUpdate
    === CONT  TestAccDynamoDBTableItem_basic
    === CONT  TestAccDynamoDBTableItem_wonkyItems
    === CONT  TestAccDynamoDBTableItem_disappears
    --- PASS: TestAccDynamoDBTableItem_disappears (25.87s)
    === CONT  TestAccDynamoDBTableItem_mapOutOfBandUpdate
    --- PASS: TestAccDynamoDBTableItem_basic (26.99s)
    === CONT  TestAccDynamoDBTableItem_withDuplicateItemsSameRangeKey
    --- PASS: TestAccDynamoDBTableItem_wonkyItems (27.11s)
    === CONT  TestAccDynamoDBTableItem_withDuplicateItemsDifferentRangeKey
    --- PASS: TestAccDynamoDBTableItem_withDuplicateItemsSameRangeKey (17.05s)
    === CONT  TestAccDynamoDBTableItem_withMultipleItems
    --- PASS: TestAccDynamoDBTableItem_withDuplicateItemsDifferentRangeKey (19.25s)
    === CONT  TestAccDynamoDBTableItem_updateWithRangeKey
    --- PASS: TestAccDynamoDBTableItem_mapOutOfBandUpdate (25.45s)
    === CONT  TestAccDynamoDBTableItem_update
    --- PASS: TestAccDynamoDBTableItem_withMultipleItems (19.54s)
    === CONT  TestAccDynamoDBTableItem_rangeKey
    --- PASS: TestAccDynamoDBTableItem_updateWithRangeKey (22.90s)
    --- PASS: TestAccDynamoDBTableItem_update (26.09s)
    --- PASS: TestAccDynamoDBTableItem_rangeKey (17.48s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	86.206s
    ewbankkit committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e3444e3 View commit details
    Browse the repository at this point in the history
  10. Add 'json.DecodeFromBytes'.

    ewbankkit committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ed4e16f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b811e73 View commit details
    Browse the repository at this point in the history
  12. Some tweaks.

    ewbankkit committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    5b63982 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    bb0e0a5 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    1165b8f View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    2ce7f18 View commit details
    Browse the repository at this point in the history
  16. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccDMSCertificate_' PKG=dms ACCTEST_PARALLELISM=3
    make: Verifying source code with gofmt...
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.22.5 test ./internal/service/dms/... -v -count 1 -parallel 3  -run=TestAccDMSCertificate_ -timeout 360m
    === RUN   TestAccDMSCertificate_basic
    === PAUSE TestAccDMSCertificate_basic
    === RUN   TestAccDMSCertificate_disappears
    === PAUSE TestAccDMSCertificate_disappears
    === RUN   TestAccDMSCertificate_certificateWallet
    === PAUSE TestAccDMSCertificate_certificateWallet
    === RUN   TestAccDMSCertificate_tags
    === PAUSE TestAccDMSCertificate_tags
    === CONT  TestAccDMSCertificate_basic
    === CONT  TestAccDMSCertificate_certificateWallet
    === CONT  TestAccDMSCertificate_disappears
    --- PASS: TestAccDMSCertificate_disappears (9.99s)
    === CONT  TestAccDMSCertificate_tags
    --- PASS: TestAccDMSCertificate_certificateWallet (12.22s)
    --- PASS: TestAccDMSCertificate_basic (12.22s)
    --- PASS: TestAccDMSCertificate_tags (24.57s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	39.517s
    ewbankkit committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    db22363 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    c02be8c View commit details
    Browse the repository at this point in the history
  18. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccAppRunnerConnection_' PKG=apprunner ACCTEST_PARALLELISM=3
    make: Verifying source code with gofmt...
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.22.5 test ./internal/service/apprunner/... -v -count 1 -parallel 3  -run=TestAccAppRunnerConnection_ -timeout 360m
    === RUN   TestAccAppRunnerConnection_basic
    === PAUSE TestAccAppRunnerConnection_basic
    === RUN   TestAccAppRunnerConnection_disappears
    === PAUSE TestAccAppRunnerConnection_disappears
    === RUN   TestAccAppRunnerConnection_tags
    === PAUSE TestAccAppRunnerConnection_tags
    === CONT  TestAccAppRunnerConnection_basic
    === CONT  TestAccAppRunnerConnection_tags
    === CONT  TestAccAppRunnerConnection_disappears
    --- PASS: TestAccAppRunnerConnection_disappears (10.54s)
    --- PASS: TestAccAppRunnerConnection_basic (12.55s)
    --- PASS: TestAccAppRunnerConnection_tags (25.59s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	30.617s
    ewbankkit committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    b7e160e View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Configuration menu
    Copy the full SHA
    5b993e0 View commit details
    Browse the repository at this point in the history
  2. r/aws_appstream_image_builder: 'AppStream-WinServer2022-03-24-2024' -…

    …> 'AppStream-WinServer2022-06-17-2024' in acceptance test configurations.
    ewbankkit committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e7bf251 View commit details
    Browse the repository at this point in the history
  3. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccAppStreamUser_\|TestAccAppStreamImageBuilder_' PKG=appstream ACCTEST_PARALLELISM=3
    make: Verifying source code with gofmt...
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.22.5 test ./internal/service/appstream/... -v -count 1 -parallel 3  -run=TestAccAppStreamUser_\|TestAccAppStreamImageBuilder_ -timeout 360m
    === RUN   TestAccAppStreamImageBuilder_basic
    === PAUSE TestAccAppStreamImageBuilder_basic
    === RUN   TestAccAppStreamImageBuilder_withIAMRole
    === PAUSE TestAccAppStreamImageBuilder_withIAMRole
    === RUN   TestAccAppStreamImageBuilder_disappears
    === PAUSE TestAccAppStreamImageBuilder_disappears
    === RUN   TestAccAppStreamImageBuilder_complete
    === PAUSE TestAccAppStreamImageBuilder_complete
    === RUN   TestAccAppStreamImageBuilder_tags
    === PAUSE TestAccAppStreamImageBuilder_tags
    === RUN   TestAccAppStreamImageBuilder_imageARN
    === PAUSE TestAccAppStreamImageBuilder_imageARN
    === RUN   TestAccAppStreamUser_basic
    === PAUSE TestAccAppStreamUser_basic
    === RUN   TestAccAppStreamUser_disappears
    === PAUSE TestAccAppStreamUser_disappears
    === RUN   TestAccAppStreamUser_complete
    === PAUSE TestAccAppStreamUser_complete
    === CONT  TestAccAppStreamImageBuilder_basic
    === CONT  TestAccAppStreamImageBuilder_imageARN
    === CONT  TestAccAppStreamImageBuilder_complete
    --- PASS: TestAccAppStreamImageBuilder_basic (578.90s)
    === CONT  TestAccAppStreamImageBuilder_tags
    --- PASS: TestAccAppStreamImageBuilder_imageARN (578.99s)
    === CONT  TestAccAppStreamImageBuilder_disappears
    --- PASS: TestAccAppStreamImageBuilder_complete (1106.53s)
    === CONT  TestAccAppStreamUser_disappears
    --- PASS: TestAccAppStreamImageBuilder_disappears (536.62s)
    === CONT  TestAccAppStreamUser_complete
    --- PASS: TestAccAppStreamUser_disappears (16.96s)
    === CONT  TestAccAppStreamImageBuilder_withIAMRole
    --- PASS: TestAccAppStreamImageBuilder_tags (560.80s)
    === CONT  TestAccAppStreamUser_basic
    --- PASS: TestAccAppStreamUser_basic (25.15s)
    --- PASS: TestAccAppStreamUser_complete (49.40s)
    --- PASS: TestAccAppStreamImageBuilder_withIAMRole (579.07s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appstream	1707.281s
    ewbankkit committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    498f83d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c872312 View commit details
    Browse the repository at this point in the history
  5. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccAutoScalingLifecycleHook_' PKG=autoscaling ACCTEST_PARALLELISM=3
    make: Verifying source code with gofmt...
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.22.5 test ./internal/service/autoscaling/... -v -count 1 -parallel 3  -run=TestAccAutoScalingLifecycleHook_ -timeout 360m
    === RUN   TestAccAutoScalingLifecycleHook_basic
    === PAUSE TestAccAutoScalingLifecycleHook_basic
    === RUN   TestAccAutoScalingLifecycleHook_disappears
    === PAUSE TestAccAutoScalingLifecycleHook_disappears
    === RUN   TestAccAutoScalingLifecycleHook_omitDefaultResult
    === PAUSE TestAccAutoScalingLifecycleHook_omitDefaultResult
    === CONT  TestAccAutoScalingLifecycleHook_basic
    === CONT  TestAccAutoScalingLifecycleHook_omitDefaultResult
    === CONT  TestAccAutoScalingLifecycleHook_disappears
    --- PASS: TestAccAutoScalingLifecycleHook_omitDefaultResult (151.45s)
    --- PASS: TestAccAutoScalingLifecycleHook_disappears (179.05s)
    --- PASS: TestAccAutoScalingLifecycleHook_basic (209.39s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	214.342s
    ewbankkit committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    41510be View commit details
    Browse the repository at this point in the history
  6. r/aws_ecr_lifecycle_policy: Eliminate use of 'github.com/aws/aws-sdk-…

    …go/private/protocol/json/jsonutil'.
    ewbankkit committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    2a373f5 View commit details
    Browse the repository at this point in the history
  7. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccECRLifecyclePolicy' PKG=ecr ACCTEST_PARALLELISM=3
    make: Verifying source code with gofmt...
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.22.5 test ./internal/service/ecr/... -v -count 1 -parallel 3  -run=TestAccECRLifecyclePolicy -timeout 360m
    === RUN   TestAccECRLifecyclePolicyDocumentDataSource_basic
    --- PASS: TestAccECRLifecyclePolicyDocumentDataSource_basic (5.92s)
    === RUN   TestAccECRLifecyclePolicy_basic
    === PAUSE TestAccECRLifecyclePolicy_basic
    === RUN   TestAccECRLifecyclePolicy_disappears
    === PAUSE TestAccECRLifecyclePolicy_disappears
    === RUN   TestAccECRLifecyclePolicy_ignoreEquivalent
    === PAUSE TestAccECRLifecyclePolicy_ignoreEquivalent
    === RUN   TestAccECRLifecyclePolicy_detectDiff
    === PAUSE TestAccECRLifecyclePolicy_detectDiff
    === RUN   TestAccECRLifecyclePolicy_detectTagPatternListDiff
    === PAUSE TestAccECRLifecyclePolicy_detectTagPatternListDiff
    === CONT  TestAccECRLifecyclePolicy_basic
    === CONT  TestAccECRLifecyclePolicy_detectDiff
    === CONT  TestAccECRLifecyclePolicy_detectTagPatternListDiff
    --- PASS: TestAccECRLifecyclePolicy_basic (11.87s)
    === CONT  TestAccECRLifecyclePolicy_ignoreEquivalent
    --- PASS: TestAccECRLifecyclePolicy_detectDiff (13.53s)
    === CONT  TestAccECRLifecyclePolicy_disappears
    --- PASS: TestAccECRLifecyclePolicy_detectTagPatternListDiff (13.59s)
    --- PASS: TestAccECRLifecyclePolicy_disappears (9.63s)
    --- PASS: TestAccECRLifecyclePolicy_ignoreEquivalent (12.08s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	34.781s
    ewbankkit committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    b21e242 View commit details
    Browse the repository at this point in the history
  8. r/aws_ecs_task_definition: Eliminate use of 'github.com/aws/aws-sdk-g…

    …o/private/protocol/json/jsonutil'.
    ewbankkit committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    0b51dfc View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    eec09dc View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    59dfb26 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    61fd393 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    40d7c91 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    27f0618 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    10e8a0a View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    5289211 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    9559009 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    6afe79d View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    ddfed7c View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    9b43382 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    dc56bb3 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    1ada017 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    51ef973 View commit details
    Browse the repository at this point in the history
  23. Cosmetics.

    ewbankkit committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e7fd913 View commit details
    Browse the repository at this point in the history
  24. ecs: Tidy up sweepers.

    ewbankkit committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    86bfb11 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    2476b3e View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    dd157df View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    7f700dd View commit details
    Browse the repository at this point in the history
  28. ecs: Skip acceptance test errors like 'InvalidParameterException: ECS…

    … managed EBS volume configuration was invalid for volume 'vol1'. Encountered 'VolumeTypeNotAvailableInZone' error from AmazonEC2: "The specified zone does not support gp3 volume type."'.
    ewbankkit committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    1b56aa7 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Configuration menu
    Copy the full SHA
    8887eba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3c94609 View commit details
    Browse the repository at this point in the history