Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add attrs related to endpoint v2 for aws_opensearch_domain #38456

Merged

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Jul 21, 2024

Description

This PR is to add the following attributes to the aws_opensearch_domain resource and data source to provide access to details related to endpoint V2 for dual-stack OpenSearch domain setup:

  • dashboard_endpoint_v2
  • domain_endpoint_v2_hosted_zone_id
  • endpoint_v2

Relations

Closes #38012

References

Referred to DomainStatus for specs. Also referred to Creating a custom endpoint for Amazon OpenSearch Service for more information about the DomainEndpointV2HostedZoneId attribute which also need to be added for completeness, but wasn't immediately clear how to use it since it's related to custom endpoints.

Output from Acceptance Testing

$ make testacc TESTS="TestAccOpenSearchDomain_ipAddressType|TestAccOpenSearchDomain_VPC_ipAddressType|TestAccOpenSearchDomainDataSource_Data_" PKG=opensearch
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/opensearch/... -v -count 1 -parallel 20 -run='TestAccOpenSearchDomain_ipAddressType|TestAccOpenSearchDomain_VPC_ipAddressType|TestAccOpenSearchDomainDataSource_Data_'  -timeout 360m
=== RUN   TestAccOpenSearchDomainDataSource_Data_basic
=== PAUSE TestAccOpenSearchDomainDataSource_Data_basic
=== RUN   TestAccOpenSearchDomainDataSource_Data_advanced
=== PAUSE TestAccOpenSearchDomainDataSource_Data_advanced
=== RUN   TestAccOpenSearchDomain_VPC_ipAddressType
=== PAUSE TestAccOpenSearchDomain_VPC_ipAddressType
=== RUN   TestAccOpenSearchDomain_ipAddressType
=== PAUSE TestAccOpenSearchDomain_ipAddressType
=== CONT  TestAccOpenSearchDomainDataSource_Data_basic
=== CONT  TestAccOpenSearchDomain_VPC_ipAddressType
=== CONT  TestAccOpenSearchDomainDataSource_Data_advanced
=== CONT  TestAccOpenSearchDomain_ipAddressType
--- PASS: TestAccOpenSearchDomainDataSource_Data_basic (2151.97s)
--- PASS: TestAccOpenSearchDomainDataSource_Data_advanced (2412.03s)
--- PASS: TestAccOpenSearchDomain_ipAddressType (3663.95s)
--- PASS: TestAccOpenSearchDomain_VPC_ipAddressType (5114.13s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearch 5114.368s

$

@acwwat acwwat requested a review from a team as a code owner July 21, 2024 19:33
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/opensearch Issues and PRs that pertain to the opensearch service. size/L Managed by automation to categorize the size of a PR. labels Jul 21, 2024
@acwwat acwwat force-pushed the f-aws_opensearch_domain-add_endpoint_v2_attrs branch from b517d58 to a099d5a Compare July 21, 2024 19:35
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@acwwat acwwat force-pushed the f-aws_opensearch_domain-add_endpoint_v2_attrs branch from a099d5a to 2f2e55d Compare July 21, 2024 19:44
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@charltonstanley
Copy link

Hi there, we are actively waiting for this to be merged and released so that we can use the domain_endpoint_v2_hosted_zone_id field to create the route53 cname alias dns record. Any chance this will be reviewed and released soon?

@justinretzolk justinretzolk added the external-maintainer Contribution from a trusted external contributor. label Jul 29, 2024
@ewbankkit ewbankkit self-assigned this Aug 21, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 21, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccOpenSearchDomain_VPC_ipAddressType\|TestAccOpenSearchDomain_basic\|TestAccOpenSearchDomain_ipAddressType' PKG=opensearch ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/opensearch/... -v -count 1 -parallel 2  -run=TestAccOpenSearchDomain_VPC_ipAddressType\|TestAccOpenSearchDomain_basic\|TestAccOpenSearchDomain_ipAddressType -timeout 720m
=== RUN   TestAccOpenSearchDomain_basic
=== PAUSE TestAccOpenSearchDomain_basic
=== RUN   TestAccOpenSearchDomain_VPC_ipAddressType
=== PAUSE TestAccOpenSearchDomain_VPC_ipAddressType
=== RUN   TestAccOpenSearchDomain_ipAddressType
=== PAUSE TestAccOpenSearchDomain_ipAddressType
=== CONT  TestAccOpenSearchDomain_basic
=== CONT  TestAccOpenSearchDomain_ipAddressType
--- PASS: TestAccOpenSearchDomain_basic (1792.04s)
=== CONT  TestAccOpenSearchDomain_VPC_ipAddressType
--- PASS: TestAccOpenSearchDomain_ipAddressType (3631.85s)
--- PASS: TestAccOpenSearchDomain_VPC_ipAddressType (5109.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	6909.942s

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e2afe00 into hashicorp:main Aug 21, 2024
45 checks passed
@github-actions github-actions bot added this to the v5.64.0 milestone Aug 21, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 22, 2024
Copy link

This functionality has been released in v5.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@acwwat acwwat deleted the f-aws_opensearch_domain-add_endpoint_v2_attrs branch September 16, 2024 00:12
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. service/opensearch Issues and PRs that pertain to the opensearch service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: EndpointV2 missing in output for aws_opensearch_domain for IPv6 dualstack support
4 participants