Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry acm certificate delete when in use exception. #3868

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Retry acm certificate delete when in use exception. #3868

merged 1 commit into from
Mar 22, 2018

Conversation

genevieve
Copy link
Contributor

Fixes #3866

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Mar 22, 2018
@bflad bflad added service/acm Issues and PRs that pertain to the acm service. enhancement Requests to existing resources that expand the functionality or scope. labels Mar 22, 2018
bflad
bflad approved these changes Mar 22, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thanks so much for this contribution! 🚀

@bflad bflad merged commit 2e7b47a into hashicorp:master Mar 22, 2018
@bflad bflad added this to the v1.12.0 milestone Mar 22, 2018
bflad added a commit that referenced this pull request Mar 22, 2018
@bflad
Update CHANGELOG for #3868
d3d7ce4
@genevieve
Copy link
Contributor Author

Thanks Brian!

@bflad bflad mentioned this pull request Mar 22, 2018
Closed
@bflad
Copy link
Contributor

bflad commented Mar 23, 2018

This has been released in version 1.12.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ophintor ophintor mentioned this pull request Oct 4, 2018
Closed
binarymist
binarymist reviewed Feb 26, 2020
View reviewed changes
aws/resource_aws_acm_certificate.go
params := &acm.DeleteCertificateInput{
CertificateArn: aws.String(d.Id()),
}

_, err := acmconn.DeleteCertificate(params)
err := resource.Retry(10*time.Minute, func() *resource.RetryError {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 min isn't long enough

@ghost
Copy link

ghost commented Feb 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@binarymist binarymist binarymist left review comments

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/acm Issues and PRs that pertain to the acm service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.12.0
Development

Successfully merging this pull request may close these issues.

Deleting ACM certificate fails with ResourceInUseException by a deleted ELB.
3 participants
@genevieve @bflad @binarymist