Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move attribute to correct location in example code #38712

Merged

Conversation

stefanfreitag
Copy link
Contributor

Description

The example provided in the documentation does not pass a terraform validate run.

Reason: token_domains is in the wrong place. In the example it is part of a rule inside , but it needs to be provided on resource level. Under references I provided a link to the relevant source code section.

Relations

Closes #38703

References

Output from Acceptance Testing

Not applicable. Only documentation is updated.

@stefanfreitag stefanfreitag requested a review from a team as a code owner August 6, 2024 17:14
Copy link

github-actions bot commented Aug 6, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/wafv2 Issues and PRs that pertain to the wafv2 service. needs-triage Waiting for first response or review from a maintainer. labels Aug 6, 2024
Copy link
Member

@justinretzolk justinretzolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you very much for taking the time to fix this! I'll get it merged once the checks finish up 🚀

@justinretzolk justinretzolk merged commit 6e3d840 into hashicorp:main Aug 6, 2024
29 checks passed
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Aug 6, 2024
@github-actions github-actions bot added this to the v5.62.0 milestone Aug 6, 2024
Copy link

github-actions bot commented Aug 9, 2024

This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: An argument named "token_domains" is not expected here.
3 participants