Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sweeper crashes #38920

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Fix sweeper crashes #38920

merged 3 commits into from
Aug 19, 2024

Conversation

ewbankkit
Copy link
Contributor

Description

Fixes

2024/08/19 07:37:34 [DEBUG] Running Sweeper (aws_redshiftserverless_snapshot) in region (us-gov-east-1)
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x8 pc=0x11469c420]

goroutine 1 [running]:
github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless.sweepSnapshots({0x16ae6373b, 0xd})
	/Users/kewbank/altsrc.2/github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless/sweep.go:137 +0x1c0
github.com/hashicorp/terraform-plugin-testing/helper/resource.runSweeperWithRegion({0x16ae6373b, 0xd}, 0x14000716ab0, 0x1400111ccf0, 0x14000726c00, 0x0)
	/Users/kewbank/go/pkg/mod/github.com/hashicorp/terraform-plugin-testing@v1.10.0/helper/resource/testing.go:273 +0x42c
github.com/hashicorp/terraform-plugin-testing/helper/resource.runSweepers({0x140007b67e0, 0x1, 0x1400111ccf0?}, 0x1400111ccf0, 0x0)
	/Users/kewbank/go/pkg/mod/github.com/hashicorp/terraform-plugin-testing@v1.10.0/helper/resource/testing.go:151 +0x42c
github.com/hashicorp/terraform-plugin-testing/helper/resource.TestMain({0x11a7489f8, 0x14001618f00})
	/Users/kewbank/go/pkg/mod/github.com/hashicorp/terraform-plugin-testing@v1.10.0/helper/resource/testing.go:129 +0xf4
github.com/hashicorp/terraform-provider-aws/internal/sweep_test.TestMain(0x14001618f00)
	/Users/kewbank/altsrc.2/github.com/hashicorp/terraform-provider-aws/internal/sweep/sweep_test.go:21 +0x7c
main.main()
	_testmain.go:49 +0x170
FAIL	github.com/hashicorp/terraform-provider-aws/internal/sweep	74.091s
FAIL
make: *** [sweep] Error 1

and the equivalent pattern in redshift.

Relations

Relates #38851.

@ewbankkit ewbankkit requested a review from a team as a code owner August 19, 2024 13:47
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/redshift Issues and PRs that pertain to the redshift service. sweeper Pertains to changes to or issues with the sweeper. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 19, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit merged commit 4bb28f7 into main Aug 19, 2024
35 of 36 checks passed
@ewbankkit ewbankkit deleted the s-fixes branch August 19, 2024 15:39
@github-actions github-actions bot added this to the v5.64.0 milestone Aug 19, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Aug 19, 2024
Copy link

This functionality has been released in v5.63.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 20, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/redshift Issues and PRs that pertain to the redshift service. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. sweeper Pertains to changes to or issues with the sweeper.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants