Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failure reason and failure code for collection failures #39474

Closed
wants to merge 1 commit into from

Conversation

mumoumit
Copy link
Contributor

Description

Added FailureMessage and FailureCode to the output if Collection Creation or Deletion fails.

Relations

N/A

References

Output from Acceptance Testing

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20 -run='TestAccOpenSearchServerlessCollection'  -timeout 360m
=== RUN   TestAccOpenSearchServerlessCollectionDataSource_basic
=== PAUSE TestAccOpenSearchServerlessCollectionDataSource_basic
=== RUN   TestAccOpenSearchServerlessCollectionDataSource_name
=== PAUSE TestAccOpenSearchServerlessCollectionDataSource_name
=== RUN   TestAccOpenSearchServerlessCollection_basic
=== PAUSE TestAccOpenSearchServerlessCollection_basic
=== RUN   TestAccOpenSearchServerlessCollection_standbyReplicas
=== PAUSE TestAccOpenSearchServerlessCollection_standbyReplicas
=== RUN   TestAccOpenSearchServerlessCollection_tags
=== PAUSE TestAccOpenSearchServerlessCollection_tags
=== RUN   TestAccOpenSearchServerlessCollection_update
=== PAUSE TestAccOpenSearchServerlessCollection_update
=== RUN   TestAccOpenSearchServerlessCollection_disappears
=== PAUSE TestAccOpenSearchServerlessCollection_disappears
=== CONT  TestAccOpenSearchServerlessCollectionDataSource_basic
=== CONT  TestAccOpenSearchServerlessCollection_tags
=== CONT  TestAccOpenSearchServerlessCollection_standbyReplicas
=== CONT  TestAccOpenSearchServerlessCollectionDataSource_name
=== CONT  TestAccOpenSearchServerlessCollection_basic
=== CONT  TestAccOpenSearchServerlessCollection_disappears
=== CONT  TestAccOpenSearchServerlessCollection_update
--- PASS: TestAccOpenSearchServerlessCollection_disappears (75.92s)
--- PASS: TestAccOpenSearchServerlessCollectionDataSource_basic (78.17s)
--- PASS: TestAccOpenSearchServerlessCollectionDataSource_name (78.30s)
--- PASS: TestAccOpenSearchServerlessCollection_basic (90.04s)
--- PASS: TestAccOpenSearchServerlessCollection_standbyReplicas (90.11s)
--- PASS: TestAccOpenSearchServerlessCollection_update (96.83s)
--- PASS: TestAccOpenSearchServerlessCollection_tags (99.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless      99.257s

@mumoumit mumoumit requested a review from a team as a code owner September 24, 2024 20:58
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. needs-triage Waiting for first response or review from a maintainer. labels Sep 24, 2024
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 25, 2024
@ewbankkit ewbankkit self-assigned this Sep 25, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants