Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_simpledb_domain: Deprecate resource #39536

Merged
merged 4 commits into from
Sep 30, 2024
Merged

r/aws_simpledb_domain: Deprecate resource #39536

merged 4 commits into from
Sep 30, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 30, 2024 •
edited
Loading

Description

Deprecates the aws_simpledb_domain resource.

Relations

Closes #39509.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccSimpleDBDomain_' PKG=simpledb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/simpledb/... -v -count 1 -parallel 20  -run=TestAccSimpleDBDomain_ -timeout 360m
=== RUN   TestAccSimpleDBDomain_basic
=== PAUSE TestAccSimpleDBDomain_basic
=== RUN   TestAccSimpleDBDomain_disappears
=== PAUSE TestAccSimpleDBDomain_disappears
=== RUN   TestAccSimpleDBDomain_MigrateFromPluginSDK
=== PAUSE TestAccSimpleDBDomain_MigrateFromPluginSDK
=== CONT  TestAccSimpleDBDomain_basic
=== CONT  TestAccSimpleDBDomain_MigrateFromPluginSDK
=== CONT  TestAccSimpleDBDomain_disappears
--- PASS: TestAccSimpleDBDomain_disappears (11.99s)
--- PASS: TestAccSimpleDBDomain_basic (14.13s)
--- PASS: TestAccSimpleDBDomain_MigrateFromPluginSDK (27.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/simpledb	32.570s

@ewbankkit
Acceptance test output:
992e9ac 
% make testacc TESTARGS='-run=TestAccSimpleDBDomain_' PKG=simpledb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/simpledb/... -v -count 1 -parallel 20  -run=TestAccSimpleDBDomain_ -timeout 360m
=== RUN   TestAccSimpleDBDomain_basic
=== PAUSE TestAccSimpleDBDomain_basic
=== RUN   TestAccSimpleDBDomain_disappears
=== PAUSE TestAccSimpleDBDomain_disappears
=== RUN   TestAccSimpleDBDomain_MigrateFromPluginSDK
=== PAUSE TestAccSimpleDBDomain_MigrateFromPluginSDK
=== CONT  TestAccSimpleDBDomain_basic
=== CONT  TestAccSimpleDBDomain_MigrateFromPluginSDK
=== CONT  TestAccSimpleDBDomain_disappears
--- PASS: TestAccSimpleDBDomain_disappears (12.13s)
--- PASS: TestAccSimpleDBDomain_basic (14.48s)
--- PASS: TestAccSimpleDBDomain_MigrateFromPluginSDK (28.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/simpledb	34.191s
@ewbankkit
r/aws_simpledb_domain: Deprecate resource.
ac40714
@ewbankkit ewbankkit requested a review from a team as a code owner September 30, 2024 15:18
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/simpledb Issues and PRs that pertain to the simpledb service. sweeper Pertains to changes to or issues with the sweeper. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 30, 2024
johnsonaj
johnsonaj approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit merged commit 0719d6f into main Sep 30, 2024
35 checks passed
@ewbankkit ewbankkit deleted the td-deprecate-simpledb branch September 30, 2024 16:39
@github-actions github-actions bot added this to the v5.70.0 milestone Sep 30, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Sep 30, 2024
Update CHANGELOG.md for #39536
82e77af
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsonaj johnsonaj johnsonaj approved these changes

Assignees
No one assigned
Labels
generators Relates to code generators. service/simpledb Issues and PRs that pertain to the simpledb service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.70.0
Development

Successfully merging this pull request may close these issues.

r/aws_simpledb_domain: Deprecate
2 participants
@ewbankkit @johnsonaj