Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_lb_listener: Add support for TCP idle timeout for NLB, GWLB listeners #39585

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ddericco
Copy link
Contributor

@ddericco ddericco commented Oct 3, 2024

Description

Adds support for TCP idle timeout attribute on aws_lb_listener. This is supported for Network Load Balancer (NLB) listeners using the TCP protocol, and Gateway Load Balancers (GWLB) with the default GENEVE protocol.

Relations

Closes #39149

References

Output from Acceptance Testing

$ make testacc TESTS='TestAccELBV2Listener_attributes_*' PKG=elbv2                                                    
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2Listener_attributes_*'  -timeout 360m
=== RUN   TestAccELBV2Listener_attributes_gwlb_TCPIdleTimeoutSeconds
=== PAUSE TestAccELBV2Listener_attributes_gwlb_TCPIdleTimeoutSeconds
=== RUN   TestAccELBV2Listener_attributes_nlb_TCPIdleTimeoutSeconds
=== PAUSE TestAccELBV2Listener_attributes_nlb_TCPIdleTimeoutSeconds
=== CONT  TestAccELBV2Listener_attributes_gwlb_TCPIdleTimeoutSeconds
=== CONT  TestAccELBV2Listener_attributes_nlb_TCPIdleTimeoutSeconds
--- PASS: TestAccELBV2Listener_attributes_gwlb_TCPIdleTimeoutSeconds (187.47s)
--- PASS: TestAccELBV2Listener_attributes_nlb_TCPIdleTimeoutSeconds (250.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      256.811s

Copy link

github-actions bot commented Oct 3, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elbv2 Issues and PRs that pertain to the elbv2 service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Oct 3, 2024
@ddericco ddericco marked this pull request as ready for review October 10, 2024 18:49
@ddericco ddericco requested a review from a team as a code owner October 10, 2024 18:49
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/elbv2 Issues and PRs that pertain to the elbv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Network Load Balancer & Gateway Load Balancer now supports configurable TCP idle timeout
2 participants