Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaff: fix errant opening brace #39649

Merged
merged 1 commit into from
Oct 10, 2024
Merged

skaff: fix errant opening brace #39649

merged 1 commit into from
Oct 10, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Oct 9, 2024

Description

On newly generated files this syntax error prevents language server diagnostics from being displayed.

@jar-b jar-b requested a review from a team as a code owner October 9, 2024 20:49
Copy link

github-actions bot commented Oct 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added skaff Issues and pull requested related to the skaff tool prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 9, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit 7878ee5 into main Oct 10, 2024
16 checks passed
@jar-b jar-b deleted the td-skaff-syntaxerr branch October 10, 2024 13:58
@github-actions github-actions bot added this to the v5.71.0 milestone Oct 10, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Oct 10, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 15, 2024
Copy link

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skaff Issues and pull requested related to the skaff tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants