Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_route53profiles_association: add tags #39661

Merged
merged 2 commits into from
Oct 10, 2024
Merged

r/aws_route53profiles_association: add tags #39661

merged 2 commits into from
Oct 10, 2024

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented Oct 10, 2024

Description

Add tagging and testing to the resource aws_route53profiles_association.

Relations

Relates #39613

References

Output from Acceptance Testing

> make testacc TESTARGS='-run=TestAccRoute53ProfilesAssociation_' PKG=route53profiles
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/route53profiles/... -v -count 1 -parallel 20  -run=TestAccRoute53ProfilesAssociation_ -timeout 360m
2024/10/09 21:35:48 Initializing Terraform AWS Provider...
=== RUN   TestAccRoute53ProfilesAssociation_basic
=== PAUSE TestAccRoute53ProfilesAssociation_basic
=== RUN   TestAccRoute53ProfilesAssociation_tags
=== PAUSE TestAccRoute53ProfilesAssociation_tags
=== RUN   TestAccRoute53ProfilesAssociation_disappears
=== PAUSE TestAccRoute53ProfilesAssociation_disappears
=== CONT  TestAccRoute53ProfilesAssociation_basic
=== CONT  TestAccRoute53ProfilesAssociation_disappears
=== CONT  TestAccRoute53ProfilesAssociation_tags
--- PASS: TestAccRoute53ProfilesAssociation_disappears (274.20s)
--- PASS: TestAccRoute53ProfilesAssociation_basic (286.86s)
--- PASS: TestAccRoute53ProfilesAssociation_tags (305.23s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53profiles    310.074s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/route53profiles Issues and PRs that pertain to the route53profiles service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 10, 2024
@nam054 nam054 marked this pull request as ready for review October 10, 2024 04:45
@nam054 nam054 requested a review from a team as a code owner October 10, 2024 04:45
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

%  make testacc PKG=route53profiles TESTS=TestAccRoute53ProfilesAssociation_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/route53profiles/... -v -count 1 -parallel 20 -run='TestAccRoute53ProfilesAssociation_'  -timeout 360m
2024/10/10 10:09:37 Initializing Terraform AWS Provider...

--- PASS: TestAccRoute53ProfilesAssociation_basic (288.97s)
--- PASS: TestAccRoute53ProfilesAssociation_disappears (296.72s)
--- PASS: TestAccRoute53ProfilesAssociation_tags (309.59s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53profiles    315.913s

@nam054 nam054 merged commit 7964acb into main Oct 10, 2024
71 checks passed
@nam054 nam054 deleted the f/r53-add-tags branch October 10, 2024 18:27
@github-actions github-actions bot added this to the v5.71.0 milestone Oct 10, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/route53profiles Issues and PRs that pertain to the route53profiles service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants