-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tagging tests: Adds tests for ignoring tags #39734
Merged
Merged
+67,265
−1,269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
documentation
Introduces or discusses updates to documentation.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
service/lambda
Issues and PRs that pertain to the lambda service.
service/iam
Issues and PRs that pertain to the iam service.
service/ec2
Issues and PRs that pertain to the ec2 service.
service/s3
Issues and PRs that pertain to the s3 service.
service/elbv2
Issues and PRs that pertain to the elbv2 service.
service/apigateway
Issues and PRs that pertain to the apigateway service.
service/sns
Issues and PRs that pertain to the sns service.
service/rds
Issues and PRs that pertain to the rds service.
service/sqs
Issues and PRs that pertain to the sqs service.
service/acm
Issues and PRs that pertain to the acm service.
service/medialive
Issues and PRs that pertain to the medialive service.
service/dynamodb
Issues and PRs that pertain to the dynamodb service.
service/ssm
Issues and PRs that pertain to the ssm service.
service/cloudwatch
Issues and PRs that pertain to the cloudwatch service.
service/servicecatalog
Issues and PRs that pertain to the servicecatalog service.
service/kms
Issues and PRs that pertain to the kms service.
service/batch
Issues and PRs that pertain to the batch service.
provider
Pertains to the provider itself, rather than any interaction with AWS.
service/secretsmanager
Issues and PRs that pertain to the secretsmanager service.
service/fms
Issues and PRs that pertain to the fms service.
service/acmpca
Issues and PRs that pertain to the acmpca service.
service/xray
Issues and PRs that pertain to the xray service.
service/amplify
Issues and PRs that pertain to the amplify service.
service/appmesh
Issues and PRs that pertain to the appmesh service.
service/apigatewayv2
Issues and PRs that pertain to the apigatewayv2 service.
service/applicationinsights
Issues and PRs that pertain to the applicationinsights service.
labels
Oct 15, 2024
…t is not set on tags spec
gdavison
force-pushed
the
td-generate-tagtests-ignore-tags
branch
from
October 16, 2024 05:40
51d0e99
to
96fbcc9
Compare
ewbankkit
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccBatchJobDefinitionDataSource_' PKG=batch ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/batch/... -v -count 1 -parallel 3 -run=TestAccBatchJobDefinitionDataSource_ -timeout 360m
2024/10/16 08:15:56 Initializing Terraform AWS Provider...
=== RUN TestAccBatchJobDefinitionDataSource_tags
=== PAUSE TestAccBatchJobDefinitionDataSource_tags
=== RUN TestAccBatchJobDefinitionDataSource_tags_NullMap
=== PAUSE TestAccBatchJobDefinitionDataSource_tags_NullMap
=== RUN TestAccBatchJobDefinitionDataSource_tags_EmptyMap
=== PAUSE TestAccBatchJobDefinitionDataSource_tags_EmptyMap
=== RUN TestAccBatchJobDefinitionDataSource_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccBatchJobDefinitionDataSource_tags_DefaultTags_nonOverlapping
=== RUN TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== RUN TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== RUN TestAccBatchJobDefinitionDataSource_basicName
=== PAUSE TestAccBatchJobDefinitionDataSource_basicName
=== RUN TestAccBatchJobDefinitionDataSource_basicARN
=== PAUSE TestAccBatchJobDefinitionDataSource_basicARN
=== RUN TestAccBatchJobDefinitionDataSource_basicARN_NodeProperties
=== PAUSE TestAccBatchJobDefinitionDataSource_basicARN_NodeProperties
=== RUN TestAccBatchJobDefinitionDataSource_basicARN_EKSProperties
=== PAUSE TestAccBatchJobDefinitionDataSource_basicARN_EKSProperties
=== CONT TestAccBatchJobDefinitionDataSource_tags
=== CONT TestAccBatchJobDefinitionDataSource_basicARN_NodeProperties
=== CONT TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccBatchJobDefinitionDataSource_tags (10.82s)
=== CONT TestAccBatchJobDefinitionDataSource_tags_DefaultTags_nonOverlapping
--- PASS: TestAccBatchJobDefinitionDataSource_basicARN_NodeProperties (11.22s)
=== CONT TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_ResourceTag (11.68s)
=== CONT TestAccBatchJobDefinitionDataSource_basicARN_EKSProperties
--- PASS: TestAccBatchJobDefinitionDataSource_tags_DefaultTags_nonOverlapping (10.16s)
=== CONT TestAccBatchJobDefinitionDataSource_basicARN
--- PASS: TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_DefaultTag (10.13s)
=== CONT TestAccBatchJobDefinitionDataSource_basicName
--- PASS: TestAccBatchJobDefinitionDataSource_basicARN_EKSProperties (10.44s)
=== CONT TestAccBatchJobDefinitionDataSource_tags_EmptyMap
--- PASS: TestAccBatchJobDefinitionDataSource_tags_EmptyMap (9.79s)
=== CONT TestAccBatchJobDefinitionDataSource_tags_NullMap
--- PASS: TestAccBatchJobDefinitionDataSource_basicARN (17.85s)
--- PASS: TestAccBatchJobDefinitionDataSource_basicName (17.47s)
--- PASS: TestAccBatchJobDefinitionDataSource_tags_NullMap (9.86s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/batch 47.098s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Introduces or discusses updates to documentation.
generators
Relates to code generators.
linter
Pertains to changes to or issues with the various linters.
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
provider
Pertains to the provider itself, rather than any interaction with AWS.
service/accessanalyzer
Issues and PRs that pertain to the accessanalyzer service.
service/acm
Issues and PRs that pertain to the acm service.
service/acmpca
Issues and PRs that pertain to the acmpca service.
service/amp
Issues and PRs that pertain to the amp service.
service/amplify
Issues and PRs that pertain to the amplify service.
service/apigateway
Issues and PRs that pertain to the apigateway service.
service/apigatewayv2
Issues and PRs that pertain to the apigatewayv2 service.
service/appautoscaling
Issues and PRs that pertain to the appautoscaling service.
service/appconfig
Issues and PRs that pertain to the appconfig service.
service/appfabric
Issues and PRs that pertain to the appfabric service.
service/appflow
Issues and PRs that pertain to the appflow service.
service/appintegrations
Issues and PRs that pertain to the appintegrations service.
service/applicationinsights
Issues and PRs that pertain to the applicationinsights service.
service/appmesh
Issues and PRs that pertain to the appmesh service.
service/apprunner
Issues and PRs that pertain to the apprunner service.
service/batch
Issues and PRs that pertain to the batch service.
service/bcmdataexports
Issues and PRs that pertain to the bcmdataexports service.
service/cloudwatch
Issues and PRs that pertain to the cloudwatch service.
service/cognitoidp
Issues and PRs that pertain to the cognitoidp service.
service/drs
Issues and PRs that pertain to the drs service.
service/dynamodb
Issues and PRs that pertain to the dynamodb service.
service/ec2
Issues and PRs that pertain to the ec2 service.
service/elbv2
Issues and PRs that pertain to the elbv2 service.
service/fms
Issues and PRs that pertain to the fms service.
service/iam
Issues and PRs that pertain to the iam service.
service/kms
Issues and PRs that pertain to the kms service.
service/lambda
Issues and PRs that pertain to the lambda service.
service/logs
Issues and PRs that pertain to the logs service.
service/m2
Issues and PRs that pertain to the m2 service.
service/medialive
Issues and PRs that pertain to the medialive service.
service/networkmonitor
Issues and PRs that pertain to the networkmonitor service.
service/rds
Issues and PRs that pertain to the rds service.
service/s3
Issues and PRs that pertain to the s3 service.
service/secretsmanager
Issues and PRs that pertain to the secretsmanager service.
service/servicecatalog
Issues and PRs that pertain to the servicecatalog service.
service/sns
Issues and PRs that pertain to the sns service.
service/sqs
Issues and PRs that pertain to the sqs service.
service/ssm
Issues and PRs that pertain to the ssm service.
service/timestreaminfluxdb
Issues and PRs that pertain to the timestreaminfluxdb service.
service/vpc
Issues and PRs that pertain to the vpc service.
service/xray
Issues and PRs that pertain to the xray service.
tags
Pertains to resource tagging.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for ignored tags when same tag is set on either default tags or resource tags
Adds tests for default tags for data sources
Issue #39733 was detected while creating this PR