Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B: leaking vpc related resources issue fix #39748

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

B: leaking vpc related resources issue fix #39748

wants to merge 5 commits into from
+23 −8

Conversation

woranhun
Copy link

@woranhun woranhun commented Oct 16, 2024 •
edited
Loading

Description

This PR fixes the issue described in #39741 for :

  • aws_subnet
  • aws_ec2_subnet_cidr_reservation
  • aws_security_group_rule
  • aws_network_acl_rule

Relations

Closes #39741

References

crossplane-contrib/provider-upjet-aws#1482

Output from Acceptance Testing

TestAccVPCSubnetCIDRReservation

❯ make testacc PKG=ec2 TESTS=TestAccVPCSubnetCIDRReservation
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCSubnetCIDRReservation'  -timeout 360m
2024/10/16 08:47:23 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCSubnetCIDRReservation_basic
=== PAUSE TestAccVPCSubnetCIDRReservation_basic
=== RUN   TestAccVPCSubnetCIDRReservation_ipv6
=== PAUSE TestAccVPCSubnetCIDRReservation_ipv6
=== RUN   TestAccVPCSubnetCIDRReservation_disappears
=== PAUSE TestAccVPCSubnetCIDRReservation_disappears
=== CONT  TestAccVPCSubnetCIDRReservation_basic
=== CONT  TestAccVPCSubnetCIDRReservation_disappears
=== CONT  TestAccVPCSubnetCIDRReservation_ipv6
--- PASS: TestAccVPCSubnetCIDRReservation_disappears (26.91s)
--- PASS: TestAccVPCSubnetCIDRReservation_basic (29.57s)
--- PASS: TestAccVPCSubnetCIDRReservation_ipv6 (40.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2

TestAccVPCNetworkACLRule

❯ make testacc PKG=ec2 TESTS=TestAccVPCNetworkACLRule
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCNetworkACLRule'  -timeout 360m
2024/10/16 08:49:44 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCNetworkACLRule_basic
=== PAUSE TestAccVPCNetworkACLRule_basic
=== RUN   TestAccVPCNetworkACLRule_disappears
=== PAUSE TestAccVPCNetworkACLRule_disappears
=== RUN   TestAccVPCNetworkACLRule_Disappears_networkACL
=== PAUSE TestAccVPCNetworkACLRule_Disappears_networkACL
=== RUN   TestAccVPCNetworkACLRule_Disappears_ingressEgressSameNumber
=== PAUSE TestAccVPCNetworkACLRule_Disappears_ingressEgressSameNumber
=== RUN   TestAccVPCNetworkACLRule_ipv6
=== PAUSE TestAccVPCNetworkACLRule_ipv6
=== RUN   TestAccVPCNetworkACLRule_ipv6ICMP
=== PAUSE TestAccVPCNetworkACLRule_ipv6ICMP
=== RUN   TestAccVPCNetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate
=== PAUSE TestAccVPCNetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate
=== RUN   TestAccVPCNetworkACLRule_allProtocol
=== PAUSE TestAccVPCNetworkACLRule_allProtocol
=== RUN   TestAccVPCNetworkACLRule_tcpProtocol
=== PAUSE TestAccVPCNetworkACLRule_tcpProtocol
=== RUN   TestAccVPCNetworkACLRule_duplicate
=== PAUSE TestAccVPCNetworkACLRule_duplicate
=== CONT  TestAccVPCNetworkACLRule_basic
=== CONT  TestAccVPCNetworkACLRule_ipv6ICMP
=== CONT  TestAccVPCNetworkACLRule_tcpProtocol
=== CONT  TestAccVPCNetworkACLRule_Disappears_ingressEgressSameNumber
=== CONT  TestAccVPCNetworkACLRule_ipv6
=== CONT  TestAccVPCNetworkACLRule_Disappears_networkACL
=== CONT  TestAccVPCNetworkACLRule_disappears
=== CONT  TestAccVPCNetworkACLRule_allProtocol
=== CONT  TestAccVPCNetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate
=== CONT  TestAccVPCNetworkACLRule_duplicate
--- PASS: TestAccVPCNetworkACLRule_duplicate (18.92s)
--- PASS: TestAccVPCNetworkACLRule_Disappears_ingressEgressSameNumber (32.74s)
--- PASS: TestAccVPCNetworkACLRule_disappears (34.06s)
--- PASS: TestAccVPCNetworkACLRule_ipv6ICMP (35.22s)
--- PASS: TestAccVPCNetworkACLRule_Disappears_networkACL (35.42s)
--- PASS: TestAccVPCNetworkACLRule_ipv6 (35.51s)
--- PASS: TestAccVPCNetworkACLRule_allProtocol (39.27s)
--- PASS: TestAccVPCNetworkACLRule_tcpProtocol (39.30s)
--- PASS: TestAccVPCNetworkACLRule_basic (45.66s)
--- PASS: TestAccVPCNetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate (62.54s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        62.689s

TestSecurityGroupRule

❯ make testacc PKG=ec2 TESTS=TestSecurityGroupRule
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestSecurityGroupRule'  -timeout 360m
2024/10/16 08:55:13 Initializing Terraform AWS Provider...
=== RUN   TestSecurityGroupRuleMigrateState
=== PAUSE TestSecurityGroupRuleMigrateState
=== RUN   TestSecurityGroupRuleCreateID
=== PAUSE TestSecurityGroupRuleCreateID
=== CONT  TestSecurityGroupRuleMigrateState
2024/10/16 08:55:13 [INFO] Found AWS Security Group State v0; migrating to v1
=== CONT  TestSecurityGroupRuleCreateID
2024/10/16 08:55:13 [DEBUG] Attributes before migration: map[string]string{"cidr_blocks.#":"0", "from_port":"0", "protocol":"-1", "security_group_id":"sg-13877277", "self":"false", "source_security_group_id":"sg-11877275", "to_port":"0", "type":"ingress"}
2024/10/16 08:55:13 [DEBUG] Attributes after migration: map[string]string{"cidr_blocks.#":"0", "from_port":"0", "id":"sgrule-2889201120", "protocol":"-1", "security_group_id":"sg-13877277", "self":"false", "source_security_group_id":"sg-11877275", "to_port":"0", "type":"ingress"}, new id: sgrule-2889201120
2024/10/16 08:55:13 [INFO] Found AWS Security Group State v0; migrating to v1
--- PASS: TestSecurityGroupRuleCreateID (0.00s)
2024/10/16 08:55:13 [DEBUG] Attributes before migration: map[string]string{"cidr_blocks.#":"4", "cidr_blocks.0":"172.16.1.0/24", "cidr_blocks.1":"172.16.2.0/24", "cidr_blocks.2":"172.16.3.0/24", "cidr_blocks.3":"172.16.4.0/24", "from_port":"0", "protocol":"-1", "security_group_id":"sg-0981746d", "self":"false", "to_port":"0", "type":"ingress"}
2024/10/16 08:55:13 [DEBUG] Attributes after migration: map[string]string{"cidr_blocks.#":"4", "cidr_blocks.0":"172.16.1.0/24", "cidr_blocks.1":"172.16.2.0/24", "cidr_blocks.2":"172.16.3.0/24", "cidr_blocks.3":"172.16.4.0/24", "from_port":"0", "id":"sgrule-1826358977", "protocol":"-1", "security_group_id":"sg-0981746d", "self":"false", "to_port":"0", "type":"ingress"}, new id: sgrule-1826358977
--- PASS: TestSecurityGroupRuleMigrateState (0.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        0.139s

TestAccVPCSubnet

❯ make testacc PKG=ec2 TESTS=TestAccVPCSubnet
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 3 -run='TestAccVPCSubnet'  -timeout 360m
2024/10/16 09:09:27 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCSubnetCIDRReservation_basic
=== PAUSE TestAccVPCSubnetCIDRReservation_basic
=== RUN   TestAccVPCSubnetCIDRReservation_ipv6
=== PAUSE TestAccVPCSubnetCIDRReservation_ipv6
=== RUN   TestAccVPCSubnetCIDRReservation_disappears
=== PAUSE TestAccVPCSubnetCIDRReservation_disappears
=== RUN   TestAccVPCSubnetDataSource_basic
=== PAUSE TestAccVPCSubnetDataSource_basic
=== RUN   TestAccVPCSubnetDataSource_ipv6ByIPv6Filter
=== PAUSE TestAccVPCSubnetDataSource_ipv6ByIPv6Filter
=== RUN   TestAccVPCSubnetDataSource_ipv6ByIPv6CIDRBlock
=== PAUSE TestAccVPCSubnetDataSource_ipv6ByIPv6CIDRBlock
=== RUN   TestAccVPCSubnetDataSource_enableLniAtDeviceIndex
=== PAUSE TestAccVPCSubnetDataSource_enableLniAtDeviceIndex
=== RUN   TestAccVPCSubnet_tags
=== PAUSE TestAccVPCSubnet_tags
=== RUN   TestAccVPCSubnet_tags_null
=== PAUSE TestAccVPCSubnet_tags_null
=== RUN   TestAccVPCSubnet_tags_EmptyMap
=== PAUSE TestAccVPCSubnet_tags_EmptyMap
=== RUN   TestAccVPCSubnet_tags_AddOnUpdate
=== PAUSE TestAccVPCSubnet_tags_AddOnUpdate
=== RUN   TestAccVPCSubnet_tags_EmptyTag_OnCreate
=== PAUSE TestAccVPCSubnet_tags_EmptyTag_OnCreate
=== RUN   TestAccVPCSubnet_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccVPCSubnet_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccVPCSubnet_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccVPCSubnet_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccVPCSubnet_tags_DefaultTags_providerOnly
=== PAUSE TestAccVPCSubnet_tags_DefaultTags_providerOnly
=== RUN   TestAccVPCSubnet_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccVPCSubnet_tags_DefaultTags_nonOverlapping
=== RUN   TestAccVPCSubnet_tags_DefaultTags_overlapping
=== PAUSE TestAccVPCSubnet_tags_DefaultTags_overlapping
=== RUN   TestAccVPCSubnet_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCSubnet_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCSubnet_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCSubnet_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCSubnet_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccVPCSubnet_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccVPCSubnet_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccVPCSubnet_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccVPCSubnet_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccVPCSubnet_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccVPCSubnet_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccVPCSubnet_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccVPCSubnet_tags_ComputedTag_OnCreate
=== PAUSE TestAccVPCSubnet_tags_ComputedTag_OnCreate
=== RUN   TestAccVPCSubnet_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccVPCSubnet_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccVPCSubnet_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccVPCSubnet_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccVPCSubnet_basic
=== PAUSE TestAccVPCSubnet_basic
=== RUN   TestAccVPCSubnet_tags_defaultAndIgnoreTags
=== PAUSE TestAccVPCSubnet_tags_defaultAndIgnoreTags
=== RUN   TestAccVPCSubnet_tags_ignoreTags
=== PAUSE TestAccVPCSubnet_tags_ignoreTags
=== RUN   TestAccVPCSubnet_ipv6
=== PAUSE TestAccVPCSubnet_ipv6
=== RUN   TestAccVPCSubnet_enableIPv6
=== PAUSE TestAccVPCSubnet_enableIPv6
=== RUN   TestAccVPCSubnet_availabilityZoneID
=== PAUSE TestAccVPCSubnet_availabilityZoneID
=== RUN   TestAccVPCSubnet_disappears
=== PAUSE TestAccVPCSubnet_disappears
=== RUN   TestAccVPCSubnet_customerOwnedIPv4Pool
=== PAUSE TestAccVPCSubnet_customerOwnedIPv4Pool
=== RUN   TestAccVPCSubnet_mapCustomerOwnedIPOnLaunch
=== PAUSE TestAccVPCSubnet_mapCustomerOwnedIPOnLaunch
=== RUN   TestAccVPCSubnet_mapPublicIPOnLaunch
=== PAUSE TestAccVPCSubnet_mapPublicIPOnLaunch
=== RUN   TestAccVPCSubnet_outpost
=== PAUSE TestAccVPCSubnet_outpost
=== RUN   TestAccVPCSubnet_enableDNS64
=== PAUSE TestAccVPCSubnet_enableDNS64
=== RUN   TestAccVPCSubnet_ipv4ToIPv6
=== PAUSE TestAccVPCSubnet_ipv4ToIPv6
=== RUN   TestAccVPCSubnet_enableLNIAtDeviceIndex
=== PAUSE TestAccVPCSubnet_enableLNIAtDeviceIndex
=== RUN   TestAccVPCSubnet_privateDNSNameOptionsOnLaunch
=== PAUSE TestAccVPCSubnet_privateDNSNameOptionsOnLaunch
=== RUN   TestAccVPCSubnet_ipv6Native
=== PAUSE TestAccVPCSubnet_ipv6Native
=== RUN   TestAccVPCSubnetsDataSource_basic
=== PAUSE TestAccVPCSubnetsDataSource_basic
=== RUN   TestAccVPCSubnetsDataSource_filter
=== PAUSE TestAccVPCSubnetsDataSource_filter
=== CONT  TestAccVPCSubnetCIDRReservation_basic
=== CONT  TestAccVPCSubnet_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccVPCSubnet_tags_EmptyTag_OnCreate
--- PASS: TestAccVPCSubnetCIDRReservation_basic (29.97s)
=== CONT  TestAccVPCSubnet_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccVPCSubnet_tags_DefaultTags_nullNonOverlappingResourceTag (31.01s)
=== CONT  TestAccVPCSubnet_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccVPCSubnet_tags_EmptyTag_OnCreate (53.46s)
=== CONT  TestAccVPCSubnet_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccVPCSubnet_tags_DefaultTags_nullOverlappingResourceTag (30.58s)
=== CONT  TestAccVPCSubnet_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPCSubnet_tags_DefaultTags_emptyProviderOnlyTag (30.19s)
=== CONT  TestAccVPCSubnet_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPCSubnet_tags_DefaultTags_emptyResourceTag (30.13s)
=== CONT  TestAccVPCSubnet_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccVPCSubnet_tags_DefaultTags_updateToResourceOnly (50.80s)
=== CONT  TestAccVPCSubnet_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccVPCSubnet_tags_DefaultTags_updateToProviderOnly (50.52s)
=== CONT  TestAccVPCSubnetDataSource_enableLniAtDeviceIndex
    vpc_subnet_data_source_test.go:197: skipping since no Outposts found
--- SKIP: TestAccVPCSubnetDataSource_enableLniAtDeviceIndex (0.61s)
=== CONT  TestAccVPCSubnet_tags_AddOnUpdate
--- PASS: TestAccVPCSubnet_tags_EmptyTag_OnUpdate_Replace (48.71s)
=== CONT  TestAccVPCSubnet_tags_EmptyMap
--- PASS: TestAccVPCSubnet_tags_AddOnUpdate (48.67s)
=== CONT  TestAccVPCSubnet_tags_null
--- PASS: TestAccVPCSubnet_tags_EmptyMap (37.65s)
=== CONT  TestAccVPCSubnet_tags
--- PASS: TestAccVPCSubnet_tags_EmptyTag_OnUpdate_Add (72.75s)
=== CONT  TestAccVPCSubnetDataSource_basic
--- PASS: TestAccVPCSubnet_tags_null (38.12s)
=== CONT  TestAccVPCSubnetDataSource_ipv6ByIPv6CIDRBlock
--- PASS: TestAccVPCSubnetDataSource_basic (26.42s)
=== CONT  TestAccVPCSubnetDataSource_ipv6ByIPv6Filter
--- PASS: TestAccVPCSubnetDataSource_ipv6ByIPv6CIDRBlock (48.28s)
=== CONT  TestAccVPCSubnet_tags_DefaultTags_overlapping
--- PASS: TestAccVPCSubnetDataSource_ipv6ByIPv6Filter (48.01s)
=== CONT  TestAccVPCSubnet_tags_DefaultTags_providerOnly
--- PASS: TestAccVPCSubnet_tags (98.94s)
=== CONT  TestAccVPCSubnet_customerOwnedIPv4Pool
    vpc_subnet_test.go:285: skipping since no Outposts found
--- SKIP: TestAccVPCSubnet_customerOwnedIPv4Pool (0.60s)
=== CONT  TestAccVPCSubnet_tags_DefaultTags_nonOverlapping
--- PASS: TestAccVPCSubnet_tags_DefaultTags_overlapping (79.06s)
=== CONT  TestAccVPCSubnet_tags_ignoreTags
--- PASS: TestAccVPCSubnet_tags_DefaultTags_nonOverlapping (79.84s)
=== CONT  TestAccVPCSubnet_disappears
--- PASS: TestAccVPCSubnet_tags_DefaultTags_providerOnly (105.41s)
=== CONT  TestAccVPCSubnet_availabilityZoneID
--- PASS: TestAccVPCSubnet_tags_ignoreTags (40.73s)
=== CONT  TestAccVPCSubnet_enableIPv6
--- PASS: TestAccVPCSubnet_disappears (25.52s)
=== CONT  TestAccVPCSubnet_ipv6
--- PASS: TestAccVPCSubnet_availabilityZoneID (29.03s)
=== CONT  TestAccVPCSubnetCIDRReservation_disappears
--- PASS: TestAccVPCSubnetCIDRReservation_disappears (25.61s)
=== CONT  TestAccVPCSubnetCIDRReservation_ipv6
--- PASS: TestAccVPCSubnetCIDRReservation_ipv6 (38.63s)
=== CONT  TestAccVPCSubnet_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccVPCSubnet_enableIPv6 (94.14s)
=== CONT  TestAccVPCSubnet_tags_defaultAndIgnoreTags
--- PASS: TestAccVPCSubnet_ipv6 (93.53s)
=== CONT  TestAccVPCSubnet_basic
--- PASS: TestAccVPCSubnet_basic (27.38s)
=== CONT  TestAccVPCSubnet_ipv6Native
--- PASS: TestAccVPCSubnet_tags_defaultAndIgnoreTags (40.96s)
=== CONT  TestAccVPCSubnetsDataSource_basic
--- PASS: TestAccVPCSubnet_tags_ComputedTag_OnUpdate_Replace (51.90s)
=== CONT  TestAccVPCSubnet_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccVPCSubnet_ipv6Native (38.67s)
=== CONT  TestAccVPCSubnet_privateDNSNameOptionsOnLaunch
--- PASS: TestAccVPCSubnetsDataSource_basic (38.92s)
=== CONT  TestAccVPCSubnet_ipv4ToIPv6
--- PASS: TestAccVPCSubnet_tags_ComputedTag_OnUpdate_Add (51.45s)
=== CONT  TestAccVPCSubnet_enableLNIAtDeviceIndex
    vpc_subnet_test.go:490: skipping since no Outposts found
--- SKIP: TestAccVPCSubnet_enableLNIAtDeviceIndex (0.60s)
=== CONT  TestAccVPCSubnet_outpost
    vpc_subnet_test.go:384: skipping since no Outposts found
--- SKIP: TestAccVPCSubnet_outpost (0.24s)
=== CONT  TestAccVPCSubnet_enableDNS64
--- PASS: TestAccVPCSubnet_ipv4ToIPv6 (83.71s)
=== CONT  TestAccVPCSubnet_mapPublicIPOnLaunch
--- PASS: TestAccVPCSubnet_enableDNS64 (112.54s)
=== CONT  TestAccVPCSubnet_mapCustomerOwnedIPOnLaunch
    vpc_subnet_test.go:313: skipping since no Outposts found
--- SKIP: TestAccVPCSubnet_mapCustomerOwnedIPOnLaunch (0.62s)
=== CONT  TestAccVPCSubnet_tags_ComputedTag_OnCreate
--- PASS: TestAccVPCSubnet_privateDNSNameOptionsOnLaunch (166.17s)
=== CONT  TestAccVPCSubnetsDataSource_filter
--- PASS: TestAccVPCSubnet_tags_ComputedTag_OnCreate (31.57s)
--- PASS: TestAccVPCSubnet_mapPublicIPOnLaunch (92.41s)
--- PASS: TestAccVPCSubnetsDataSource_filter (26.34s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        727.082s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions GitHub Actions
Copy link

Hey @woranhun 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

@github-actions github-actions bot added service/vpc Issues and PRs that pertain to the vpc service. needs-triage Waiting for first response or review from a maintainer. labels Oct 16, 2024
@woranhun woranhun marked this pull request as ready for review October 16, 2024 14:31
@woranhun woranhun requested a review from a team as a code owner October 16, 2024 14:31
@woranhun woranhun changed the title B leaking vpc related resources issue fix B: leaking vpc related resources issue fix Oct 16, 2024
github-actions[bot]
github-actions bot reviewed Oct 16, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @woranhun 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@woranhun woranhun mentioned this pull request Oct 16, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs-triage Waiting for first response or review from a maintainer. service/vpc Issues and PRs that pertain to the vpc service.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: some VPC resources leaking during creation
1 participant
@woranhun