Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Service: s3tables #40420

Merged
merged 35 commits into from
Dec 4, 2024
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
3b4e69f
Adds service S3 Tables
gdavison Nov 7, 2024
891b920
Adds `PrefixNoneOf` and `SuffixNoneOf` framework validators
gdavison Nov 7, 2024
394e4cf
Adds resource `aws_s3tables_table_bucket`
gdavison Nov 7, 2024
f3005ea
Updates `skaff` to use Finder functions in Exists and Destroy tests
gdavison Nov 8, 2024
ba56b11
`skaff`: Adds `ctx` parameter to `testAccPreCheck` call
gdavison Nov 8, 2024
b544c15
Removes unneeded indirection
gdavison Nov 9, 2024
7e61955
Adds resource `aws_s3tables_namespace`
gdavison Nov 9, 2024
8f015fd
Adds resource `aws_s3tables_table_bucket_policy`
gdavison Nov 13, 2024
7297aba
Adds sweeper for `aws_s3tables_table_bucket`
gdavison Nov 13, 2024
0a28a6b
Focuses semgrep message on offending import line
gdavison Nov 19, 2024
2fb0218
Adds resource `aws_s3tables_table`
gdavison Nov 20, 2024
5253a1a
Documentation tweaks
gdavison Nov 20, 2024
5dc2799
Adds sweepers for `aws_s3tables_namespace` and `aws_s3tables_table`
gdavison Nov 20, 2024
e9b03dd
Consolidates name validation
gdavison Nov 20, 2024
7ca5abb
Adds knownvalue check that takes any string-like value
gdavison Nov 21, 2024
35a2e59
Adds `maintenance_configuration` to `aws_s3tables_table_bucket`
gdavison Nov 22, 2024
059bb19
Adds `maintenance_configuration` to `aws_s3tables_table`
gdavison Nov 23, 2024
b2fa7a7
Corrects actions
gdavison Nov 23, 2024
ecef0ea
Adds identifier struct for namespace
gdavison Nov 23, 2024
5d119da
Adds `UseStateForUnknown` for table bucket `maintenance_configuration`
gdavison Nov 23, 2024
6fc0ee4
Updates table bucket `maintenance_configuration` to match table
gdavison Nov 23, 2024
17704dd
Adds resource `aws_s3tables_table_policy`
gdavison Nov 25, 2024
16da3e2
Cleanup
gdavison Nov 25, 2024
c80971f
Excludes flex functions from Semgrep rule
gdavison Nov 25, 2024
a2c50a7
Changes `aws_s3tables_namespace` `namespace` from list to string
gdavison Nov 26, 2024
709e4d8
Documentation cleanup
gdavison Nov 26, 2024
e4799a0
Use `noflatten` for `aws_s3tables_table` `Namespace`
gdavison Nov 27, 2024
6f801b5
Don't allocate Input structs on heap
gdavison Nov 27, 2024
a49f977
Adds CHANGELOG entry
gdavison Dec 3, 2024
41d327e
Corrects branding in documentation
gdavison Dec 3, 2024
4badbf5
Fixes `copyloopvar` linting errors
gdavison Dec 3, 2024
9cc60bf
`tfproviderdocs` doesn't treat newline and space as equivalent
gdavison Dec 3, 2024
b88c7ea
Removes deprecated variable interpolation
gdavison Dec 3, 2024
203a811
More `tfproviderdocs` doesn't treat newline and space as equivalent
gdavison Dec 3, 2024
533bd2c
Required phrasing
gdavison Dec 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use noflatten for aws_s3tables_table Namespace
  • Loading branch information
gdavison committed Dec 3, 2024
commit e4799a08d0ba3b4c5c7d0fa94f3051a16aca4b3f
3 changes: 1 addition & 2 deletions internal/service/s3tables/table.go
Original file line number Diff line number Diff line change
@@ -159,7 +159,6 @@ func (r *resourceTable) Create(ctx context.Context, req resource.CreateRequest,
if resp.Diagnostics.HasError() {
return
}
input.Namespace = plan.Namespace.ValueStringPointer()

_, err := conn.CreateTable(ctx, &input)
if err != nil {
@@ -526,7 +525,7 @@ type resourceTableModel struct {
ModifiedAt timetypes.RFC3339 `tfsdk:"modified_at"`
ModifiedBy types.String `tfsdk:"modified_by"`
Name types.String `tfsdk:"name"`
Namespace types.String `tfsdk:"namespace" autoflex:"-"`
Namespace types.String `tfsdk:"namespace" autoflex:",noflatten"` // On read, Namespace is an array
OwnerAccountID types.String `tfsdk:"owner_account_id"`
TableBucketARN fwtypes.ARN `tfsdk:"table_bucket_arn"`
Type fwtypes.StringEnum[awstypes.TableType] `tfsdk:"type"`