[WIP] feat: Add checksum_crc64nvme arg to aws_s3_object + related resources and data sources #41015
+57
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to add support for the CRC64NVME checksum algorithm for the
aws_s3_object
andaws_s3_object_copy
resources and theaws_s3_object
data source.However, there seems to be an upstream problem where an AWS exception is returned saying that the CRC64NVME algorithm is unknown:
Error: uploading S3 Object (test-key) to Bucket (tf-acc-test-1407191056363142663): operation error S3: PutObject, failed to parse algorithm, unknown checksum algorithm, CRC64NVME
I dug deeper into the call stack and see that there might be an incomplete implementation in the SDK. The source code uses an
Uploader
to upload the file, however it doesn't seem to have references to the CRC64NVME algorithm. This likely is causing some issues.That said, the error seems like a server-side error. At this point I am not exactly sure.
Relations
Closes #40964
References
Referred to PutObject for specs and wordings.
Used CRC - Online Tools to generate checksum values for the test cases.
Output from Acceptance Testing
For
aws_s3_object
resource (note the failed test case):For
aws_s3_object_copy
resource:For
aws_s3_object
data source: