r/aws_athena_database: validate athena db name with regex as per docs #4133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add test cases for possible db names
add testcase for uppercase name refactor test config to one func
appilon
changed the title
appilon
commented
Apr 10, 2018
| @@ -81,7 +117,7 @@ func testAccCheckAWSAthenaDatabaseDestroy(s *terraform.State) error { | |||
| } | |||
|
|
|||
| rInt := acctest.RandInt() | |||
| bucketName := fmt.Sprintf("tf-athena-db-%s-%d", rs.Primary.Attributes["name"], rInt) | |||
There was a problem hiding this comment.
In the case where I had an _ in the db name, creating a bucket with that name in it caused an error, the random integer should be sufficient in ensuring a unique bucketName
bflad
added
bug
bflad
approved these changes
Apr 12, 2018
There was a problem hiding this comment.
LGTM! 🚀
5 tests passed (all tests)
=== RUN TestAccAWSAthenaDatabase_nameCantHaveUppercase
--- PASS: TestAccAWSAthenaDatabase_nameCantHaveUppercase (0.99s)
=== RUN TestAccAWSAthenaDatabase_basic
--- PASS: TestAccAWSAthenaDatabase_basic (31.25s)
=== RUN TestAccAWSAthenaDatabase_nameStartsWithUnderscore
--- PASS: TestAccAWSAthenaDatabase_nameStartsWithUnderscore (32.78s)
=== RUN TestAccAWSAthenaDatabase_forceDestroyAlwaysSucceeds
--- PASS: TestAccAWSAthenaDatabase_forceDestroyAlwaysSucceeds (36.63s)
=== RUN TestAccAWSAthenaDatabase_destroyFailsIfTablesExist
--- PASS: TestAccAWSAthenaDatabase_destroyFailsIfTablesExist (41.79s)
bflad
added a commit
that referenced
this pull request
Apr 12, 2018
|
This has been released in version 1.15.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4128
Validate athena db name with regex as per docs (also wrap name in SQL syntax with `` to support leading underscore as per docs)
https://docs.aws.amazon.com/athena/latest/ug/tables-databases-columns-names.html
Also simplify config to 1 function