Support password data on spot requests

[bodgit]

#2219 added support for retrieving the instance password data but this wasn't also added for spot requests so even though the same get_password_data attribute can be set (due to the spot request schema inheriting the instance schema), it doesn't work and returns an error if you try and read the password_data attribute.

This PR simply copies the same code from the original PR that read the password data and now works for me with a Windows spot request the same as a regular instance.

[bflad]

Can you please add an acceptance test to cover the behavior when its enabled (we just need to test the true scenario)? You can use TestAccAWSInstance_getPasswordData_trueToFalse and its testAccInstanceConfig_getPasswordData configuration as inspiration. Thanks!

[bodgit]

If I back my original change out with this test present:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSpotInstanceRequest_getPasswordData'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSpotInstanceRequest_getPasswordData -timeout 120m
=== RUN   TestAccAWSSpotInstanceRequest_getPasswordData
--- FAIL: TestAccAWSSpotInstanceRequest_getPasswordData (106.26s)
        testing.go:518: Step 0 error: Check failed: Check 2/2 error: aws_spot_instance_request.foo: Attribute 'password_data' expected to be set
FAIL
exit status 1
FAIL    github.com/terraform-providers/terraform-provider-aws/aws       106.274s
make: *** [testacc] Error 1

And with my change back in:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSpotInstanceRequest_getPasswordData'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSpotInstanceRequest_getPasswordData -timeout 120m
=== RUN   TestAccAWSSpotInstanceRequest_getPasswordData
--- PASS: TestAccAWSSpotInstanceRequest_getPasswordData (280.86s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       280.875s

Ok?

[bflad]

Great work @bodgit! 🚀

7 tests passed (all tests)
=== RUN   TestAccAWSSpotInstanceRequest_NetworkInterfaceAttributes
--- PASS: TestAccAWSSpotInstanceRequest_NetworkInterfaceAttributes (85.62s)
=== RUN   TestAccAWSSpotInstanceRequest_withBlockDuration
--- PASS: TestAccAWSSpotInstanceRequest_withBlockDuration (87.49s)
=== RUN   TestAccAWSSpotInstanceRequest_SubnetAndSGAndPublicIpAddress
--- PASS: TestAccAWSSpotInstanceRequest_SubnetAndSGAndPublicIpAddress (90.57s)
=== RUN   TestAccAWSSpotInstanceRequest_withLaunchGroup
--- PASS: TestAccAWSSpotInstanceRequest_withLaunchGroup (107.97s)
=== RUN   TestAccAWSSpotInstanceRequest_basic
--- PASS: TestAccAWSSpotInstanceRequest_basic (108.00s)
=== RUN   TestAccAWSSpotInstanceRequest_vpc
--- PASS: TestAccAWSSpotInstanceRequest_vpc (123.09s)
=== RUN   TestAccAWSSpotInstanceRequest_getPasswordData
--- PASS: TestAccAWSSpotInstanceRequest_getPasswordData (343.69s)

[bflad]

This has been released in version 1.15.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!